Uploaded image for project: 'Apache Gora'
  1. Apache Gora
  2. GORA-465

Remove @Deprecated logic for hbase-mapping.xml

    XMLWordPrintableJSON

Details

    • Test
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 0.6.1
    • 0.7
    • gora-hbase
    • None

    Description

      We have some useless checking and log statements in HBaseStore which relate to a very old hbase-mapping.xml.
      These should just be removed.

        @Deprecated
        private static final String DEPRECATED_MAPPING_FILE = "hbase-mapping.xml";
      ...
            try {
              mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEPRECATED_MAPPING_FILE));
              LOG.warn("{} is deprecated, please rename the file to {}", DEPRECATED_MAPPING_FILE, DEFAULT_MAPPING_FILE);
            } catch (FileNotFoundException ex1) {
              LOG.error(ex1.getMessage(), ex1);
              //throw (ex1); //throw the original exception
            } catch (Exception ex1) {
              LOG.warn("{} is deprecated, please rename the file to {}", DEPRECATED_MAPPING_FILE, DEFAULT_MAPPING_FILE);
              throw new RuntimeException(ex1);
            } 
      

      etc

      Attachments

        Issue Links

          Activity

            People

              cguzel Cihad Guzel
              lewismc Lewis John McGibbney
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: