Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-7992

Sort methods that accept a comparator should accept Comparator<? super T> (fix type checker ability to cope with super in DGM methods)

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.4.7
    • 4.0.7, 3.0.20
    • groovy-jdk
    • None

    Description

      Methods like org.codehaus.groovy.runtime.DefaultGroovyMethods.sort(Iterable<T>, boolean, Comparator<T>) and all the others alike should be changed to accept a Comparator<? super T>, otherwise if you use @CompileStatic you'll get compiler errors as soon as you try to sort an Iterable/Collection using a comparator that accept superclass instances.

      Attachments

        Issue Links

          is a clone of

          Bug - A problem which impairs or prevents the functions of the product. GROOVY-7976 Sort methods that accept a comparator should accept Comparator<? super T> (fix DGM signatures)

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. GROOVY-9803 Static type checker forgets nested generic types

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. GROOVY-9998 Wildcards with a lower bound fail static type checking

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. GROOVY-9762 Wrong type resolved if method reference used with typed method

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link GitHub Pull Request #1779

          Activity

            People

              emilles Eric Milles
              mauromol Mauro Molinari
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: