Description
There is an extra seek(0) on FileLink open, that we can skip
Attachments
Attachments
- HBASE-10631-v0.patch
- 0.7 kB
- Matteo Bertozzi
Activity
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12631641/HBASE-10631-v0.patch
against trunk revision .
ATTACHMENT ID: 12631641
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.
+1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 lineLengths. The patch does not introduce lines longer than 100
+1 site. The mvn site goal succeeds with this patch.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8842//console
This message is automatically generated.
SUCCESS: Integrated in HBase-0.94-security #426 (See https://builds.apache.org/job/HBase-0.94-security/426/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572892)
- /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
SUCCESS: Integrated in HBase-0.98 #191 (See https://builds.apache.org/job/HBase-0.98/191/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572890)
- /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
FAILURE: Integrated in HBase-0.94-JDK7 #68 (See https://builds.apache.org/job/HBase-0.94-JDK7/68/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572892)
- /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
FAILURE: Integrated in hbase-0.96 #320 (See https://builds.apache.org/job/hbase-0.96/320/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572891)
- /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #179 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/179/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572890)
- /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
FAILURE: Integrated in HBase-TRUNK #4965 (See https://builds.apache.org/job/HBase-TRUNK/4965/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572889)
- /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
FAILURE: Integrated in HBase-0.94 #1304 (See https://builds.apache.org/job/HBase-0.94/1304/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572892)
- /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #36 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/36/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572892)
- /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
SUCCESS: Integrated in hbase-0.96-hadoop2 #220 (See https://builds.apache.org/job/hbase-0.96-hadoop2/220/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572891)
- /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #102 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/102/)
HBASE-10631 Avoid extra seek on FileLink open (mbertozzi: rev 1572889)
- /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java
lgtm. +1