Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10766

SnapshotCleaner allows to delete referenced files

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.98.0, 0.96.1.1, 0.94.17
    • 0.96.2, 0.98.1, 0.99.0, 0.94.19
    • snapshots
    • None

    Description

      The SnapshotFileCache is checking the lastModificationTime() of the ".hbase-snapshot" directory.
      But in this way "pending" snapshots created in temp are not considered.
      since only the parent directory timestamp is updated.

      so, if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification timestamp of .hbase-snapshot will not be updated

      https://github.com/apache/hbase/blob/af62395ef3f7e2a8be2ab16d272e5245902d7864/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197

      Attachments

        1. HBASE-10766-v2.patch
          6 kB
          Matteo Bertozzi
        2. HBASE-10766-v1.patch
          6 kB
          Matteo Bertozzi

        Activity

          People

            bharathv Bharath Vissapragada
            mbertozzi Matteo Bertozzi
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: