Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.98.1
    • 0.99.0, 0.98.2
    • Scanners
    • None
    • Reviewed

    Description

      From HBASE-10936.

      testZeroByte[1](org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders)  Time elapsed: 0.008 sec  <<< ERROR!
      java.lang.IndexOutOfBoundsException
              at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:138)
              at java.io.DataOutputStream.write(DataOutputStream.java:107)
              at org.apache.hadoop.hbase.util.ByteBufferUtils.copyBufferToStream(ByteBufferUtils.java:163)
              at org.apache.hadoop.hbase.util.ByteBufferUtils.moveBufferToStream(ByteBufferUtils.java:147)
              at org.apache.hadoop.hbase.io.encoding.PrefixKeyDeltaEncoder.addKV(PrefixKeyDeltaEncoder.java:70)
              at org.apache.hadoop.hbase.io.encoding.PrefixKeyDeltaEncoder.internalEncodeKeyValues(PrefixKeyDeltaEncoder.java:87)
              at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder.encodeKeyValues(BufferedDataBlockEncoder.java:591)
              at org.apache.hadoop.hbase.io.encoding.PrefixKeyDeltaEncoder.encodeKeyValues(PrefixKeyDeltaEncoder.java:44)
              at org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.encodeBytes(TestDataBlockEncoders.java:100)
              at org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.testAlgorithm(TestDataBlockEncoders.java:112)
              at org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.testEncodersOnDataset(TestDataBlockEncoders.java:423)
              at org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.testZeroByte(TestDataBlockEncoders.java:208)
      

      See attached test case.

      Attachments

        1. HBASE-10972.patch
          1 kB
          ramkrishna.s.vasudevan
        2. 10936-0.98.txt
          1 kB
          Andrew Kyle Purtell

        Activity

          apurtell Andrew Kyle Purtell added a comment - Ping ram_krish

          Thanks Ram!

          apurtell Andrew Kyle Purtell added a comment - Thanks Ram!

          This would pass. We need to add tags in 0.98 and trunk.

          ram_krish ramkrishna.s.vasudevan added a comment - This would pass. We need to add tags in 0.98 and trunk.
          enis Enis Soztutar added a comment -

          We need to add tags in 0.98 and trunk.

          So this is not a bug for the encoders, but the test, right?
          Let's commit if hadoopqa passes.

          enis Enis Soztutar added a comment - We need to add tags in 0.98 and trunk. So this is not a bug for the encoders, but the test, right? Let's commit if hadoopqa passes.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12640102/HBASE-10972.patch
          against trunk revision .
          ATTACHMENT ID: 12640102

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestDistributedLogSplitting

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScan(TestMultiTableInputFormat.java:244)
          at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScanYZYToEmpty(TestMultiTableInputFormat.java:195)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640102/HBASE-10972.patch against trunk revision . ATTACHMENT ID: 12640102 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestDistributedLogSplitting -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScan(TestMultiTableInputFormat.java:244) at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScanYZYToEmpty(TestMultiTableInputFormat.java:195) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9287//console This message is automatically generated.

          Committed to 0.98 and trunk. Thanks for the reviews Andy and Enis. Test failure seems unrelated.

          ram_krish ramkrishna.s.vasudevan added a comment - Committed to 0.98 and trunk. Thanks for the reviews Andy and Enis. Test failure seems unrelated.

          JFYI. The issue is not with Prefix Key, but with the test. Even other algos DIFF, FAST_DIFF would fail here. The thing is test fails even before those algos are run.

          ram_krish ramkrishna.s.vasudevan added a comment - JFYI. The issue is not with Prefix Key, but with the test. Even other algos DIFF, FAST_DIFF would fail here. The thing is test fails even before those algos are run.
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #261 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/261/)
          HBASE-10972 - OOBE in prefix key encoding (Ram) (ramkrishna: rev 1587418)

          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #261 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/261/ ) HBASE-10972 - OOBE in prefix key encoding (Ram) (ramkrishna: rev 1587418) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5085 (See https://builds.apache.org/job/HBase-TRUNK/5085/)
          HBASE-10972 - OOBE in prefix key encoding (Ram) (ramkrishna: rev 1587417)

          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5085 (See https://builds.apache.org/job/HBase-TRUNK/5085/ ) HBASE-10972 - OOBE in prefix key encoding (Ram) (ramkrishna: rev 1587417) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #277 (See https://builds.apache.org/job/HBase-0.98/277/)
          HBASE-10972 - OOBE in prefix key encoding (Ram) (ramkrishna: rev 1587418)

          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #277 (See https://builds.apache.org/job/HBase-0.98/277/ ) HBASE-10972 - OOBE in prefix key encoding (Ram) (ramkrishna: rev 1587418) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          enis Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          enis Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

            ram_krish ramkrishna.s.vasudevan
            apurtell Andrew Kyle Purtell
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: