Details
Description
If I'm not wrong, the UPSERT method of memStore should remove all existing KeyValues except the newer version.
In memStore,
DefaultMemStore.java
int versIionsVisible = 0; ... if (cur.getTypeByte() == KeyValue.Type.Put.getCode() && cur.getSequenceId() <= readpoint) { if (versionsVisible > 1) { // if we get here we have seen at least one version visible to the oldest scanner, // which means we can prove that no scanner will see this version // false means there was a change, so give us the size. long delta = heapSizeChange(cur, true); addedSize -= delta; this.size.addAndGet(-delta); it.remove(); setOldestEditTimeToNow(); } else { versionsVisible++; }
Does "versionsVisible > 1" should be changed to "versionsVisible >= 1" ?
thanks.
Attachments
Attachments
Issue Links
- is related to
-
HBASE-4583 Integrate RWCC with Append and Increment operations
- Closed