Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13030

[1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, Delete, etc., addColumn

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.0.0
    • 1.0.0, 1.1.0
    • Operability
    • None
    • Reviewed
    • Hide
      Miscellaneous cleanup. Make ScanMetrics audience public -- was mistakenly made private -- and make their access more amenable. Make Put like Delete and Get adding addColumn method (deprecating add). Make the ByteBuffer returned by Cell read only. Add to CellUtil a method to get a ByteRange on a value.
      Show
      Miscellaneous cleanup. Make ScanMetrics audience public -- was mistakenly made private -- and make their access more amenable. Make Put like Delete and Get adding addColumn method (deprecating add). Make the ByteBuffer returned by Cell read only. Add to CellUtil a method to get a ByteRange on a value.

    Description

      These are some of the items raised by larsgeorge looking at our API for first time in a long time trying to update examples in the HBase Book.

      1. ScanMetrics used to be available with some gymnastics in old days. Now it is IA.private and to get at it from Scan context, you need to use private ProtobufUtils. This seems like useful advanced user utility that should not be shut down.
      2. Put is not like the others around the addColumn usage. Fix.

      enis Hopefully these ok to go in (the Scan class addition is a little ugly but didn't want to do anything more adventurous this late in the game).

      Attachments

        1. 13030.txt
          9 kB
          Michael Stack
        2. 13030v10.txt
          29 kB
          Michael Stack
        3. 13030v11.txt
          28 kB
          Michael Stack
        4. 13030v12.txt
          33 kB
          Michael Stack
        5. 13030v2.txt
          8 kB
          Michael Stack
        6. 13030v3.txt
          11 kB
          Michael Stack
        7. 13030v5.txt
          28 kB
          Michael Stack
        8. 13030v7.txt
          28 kB
          Michael Stack
        9. 13030v8.txt
          23 kB
          Michael Stack
        10. 13030v9.txt
          29 kB
          Michael Stack
        11. addendum.txt
          2 kB
          Michael Stack
        12. hbase-13030-scanmetrics.patch
          23 kB
          Enis Soztutar
        13. hbase-13030-v6.patch
          28 kB
          Enis Soztutar

        Issue Links

          is related to

          Task - A task that needs to be done. HBASE-21908 Remove Scan.getScanMetrics

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              stack Michael Stack
              stack Michael Stack
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: