Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14256

Flush task message may be confusing when region is recovered

    XMLWordPrintableJSON

Details

    • Reviewed
    • HBASE-14256 Correct confusing flush task message

    Description

      In HRegion.setRecovering() we have this code:

          // force a flush only if region replication is set up for this region. Otherwise no need.
            boolean forceFlush = getTableDesc().getRegionReplication() > 1;
      
            // force a flush first
            MonitoredTask status = TaskMonitor.get().createStatus(
              "Flushing region " + this + " because recovery is finished");
            try {
              if (forceFlush) {
                internalFlushcache(status);
              }
      

      So we only optionally force flush after a recovery of a region, but the message always is set to "Flushing...", which might be confusing. We should change the message based on forceFlush.

      Attachments

        1. HBASE-14256.1.patch
          2 kB
          Jerry He

        Activity

          People

            gliptak Gabor Liptak
            larsgeorge Lars George
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: