Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15645

hbase.rpc.timeout is not used in operations of HTable

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 1.3.0, 1.2.1, 1.0.3, 1.1.4, 2.0.0
    • 1.3.0, 1.0.4, 1.1.5, 1.2.2, 2.0.0
    • None
    • None
    • Reviewed
    • Hide
      Fixes regression where hbase.rpc.timeout configuration was ignored in branch-1.0+

      Adds new methods setOperationTimeout, getOperationTimeout, setRpcTimeout, and getRpcTimeout to Table. In branch-1.3+ they are public interfaces and in 1.0-1.2 they are labeled as @InterfaceAudience.Private.

      Adds hbase.client.operation.timeout to hbase-default.xml with default of 1200000
      Show
      Fixes regression where hbase.rpc.timeout configuration was ignored in branch-1.0+ Adds new methods setOperationTimeout, getOperationTimeout, setRpcTimeout, and getRpcTimeout to Table. In branch-1.3+ they are public interfaces and in 1.0-1.2 they are labeled as @InterfaceAudience.Private. Adds hbase.client.operation.timeout to hbase-default.xml with default of 1200000

    Description

      While fixing HBASE-15593, I find that we use operationTimeout as the timeout of Get operation rpc call (hbase.client.scanner.timeout.period is used in scan rpc), not the hbase.rpc.timeout.

      This can be verified by add one line in TestHCM.setUpBeforeClass():

      TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_RPC_TIMEOUT_KEY, 3000);

      and then run testOperationTimeout(), the test passes but it should have failed because we should get rpc timeout first after 3 seconds then client should retry and timeout again and again until operationTimeout or max retries reached.

      If I port this test to 0.98, it will fail as expected.

      Attachments

        1. HBASE-15645-v1.patch
          15 kB
          Phil Yang
        2. HBASE-15645-v2.patch
          16 kB
          Phil Yang
        3. HBASE-15645-v3.patch
          21 kB
          Phil Yang
        4. HBASE-15645-v4.patch
          24 kB
          Phil Yang
        5. HBASE-15645-branch-1-v1.patch
          24 kB
          Phil Yang
        6. HBASE-15645-branch-1.2-v1.patch
          26 kB
          Phil Yang
        7. HBASE-15645-branch-1.0-v1.patch
          24 kB
          Phil Yang
        8. HBASE-15645-branch-1.1-v1.patch
          26 kB
          Phil Yang
        9. lable.patch
          2 kB
          Phil Yang

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. HBASE-16420 Fix source incompatibility of Table interface

          • Major - Major loss of function.
          • Resolved
          Is contained by

          Task - A task that needs to be done. HBASE-18223 Track the effort to improve/bug fix read replica feature

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-17449 Add explicit document on different timeout settings

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          links to

          Web Link review board

          Activity

            People

              yangzhe1991 Phil Yang
              yangzhe1991 Phil Yang
              Votes:
              0 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: