Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16172

Unify the retry logic in ScannerCallableWithReplicas and RpcRetryingCallerWithReadReplicas

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0, 2.0.0
    • None
    • None
    • Reviewed

    Description

      The issue is pointed out by devaraj in HBASE-16132 (Thanks D.D.), that in RpcRetryingCallerWithReadReplicas#call we will call ResultBoundedCompletionService#take instead of poll to dead-wait on the second one if the first replica timed out, while in ScannerCallableWithReplicas#call we still use ResultBoundedCompletionService#poll with some timeout for the 2nd replica.

      This JIRA aims at discussing whether to unify the logic in these two kinds of caller with region replica and taking action if necessary.

      Attachments

        1. 16172.v4.txt
          5 kB
          Ted Yu
        2. 16172.v4.txt
          5 kB
          Ted Yu
        3. 16172.v4.txt
          5 kB
          Ted Yu
        4. 16172.v3.txt
          3 kB
          Ted Yu
        5. 16172.v2.txt
          3 kB
          Ted Yu
        6. 16172.v2.txt
          3 kB
          Ted Yu
        7. 16172.v1.txt
          2 kB
          Ted Yu
        8. 16172.branch-1.v4.txt
          5 kB
          Ted Yu

        Issue Links

          Activity

            People

              yuzhihong@gmail.com Ted Yu
              liyu Yu Li
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: