Details
-
Wish
-
Status: Resolved
-
Trivial
-
Resolution: Fixed
-
2.0.0
-
None
-
None
-
Incompatible change
-
Empty filter list will behave as when there is no filter added. This change is a behavioral change for those who rely on Empty filter list.
Description
Current empty FilterList filters all data, because the FilterList#isFamilyEssential always returns false which causes the null cell retrieved by RegionScannerImpl.storeHeap.
It seems to me that empty FilterList should do nothing, because the following code is common.
private static Filter makeFilter() {
FilterList filterList = new FilterList ();
for (some conditions) {
// add some filters. Or nothing to add.
}
return filterList;
}
If we keep the current logic which filters all data, we should add enough comments to explain it. Or add the FilterList#size() or FilterList#empty() for preventing filtering all data.
Any comments? Thanks.
Attachments
Attachments
Issue Links
- is related to
-
-
- Closed
-
- relates to
-
HBASE-16731 Inconsistent results from the Get/Scan if we use the empty FilterList
-
- Resolved
-