Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19210

TestNamespacesInstanceResource fails

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-beta-1, 2.0.0
    • None
    • None
    • Reviewed

    Description

      This is the top flaky test.
      The following can be reproduced:

      java.net.SocketException: Connection reset
      	at org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
      

      With commit e320df5a0c267258c03909da8d0eee4c0e287532, the test passes.
      With commit 5facaded902a13556952b1f9d26b768cb86e6599, the test fails.

      Attachments

        1. 19210.addendum
          1 kB
          Ted Yu
        2. 19210.v1.txt
          0.5 kB
          Ted Yu
        3. 19210.v1.txt
          0.5 kB
          Ted Yu
        4. 19210.v2.txt
          1 kB
          Ted Yu
        5. 19210.v3.txt
          1.0 kB
          Ted Yu
        6. 19210-addendum-3.txt
          2 kB
          Ted Yu
        7. 19210-addendum-4.txt
          2 kB
          Ted Yu
        8. 19210-addendum-5.txt
          0.9 kB
          Ted Yu
        9. HBASE-19210.WIP.patch
          12 kB
          Mike Drob

        Issue Links

          Activity

            mdrob Mike Drob added a comment -

            This is passing locally on tip of master for me with command:
            mvn clean test -Dtest=TestNamespacesInstanceResource#testInvalidNamespacePostsAndPuts -pl hbase-rest -am

            Connection reset looks like a resourcing issue? How do you reproduce this one, tedyu?

            mdrob Mike Drob added a comment - This is passing locally on tip of master for me with command: mvn clean test -Dtest=TestNamespacesInstanceResource#testInvalidNamespacePostsAndPuts -pl hbase-rest -am Connection reset looks like a resourcing issue? How do you reproduce this one, tedyu ?
            yuzhihong@gmail.com Ted Yu added a comment -

            Please use -Dtest=TestNamespacesInstanceResource

            Even if there is no other test running, this test still fails - in the same place each time.

            yuzhihong@gmail.com Ted Yu added a comment - Please use -Dtest=TestNamespacesInstanceResource Even if there is no other test running, this test still fails - in the same place each time.
            mdrob Mike Drob added a comment -

            Yes, I see that now, thanks for the pointer.

            Interesting discovery here - if I @Ignore testNamespaceCreateAndDeleteXMLAndJSON (a different test}} then suddenly testInvalidNamespacePostsAndPuts starts passing for me.

            mdrob Mike Drob added a comment - Yes, I see that now, thanks for the pointer. Interesting discovery here - if I @Ignore testNamespaceCreateAndDeleteXMLAndJSON (a different test}} then suddenly testInvalidNamespacePostsAndPuts starts passing for me.
            mdrob Mike Drob added a comment -

            Something about line 307 sets the rest server into a bad state:

                response = client.put(namespacePath2, Constants.MIMETYPE_JSON, Bytes.toBytes(jsonString));
            
            mdrob Mike Drob added a comment - Something about line 307 sets the rest server into a bad state: response = client.put(namespacePath2, Constants.MIMETYPE_JSON, Bytes.toBytes(jsonString));
            yuzhihong@gmail.com Ted Yu added a comment -
            2017-11-08 00:44:49,514 WARN  [qtp976725249-465] server.HttpChannel(517): /namespaces/TestNamespacesInstanceResource1
            javax.servlet.ServletException: org.glassfish.jersey.server.ContainerException: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('<' (code 60)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')
             at [Source: (org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$UnCloseableInputStream); line: 1, column: 2]
              at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489)
              at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
              at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:388)
              at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:341)
            

            The above appears in both failed and successful cases.

            2017-11-07 18:31:21,578 WARN  [qtp1109258131-428] server.HttpChannel(517): /namespaces/TestNamespacesInstanceResource3
            javax.servlet.ServletException: org.glassfish.jersey.server.ContainerException: com.google.protobuf.InvalidProtocolBufferException: Protocol message end-group tag did not match  expected tag.
              at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489)
              at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
              at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:388)
              at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:341)
              at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:228)
              at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
            

            The above is seen only in successful run.

            yuzhihong@gmail.com Ted Yu added a comment - 2017-11-08 00:44:49,514 WARN [qtp976725249-465] server.HttpChannel(517): /namespaces/TestNamespacesInstanceResource1 javax.servlet.ServletException: org.glassfish.jersey.server.ContainerException: com.fasterxml.jackson.core.JsonParseException: Unexpected character ( '<' (code 60)): expected a valid value (number, String , array, object, ' true ' , ' false ' or ' null ' ) at [Source: (org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$UnCloseableInputStream); line: 1, column: 2] at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489) at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:388) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:341) The above appears in both failed and successful cases. 2017-11-07 18:31:21,578 WARN [qtp1109258131-428] server.HttpChannel(517): /namespaces/TestNamespacesInstanceResource3 javax.servlet.ServletException: org.glassfish.jersey.server.ContainerException: com.google.protobuf.InvalidProtocolBufferException: Protocol message end-group tag did not match expected tag. at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489) at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:388) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:341) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:228) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841) The above is seen only in successful run.
            mdrob Mike Drob added a comment -

            Yea, we're testing three invalid http calls, the test errors out on the second one. Exceptions in the logs are expected.

            mdrob Mike Drob added a comment - Yea, we're testing three invalid http calls, the test errors out on the second one. Exceptions in the logs are expected.
            yuzhihong@gmail.com Ted Yu added a comment -

            Hmm There is no DEBUG output from REST server around the assertion failure.

            How about separating the subtest out to its own file ?

            yuzhihong@gmail.com Ted Yu added a comment - Hmm There is no DEBUG output from REST server around the assertion failure. How about separating the subtest out to its own file ?
            mdrob Mike Drob added a comment -

            WIP Patch: Cleans up a lot of the test to reduce duplication. Ignores the failing test for now. Created a new minimal test (also ignored) that will fail when run by itself.

            Like Ted remarked, I also haven't been able to get hbase-rest logs yet, will need to tweak logger settings and see if that gets me there.

            mdrob Mike Drob added a comment - WIP Patch: Cleans up a lot of the test to reduce duplication. Ignores the failing test for now. Created a new minimal test (also ignored) that will fail when run by itself. Like Ted remarked, I also haven't been able to get hbase-rest logs yet, will need to tweak logger settings and see if that gets me there.
            yuzhihong@gmail.com Ted Yu added a comment -

            Upgrading jackson version fixes the test.

            yuzhihong@gmail.com Ted Yu added a comment - Upgrading jackson version fixes the test.
            mdrob Mike Drob added a comment -

            I don't see anything in the Jackson release notes that would suggest this, but I'm +1 for updating to the latest version in general. Ship it, Ted.

            mdrob Mike Drob added a comment - I don't see anything in the Jackson release notes that would suggest this, but I'm +1 for updating to the latest version in general. Ship it, Ted.
            yuzhihong@gmail.com Ted Yu added a comment -

            There is no 2.9.2 under https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.10

            Patch v2 drops the dependency in hbase-spark module which is not used.

            yuzhihong@gmail.com Ted Yu added a comment - There is no 2.9.2 under https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.10 Patch v2 drops the dependency in hbase-spark module which is not used.
            mdrob Mike Drob added a comment -

            The dep in hbase-spark for the scala specific bindings was necessary to fix some scala serialization. Tests are going to fail without it.

            mdrob Mike Drob added a comment - The dep in hbase-spark for the scala specific bindings was necessary to fix some scala serialization. Tests are going to fail without it.
            elserj Josh Elser added a comment -

            FYI, keep an eye on HBASE-19147, please. Linked it here. Wouldn't want Stack to be chasing down this test to find out you fixed it already.

            elserj Josh Elser added a comment - FYI, keep an eye on HBASE-19147 , please. Linked it here. Wouldn't want Stack to be chasing down this test to find out you fixed it already.
            yuzhihong@gmail.com Ted Yu added a comment -

            Raised https://github.com/FasterXML/jackson-module-scala/issues/350 for jackson to populate the maven artifacts

            yuzhihong@gmail.com Ted Yu added a comment - Raised https://github.com/FasterXML/jackson-module-scala/issues/350 for jackson to populate the maven artifacts
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 19s Docker mode activated.
            0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  master Compile Tests
            0 mvndep 0m 28s Maven dependency ordering for branch
            +1 mvninstall 4m 25s master passed
            +1 compile 4m 50s master passed
            +1 shadedjars 14m 1s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 2m 34s master passed
                  Patch Compile Tests
            0 mvndep 0m 12s Maven dependency ordering for patch
            +1 mvninstall 4m 27s the patch passed
            +1 compile 5m 13s the patch passed
            +1 javac 5m 13s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 3s The patch has no ill-formed XML file.
            +1 shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 58m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
            +1 javadoc 2m 59s the patch passed
                  Other Tests
            -1 unit 154m 55s root in the patch failed.
            +1 asflicense 0m 21s The patch does not generate ASF License warnings.
            244m 19s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19210
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12896693/19210.v2.txt
            Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile
            uname Linux 1d61a2ad10d5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / 5af1f1b1e4
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/9685/artifact/patchprocess/patch-unit-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9685/testReport/
            modules C: . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9685/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 4m 25s master passed +1 compile 4m 50s master passed +1 shadedjars 14m 1s branch has no errors when building our shaded downstream artifacts. +1 javadoc 2m 34s master passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 4m 27s the patch passed +1 compile 5m 13s the patch passed +1 javac 5m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 58m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 2m 59s the patch passed       Other Tests -1 unit 154m 55s root in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 244m 19s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19210 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12896693/19210.v2.txt Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile uname Linux 1d61a2ad10d5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 5af1f1b1e4 maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 unit https://builds.apache.org/job/PreCommit-HBASE-Build/9685/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9685/testReport/ modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9685/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            yuzhihong@gmail.com Ted Yu added a comment -

            Patch v3 upgrades jackson for all components except for hbase-spark module.

            yuzhihong@gmail.com Ted Yu added a comment - Patch v3 upgrades jackson for all components except for hbase-spark module.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 9s Docker mode activated.
            0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  master Compile Tests
            0 mvndep 0m 13s Maven dependency ordering for branch
            +1 mvninstall 4m 42s master passed
            +1 compile 5m 16s master passed
            +1 shadedjars 14m 58s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 3m 21s master passed
                  Patch Compile Tests
            0 mvndep 0m 14s Maven dependency ordering for patch
            +1 mvninstall 5m 13s the patch passed
            +1 compile 5m 56s the patch passed
            +1 javac 5m 56s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 3s The patch has no ill-formed XML file.
            +1 shadedjars 5m 15s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 57m 53s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
            +1 javadoc 3m 22s the patch passed
                  Other Tests
            +1 unit 184m 3s root in the patch passed.
            +1 asflicense 0m 24s The patch does not generate ASF License warnings.
            275m 58s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19210
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897208/19210.v3.txt
            Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile
            uname Linux 174b65bcde0d 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
            git revision master / bff619ef7b
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9747/testReport/
            modules C: . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9747/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 4m 42s master passed +1 compile 5m 16s master passed +1 shadedjars 14m 58s branch has no errors when building our shaded downstream artifacts. +1 javadoc 3m 21s master passed       Patch Compile Tests 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 5m 13s the patch passed +1 compile 5m 56s the patch passed +1 javac 5m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 shadedjars 5m 15s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 57m 53s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 3m 22s the patch passed       Other Tests +1 unit 184m 3s root in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 275m 58s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19210 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897208/19210.v3.txt Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile uname Linux 174b65bcde0d 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / bff619ef7b maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9747/testReport/ modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9747/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            mdrob Mike Drob added a comment -

            tedyu - the jackson issue you filed is closed now and artifacts should be mirrored everywhere soon, let's stick with 2.9.2 everywhere.

            mdrob Mike Drob added a comment - tedyu - the jackson issue you filed is closed now and artifacts should be mirrored everywhere soon, let's stick with 2.9.2 everywhere.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 13s Docker mode activated.
            0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  master Compile Tests
            +1 mvninstall 6m 27s master passed
            +1 compile 5m 51s master passed
            +1 shadedjars 18m 16s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 4m 35s master passed
                  Patch Compile Tests
            +1 mvninstall 6m 27s the patch passed
            +1 compile 5m 34s the patch passed
            +1 javac 5m 34s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 2s The patch has no ill-formed XML file.
            +1 shadedjars 5m 47s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 73m 1s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
            +1 javadoc 5m 42s the patch passed
                  Other Tests
            +1 unit 233m 28s root in the patch passed.
            +1 asflicense 0m 24s The patch does not generate ASF License warnings.
            348m 0s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19210
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897303/19210.v1.txt
            Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile
            uname Linux 0833092a83dd 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / 5c312667ed
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9762/testReport/
            modules C: . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9762/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests +1 mvninstall 6m 27s master passed +1 compile 5m 51s master passed +1 shadedjars 18m 16s branch has no errors when building our shaded downstream artifacts. +1 javadoc 4m 35s master passed       Patch Compile Tests +1 mvninstall 6m 27s the patch passed +1 compile 5m 34s the patch passed +1 javac 5m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 shadedjars 5m 47s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 73m 1s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 5m 42s the patch passed       Other Tests +1 unit 233m 28s root in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 348m 0s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19210 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897303/19210.v1.txt Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile uname Linux 0833092a83dd 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 5c312667ed maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9762/testReport/ modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9762/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            yuzhihong@gmail.com Ted Yu added a comment -

            mdrob:
            Can you take a look ?

            yuzhihong@gmail.com Ted Yu added a comment - mdrob : Can you take a look ?
            mdrob Mike Drob added a comment -

            +1

            mdrob Mike Drob added a comment - +1
            mdrob Mike Drob added a comment -

            Reverted your commit and pushed one that includes the issue number. Thanks for delving into this, Ted!

            mdrob Mike Drob added a comment - Reverted your commit and pushed one that includes the issue number. Thanks for delving into this, Ted!
            yuzhihong@gmail.com Ted Yu added a comment - - edited

            But now the author becomes Mike Drob.

            Re-committed with proper author

            yuzhihong@gmail.com Ted Yu added a comment - - edited But now the author becomes Mike Drob. Re-committed with proper author
            mdrob Mike Drob added a comment -

            Thanks

            mdrob Mike Drob added a comment - Thanks
            yuzhihong@gmail.com Ted Yu added a comment -

            From https://builds.apache.org/job/HBASE-Flaky-Tests/23340/testReport/junit/org.apache.hadoop.hbase.rest/TestNamespacesInstanceResource/testInvalidNamespacePostsAndPuts/ :

            org.apache.http.NoHttpResponseException: localhost:46004 failed to respond
            	at org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
            
            yuzhihong@gmail.com Ted Yu added a comment - From https://builds.apache.org/job/HBASE-Flaky-Tests/23340/testReport/junit/org.apache.hadoop.hbase.rest/TestNamespacesInstanceResource/testInvalidNamespacePostsAndPuts/ : org.apache.http.NoHttpResponseException: localhost:46004 failed to respond at org.apache.hadoop.hbase. rest .TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
            yuzhihong@gmail.com Ted Yu added a comment -

            Maybe testInvalidNamespacePostsAndPuts can be put into its own test file.

            yuzhihong@gmail.com Ted Yu added a comment - Maybe testInvalidNamespacePostsAndPuts can be put into its own test file.
            yuzhihong@gmail.com Ted Yu added a comment -

            Under debugger when running testInvalidNamespacePostsAndPuts alone, code 500 was in response:

                response = client.put(namespacePath2, Constants.MIMETYPE_XML, Bytes.toBytes(jsonString));
            

            This code is different from when run the whole test.

            yuzhihong@gmail.com Ted Yu added a comment - Under debugger when running testInvalidNamespacePostsAndPuts alone, code 500 was in response: response = client.put(namespacePath2, Constants.MIMETYPE_XML, Bytes.toBytes(jsonString)); This code is different from when run the whole test.
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4049 (See https://builds.apache.org/job/HBase-Trunk_matrix/4049/)
            HBASE-19210 Revert "Revert "TestNamespacesInstanceResource fails"" (mdrob: rev 14f87a1204ac8dd218806800f31e22a1b16e0538)

            • (edit) pom.xml
              HBASE-19210 TestNamespacesInstanceResource fails - revert due to missing (tedyu: rev 42506a6bcb98cf7190ebf521ebafb6b31dc1076a)
            • (edit) pom.xml
              HBASE-19210 TestNamespacesInstanceResource fails (Ted Yu) (tedyu: rev df82abb159e220e94d6c245e17e0c0c0fcc3a687)
            • (edit) pom.xml
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4049 (See https://builds.apache.org/job/HBase-Trunk_matrix/4049/ ) HBASE-19210 Revert "Revert "TestNamespacesInstanceResource fails"" (mdrob: rev 14f87a1204ac8dd218806800f31e22a1b16e0538) (edit) pom.xml HBASE-19210 TestNamespacesInstanceResource fails - revert due to missing (tedyu: rev 42506a6bcb98cf7190ebf521ebafb6b31dc1076a) (edit) pom.xml HBASE-19210 TestNamespacesInstanceResource fails (Ted Yu) (tedyu: rev df82abb159e220e94d6c245e17e0c0c0fcc3a687) (edit) pom.xml
            busbey Sean Busbey added a comment -

            If a set of calls can cause our REST service to fall over and fail to give future responses, I'd say that's a problem with our REST service and not with the test.

            busbey Sean Busbey added a comment - If a set of calls can cause our REST service to fall over and fail to give future responses, I'd say that's a problem with our REST service and not with the test.
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-2.0 #849 (See https://builds.apache.org/job/HBase-2.0/849/)
            HBASE-19210 TestNamespacesInstanceResource fails (Ted Yu) (tedyu: rev 04a87fe1569641ff4a971b7b97ec239e7d065a86)

            • (edit) pom.xml
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #849 (See https://builds.apache.org/job/HBase-2.0/849/ ) HBASE-19210 TestNamespacesInstanceResource fails (Ted Yu) (tedyu: rev 04a87fe1569641ff4a971b7b97ec239e7d065a86) (edit) pom.xml
            yuzhihong@gmail.com Ted Yu added a comment -

            Modified the test slightly by inserting a legal call:

            diff --git a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInsta
            index 9c724cd..3af50df 100644
            --- a/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
            +++ b/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
            @@ -270,13 +270,17 @@ public class TestNamespacesInstanceResource {
                 String jsonString = jsonMapper.writeValueAsString(model2);
                 response = client.put(namespacePath2, Constants.MIMETYPE_XML, Bytes.toBytes(jsonString));
                 assertEquals(400, response.getCode());
            +    // Create namespace via XML and JSON.
            +    response = client.post(namespacePath1, Constants.MIMETYPE_XML, toXML(model1));
            +    assertEquals(201, response.getCode());
            +
                 response = client.post(namespacePath3, Constants.MIMETYPE_PROTOBUF, toXML(model3));
                 assertEquals(500, response.getCode());
            
                 NamespaceDescriptor nd1 = findNamespace(admin, NAMESPACE1);
                 NamespaceDescriptor nd2 = findNamespace(admin, NAMESPACE2);
                 NamespaceDescriptor nd3 = findNamespace(admin, NAMESPACE3);
            -    assertNull(nd1);
            +    assertNotNull(nd1);
                 assertNull(nd2);
                 assertNull(nd3);
               }
            

            TestNamespacesInstanceResource#testInvalidNamespacePostsAndPuts, run standalone, passed.
            Meaning REST server responds to legal request.

            yuzhihong@gmail.com Ted Yu added a comment - Modified the test slightly by inserting a legal call: diff --git a/hbase- rest /src/test/java/org/apache/hadoop/hbase/ rest /TestNamespacesInstanceResource.java b/hbase- rest /src/test/java/org/apache/hadoop/hbase/ rest /TestNamespacesInsta index 9c724cd..3af50df 100644 --- a/hbase- rest /src/test/java/org/apache/hadoop/hbase/ rest /TestNamespacesInstanceResource.java +++ b/hbase- rest /src/test/java/org/apache/hadoop/hbase/ rest /TestNamespacesInstanceResource.java @@ -270,13 +270,17 @@ public class TestNamespacesInstanceResource { String jsonString = jsonMapper.writeValueAsString(model2); response = client.put(namespacePath2, Constants.MIMETYPE_XML, Bytes.toBytes(jsonString)); assertEquals(400, response.getCode()); + // Create namespace via XML and JSON. + response = client.post(namespacePath1, Constants.MIMETYPE_XML, toXML(model1)); + assertEquals(201, response.getCode()); + response = client.post(namespacePath3, Constants.MIMETYPE_PROTOBUF, toXML(model3)); assertEquals(500, response.getCode()); NamespaceDescriptor nd1 = findNamespace(admin, NAMESPACE1); NamespaceDescriptor nd2 = findNamespace(admin, NAMESPACE2); NamespaceDescriptor nd3 = findNamespace(admin, NAMESPACE3); - assertNull(nd1); + assertNotNull(nd1); assertNull(nd2); assertNull(nd3); } TestNamespacesInstanceResource#testInvalidNamespacePostsAndPuts, run standalone, passed. Meaning REST server responds to legal request.
            mdrob Mike Drob added a comment -

            tedyu - please look at the WIP patch that I had put up. It will show you the exact sequence of REST calls that will make the server fall over.

            mdrob Mike Drob added a comment - tedyu - please look at the WIP patch that I had put up. It will show you the exact sequence of REST calls that will make the server fall over.
            yuzhihong@gmail.com Ted Yu added a comment -

            testInvalidNamespacePosts and testInvalidNamespacePuts are ignored.

            Which subtest shows the server failure ?

            yuzhihong@gmail.com Ted Yu added a comment - testInvalidNamespacePosts and testInvalidNamespacePuts are ignored. Which subtest shows the server failure ?
            mdrob Mike Drob added a comment -

            testInvalidNamespacePuts will fail when run by itself.

            mdrob Mike Drob added a comment - testInvalidNamespacePuts will fail when run by itself.
            yuzhihong@gmail.com Ted Yu added a comment -

            I run this code by itself which passed (note the legitimate call at the end):

              @Test
              public void testInvalidNamespacePuts() throws IOException, JAXBException {
                Admin admin = TEST_UTIL.getAdmin();
            
                Response response;
            
                // Check that namespaces don't exist via non-REST call.
                assertNull(findNamespace(admin, NAMESPACE1));
                assertNull(findNamespace(admin, NAMESPACE2));
            
                // Test cannot PUT (alter) non-existent namespace.
                byte[] json = Bytes.toBytes(jsonMapper.writeValueAsString(model2));
                response = client.put(namespacePath2, Constants.MIMETYPE_JSON, json);
                assertEquals(403, response.getCode());
            
                // Try REST post and puts with invalid content.
                response = client.post(namespacePath1, Constants.MIMETYPE_JSON, toXML(model1));
                assertEquals(500, response.getCode());
                response = client.put(namespacePath2, Constants.MIMETYPE_XML, json);
                assertEquals(400, response.getCode());
                // Create namespace via XML and JSON.
                response = client.post(namespacePath1, Constants.MIMETYPE_XML, toXML(model1));
                assertEquals(201, response.getCode());
              }
            
            yuzhihong@gmail.com Ted Yu added a comment - I run this code by itself which passed (note the legitimate call at the end): @Test public void testInvalidNamespacePuts() throws IOException, JAXBException { Admin admin = TEST_UTIL.getAdmin(); Response response; // Check that namespaces don't exist via non-REST call. assertNull(findNamespace(admin, NAMESPACE1)); assertNull(findNamespace(admin, NAMESPACE2)); // Test cannot PUT (alter) non-existent namespace. byte [] json = Bytes.toBytes(jsonMapper.writeValueAsString(model2)); response = client.put(namespacePath2, Constants.MIMETYPE_JSON, json); assertEquals(403, response.getCode()); // Try REST post and puts with invalid content. response = client.post(namespacePath1, Constants.MIMETYPE_JSON, toXML(model1)); assertEquals(500, response.getCode()); response = client.put(namespacePath2, Constants.MIMETYPE_XML, json); assertEquals(400, response.getCode()); // Create namespace via XML and JSON. response = client.post(namespacePath1, Constants.MIMETYPE_XML, toXML(model1)); assertEquals(201, response.getCode()); }
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 12s Docker mode activated.
            0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  master Compile Tests
            +1 mvninstall 6m 13s master passed
            +1 compile 0m 35s master passed
            +1 checkstyle 0m 22s master passed
            +1 shadedjars 6m 22s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 0m 33s master passed
                  Patch Compile Tests
            +1 mvninstall 6m 31s the patch passed
            +1 compile 0m 34s the patch passed
            +1 javac 0m 34s the patch passed
            +1 checkstyle 0m 22s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedjars 6m 16s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 84m 42s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
            +1 javadoc 0m 26s the patch passed
                  Other Tests
            +1 unit 5m 19s hbase-rest in the patch passed.
            +1 asflicense 0m 12s The patch does not generate ASF License warnings.
            112m 15s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19210
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897439/19210.addendum
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
            uname Linux d5389638a4d9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
            git revision master / 9ed6cf5cb8
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9787/testReport/
            modules C: hbase-rest U: hbase-rest
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9787/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       master Compile Tests +1 mvninstall 6m 13s master passed +1 compile 0m 35s master passed +1 checkstyle 0m 22s master passed +1 shadedjars 6m 22s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 33s master passed       Patch Compile Tests +1 mvninstall 6m 31s the patch passed +1 compile 0m 34s the patch passed +1 javac 0m 34s the patch passed +1 checkstyle 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 6m 16s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 84m 42s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 0m 26s the patch passed       Other Tests +1 unit 5m 19s hbase-rest in the patch passed. +1 asflicense 0m 12s The patch does not generate ASF License warnings. 112m 15s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19210 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897439/19210.addendum Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux d5389638a4d9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 9ed6cf5cb8 maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9787/testReport/ modules C: hbase-rest U: hbase-rest Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9787/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            yuzhihong@gmail.com Ted Yu added a comment -

            TestNamespacesInstanceResource passes with addendum.

            mdrob:
            What do you think ?

            yuzhihong@gmail.com Ted Yu added a comment - TestNamespacesInstanceResource passes with addendum. mdrob : What do you think ?
            mdrob Mike Drob added a comment -

            If we expect a socket exception we should check that it was actually thrown. I don't like that the behaviour is inconsistent depending on previous calls - it is very un-REST like to me.

            Can you try figuring out if it is a client or server caused error? Does getting a new client make the error go away? Is it a problem with too many server errors where we end up somehow losing threads?

            mdrob Mike Drob added a comment - If we expect a socket exception we should check that it was actually thrown. I don't like that the behaviour is inconsistent depending on previous calls - it is very un-REST like to me. Can you try figuring out if it is a client or server caused error? Does getting a new client make the error go away? Is it a problem with too many server errors where we end up somehow losing threads?
            yuzhihong@gmail.com Ted Yu added a comment -

            Can you try figuring out if it is a client or server caused error?

            I think after upgrading jackson (HBASE-16338), interaction between client and REST changed, resulting in NoHttpResponseException / SocketException on the client side. The exception is for invalid request so tweaking test should be enough.

            Does getting a new client make the error go away?

            As shown in addendum 2, client can still talk to REST server after getting the exception.

            Is it a problem with too many server errors

            I don't think so - there are only two invalid requests before getting the exception.

            yuzhihong@gmail.com Ted Yu added a comment - Can you try figuring out if it is a client or server caused error? I think after upgrading jackson ( HBASE-16338 ), interaction between client and REST changed, resulting in NoHttpResponseException / SocketException on the client side. The exception is for invalid request so tweaking test should be enough. Does getting a new client make the error go away? As shown in addendum 2, client can still talk to REST server after getting the exception. Is it a problem with too many server errors I don't think so - there are only two invalid requests before getting the exception.
            yuzhihong@gmail.com Ted Yu added a comment -

            Addendum 3 shows that proper client request is honored following invalid request.

            yuzhihong@gmail.com Ted Yu added a comment - Addendum 3 shows that proper client request is honored following invalid request.
            mdrob Mike Drob added a comment -

            Please be sure to clean up after the test - if we're creating a namespace, make sure we delete it afterwards.

            mdrob Mike Drob added a comment - Please be sure to clean up after the test - if we're creating a namespace, make sure we delete it afterwards.
            yuzhihong@gmail.com Ted Yu added a comment -

            Addendum 4 cleans the namespace after checking.

            yuzhihong@gmail.com Ted Yu added a comment - Addendum 4 cleans the namespace after checking.
            mdrob Mike Drob added a comment -

            Will the test pass when run by itself?

            mdrob Mike Drob added a comment - Will the test pass when run by itself?
            yuzhihong@gmail.com Ted Yu added a comment -

            testInvalidNamespacePostsAndPuts doesn't get exception when run alone.

            Do you want to separate testInvalidNamespacePostsAndPuts out (without catching exceptions) ?

            yuzhihong@gmail.com Ted Yu added a comment - testInvalidNamespacePostsAndPuts doesn't get exception when run alone. Do you want to separate testInvalidNamespacePostsAndPuts out (without catching exceptions) ?
            mdrob Mike Drob added a comment -

            That's what I've been trying to understand - changing the test to paper over a bug isn't the appropriate solution. Are users going to hit this and expect us to fix it?

            mdrob Mike Drob added a comment - That's what I've been trying to understand - changing the test to paper over a bug isn't the appropriate solution. Are users going to hit this and expect us to fix it?
            yuzhihong@gmail.com Ted Yu added a comment -

            I wish these questions were considered at time of HBASE-16338

            yuzhihong@gmail.com Ted Yu added a comment - I wish these questions were considered at time of HBASE-16338
            mdrob Mike Drob added a comment -

            I think I understand now that there are two competing goals. The test failure is adding noise to the flaky reports, and should be addressed ASAP. Let's throw an @Ignore annotation on there for now and then I will look into figuring out the root cause over the next few days. Does this sound fine by you?

            mdrob Mike Drob added a comment - I think I understand now that there are two competing goals. The test failure is adding noise to the flaky reports, and should be addressed ASAP. Let's throw an @Ignore annotation on there for now and then I will look into figuring out the root cause over the next few days. Does this sound fine by you?
            yuzhihong@gmail.com Ted Yu added a comment -

            Addendum 5 ignores the failing test.

            yuzhihong@gmail.com Ted Yu added a comment - Addendum 5 ignores the failing test.
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 4m 53s Docker mode activated.
            0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  master Compile Tests
            +1 mvninstall 5m 45s master passed
            +1 compile 0m 27s master passed
            +1 checkstyle 0m 20s master passed
            +1 shadedjars 5m 19s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 0m 18s master passed
                  Patch Compile Tests
            +1 mvninstall 5m 0s the patch passed
            +1 compile 0m 24s the patch passed
            +1 javac 0m 24s the patch passed
            +1 checkstyle 0m 15s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedjars 4m 51s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 60m 21s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
            +1 javadoc 0m 19s the patch passed
                  Other Tests
            +1 unit 4m 41s hbase-rest in the patch passed.
            +1 asflicense 0m 10s The patch does not generate ASF License warnings.
            88m 8s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19210
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897591/19210-addendum-3.txt
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
            uname Linux 878f65e1a2dd 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / e0580b20d1
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9798/testReport/
            modules C: hbase-rest U: hbase-rest
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9798/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 4m 53s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       master Compile Tests +1 mvninstall 5m 45s master passed +1 compile 0m 27s master passed +1 checkstyle 0m 20s master passed +1 shadedjars 5m 19s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 18s master passed       Patch Compile Tests +1 mvninstall 5m 0s the patch passed +1 compile 0m 24s the patch passed +1 javac 0m 24s the patch passed +1 checkstyle 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 51s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 60m 21s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 0m 19s the patch passed       Other Tests +1 unit 4m 41s hbase-rest in the patch passed. +1 asflicense 0m 10s The patch does not generate ASF License warnings. 88m 8s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19210 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897591/19210-addendum-3.txt Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 878f65e1a2dd 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / e0580b20d1 maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9798/testReport/ modules C: hbase-rest U: hbase-rest Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9798/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            mdrob Mike Drob added a comment -

            +1

            mdrob Mike Drob added a comment - +1
            yuzhihong@gmail.com Ted Yu added a comment -

            Thanks for the review, Mike.

            If you find other ways to fix the test, please re-open.

            yuzhihong@gmail.com Ted Yu added a comment - Thanks for the review, Mike. If you find other ways to fix the test, please re-open.
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 12s Docker mode activated.
            0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  master Compile Tests
            +1 mvninstall 5m 38s master passed
            +1 compile 0m 28s master passed
            +1 checkstyle 0m 17s master passed
            +1 shadedjars 5m 41s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 0m 22s master passed
                  Patch Compile Tests
            +1 mvninstall 5m 47s the patch passed
            +1 compile 0m 30s the patch passed
            +1 javac 0m 30s the patch passed
            +1 checkstyle 0m 17s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedjars 4m 49s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 61m 13s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
            +1 javadoc 0m 23s the patch passed
                  Other Tests
            +1 unit 4m 17s hbase-rest in the patch passed.
            +1 asflicense 0m 10s The patch does not generate ASF License warnings.
            85m 10s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19210
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897601/19210-addendum-4.txt
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
            uname Linux fd080e55fd4c 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
            git revision master / e0580b20d1
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9800/testReport/
            modules C: hbase-rest U: hbase-rest
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9800/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       master Compile Tests +1 mvninstall 5m 38s master passed +1 compile 0m 28s master passed +1 checkstyle 0m 17s master passed +1 shadedjars 5m 41s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 22s master passed       Patch Compile Tests +1 mvninstall 5m 47s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 49s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 61m 13s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 0m 23s the patch passed       Other Tests +1 unit 4m 17s hbase-rest in the patch passed. +1 asflicense 0m 10s The patch does not generate ASF License warnings. 85m 10s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19210 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897601/19210-addendum-4.txt Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux fd080e55fd4c 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / e0580b20d1 maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9800/testReport/ modules C: hbase-rest U: hbase-rest Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9800/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 9s Docker mode activated.
            0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  master Compile Tests
            +1 mvninstall 4m 28s master passed
            +1 compile 0m 22s master passed
            +1 checkstyle 0m 14s master passed
            +1 shadedjars 4m 54s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 0m 18s master passed
                  Patch Compile Tests
            +1 mvninstall 4m 28s the patch passed
            +1 compile 0m 21s the patch passed
            +1 javac 0m 21s the patch passed
            +1 checkstyle 0m 14s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedjars 4m 39s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 52m 4s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4.
            +1 javadoc 0m 17s the patch passed
                  Other Tests
            +1 unit 3m 18s hbase-rest in the patch passed.
            +1 asflicense 0m 7s The patch does not generate ASF License warnings.
            71m 11s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19210
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897605/19210-addendum-5.txt
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
            uname Linux fcdb73b76d0e 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / e0580b20d1
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9801/testReport/
            modules C: hbase-rest U: hbase-rest
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9801/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for instructions.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       master Compile Tests +1 mvninstall 4m 28s master passed +1 compile 0m 22s master passed +1 checkstyle 0m 14s master passed +1 shadedjars 4m 54s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 18s master passed       Patch Compile Tests +1 mvninstall 4m 28s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed +1 checkstyle 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 39s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 52m 4s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. +1 javadoc 0m 17s the patch passed       Other Tests +1 unit 3m 18s hbase-rest in the patch passed. +1 asflicense 0m 7s The patch does not generate ASF License warnings. 71m 11s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19210 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897605/19210-addendum-5.txt Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux fcdb73b76d0e 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / e0580b20d1 maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9801/testReport/ modules C: hbase-rest U: hbase-rest Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9801/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4053 (See https://builds.apache.org/job/HBase-Trunk_matrix/4053/)
            HBASE-19210 TestNamespacesInstanceResource fails (tedyu: rev f9b19c6e339829db1df9d9953bdb4c134280f117)

            • (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4053 (See https://builds.apache.org/job/HBase-Trunk_matrix/4053/ ) HBASE-19210 TestNamespacesInstanceResource fails (tedyu: rev f9b19c6e339829db1df9d9953bdb4c134280f117) (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-2.0 #852 (See https://builds.apache.org/job/HBase-2.0/852/)
            HBASE-19210 TestNamespacesInstanceResource fails (tedyu: rev 76b9d4617c657b8e5a5244f06ff6c4165c69896e)

            • (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #852 (See https://builds.apache.org/job/HBase-2.0/852/ ) HBASE-19210 TestNamespacesInstanceResource fails (tedyu: rev 76b9d4617c657b8e5a5244f06ff6c4165c69896e) (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
            yuzhihong@gmail.com Ted Yu added a comment -

            mdrob:
            With testInvalidNamespacePostsAndPuts disabled, we lose some coverage.

            What do you think of separating testInvalidNamespacePostsAndPuts out into its own test - which is not flaky ?

            Thanks

            yuzhihong@gmail.com Ted Yu added a comment - mdrob : With testInvalidNamespacePostsAndPuts disabled, we lose some coverage. What do you think of separating testInvalidNamespacePostsAndPuts out into its own test - which is not flaky ? Thanks

            People

              yuzhihong@gmail.com Ted Yu
              yuzhihong@gmail.com Ted Yu
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: