Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19239 Fix findbugs and error-prone warnings (branch-1)
  3. HBASE-19276

RegionPlan should correctly implement equals and hashCode

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0, 2.0.0-beta-1, 2.0.0
    • None
    • None
    • Reviewed

    Description

      error-prone identified dodgy code in AssignmentManager where we are relying on reference (object) equality to do the right thing, and are getting lucky, because if we properly used equals() the result is wrong, because RegionPlan does not correctly implement equals and hashCode according to the JDK contracts for same.

      Attachments

        1. HBASE-19276.branch-1.001.patch
          9 kB
          Michael Stack
        2. HBASE-19276.master.002.patch
          9 kB
          Michael Stack
        3. HBASE-19276.master.001.patch
          9 kB
          Michael Stack
        4. HBASE-19276.patch
          3 kB
          Andrew Kyle Purtell
        5. HBASE-19276-branch-1.patch
          4 kB
          Andrew Kyle Purtell

        Issue Links

          Activity

            People

              stack Michael Stack
              apurtell Andrew Kyle Purtell
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: