Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1
    • None
    • None

    Description

      Fix the remaining Checkstyle errors in the hbase-protocol module and enable Checkstyle to fail on violations.

      Attachments

        1. HBASE-19610.master.001.patch
          3 kB
          Jan Hentschel

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 22s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  master Compile Tests
            +1 mvninstall 4m 30s master passed
            +1 compile 0m 18s master passed
            +1 checkstyle 0m 10s master passed
            +1 shadedjars 4m 19s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 0m 10s master passed
                  Patch Compile Tests
            +1 mvninstall 4m 14s the patch passed
            +1 compile 0m 19s the patch passed
            +1 javac 0m 19s the patch passed
            +1 checkstyle 0m 7s hbase-protocol: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 1s The patch has no ill-formed XML file.
            +1 shadedjars 4m 7s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 17m 28s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 0m 9s the patch passed
                  Other Tests
            +1 unit 0m 18s hbase-protocol in the patch passed.
            +1 asflicense 0m 7s The patch does not generate ASF License warnings.
            32m 35s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19610
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12903562/HBASE-19610.master.001.patch
            Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile findbugs hbaseanti checkstyle
            uname Linux 37aca209f1de 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / c24cf2d55e
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/10679/testReport/
            modules C: hbase-protocol U: hbase-protocol
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/10679/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests +1 mvninstall 4m 30s master passed +1 compile 0m 18s master passed +1 checkstyle 0m 10s master passed +1 shadedjars 4m 19s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 10s master passed       Patch Compile Tests +1 mvninstall 4m 14s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 7s hbase-protocol: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 shadedjars 4m 7s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 17m 28s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 0m 9s the patch passed       Other Tests +1 unit 0m 18s hbase-protocol in the patch passed. +1 asflicense 0m 7s The patch does not generate ASF License warnings. 32m 35s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19610 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12903562/HBASE-19610.master.001.patch Optional Tests asflicense javac javadoc unit shadedjars hadoopcheck xml compile findbugs hbaseanti checkstyle uname Linux 37aca209f1de 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / c24cf2d55e maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/10679/testReport/ modules C: hbase-protocol U: hbase-protocol Console output https://builds.apache.org/job/PreCommit-HBASE-Build/10679/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            chia7712 Chia-Ping Tsai added a comment -

            +1

            chia7712 Chia-Ping Tsai added a comment - +1
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4296 (See https://builds.apache.org/job/HBase-Trunk_matrix/4296/)
            HBASE-19610 Fixed Checkstyle errors in hbase-protocol and enabled (jan.hentschel: rev 3ed68fd70d7ee187553627998ee39581309296e2)

            • (edit) hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java
            • (edit) hbase-protocol/pom.xml
            • (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4296 (See https://builds.apache.org/job/HBase-Trunk_matrix/4296/ ) HBASE-19610 Fixed Checkstyle errors in hbase-protocol and enabled (jan.hentschel: rev 3ed68fd70d7ee187553627998ee39581309296e2) (edit) hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java (edit) hbase-protocol/pom.xml (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java

            People

              janh Jan Hentschel
              janh Jan Hentschel
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: