Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-beta-2, 2.0.0
    • None
    • None
    • Incompatible change, Reviewed
    • Hide
      Along with @category -- small, medium, large -- all hbase tests must now carry a ClassRule as follows:

      + @ClassRule
      + public static final HBaseClassTestRule CLASS_RULE =
      + HBaseClassTestRule.forClass(TestInterfaceAudienceAnnotations.class);

      where the class changes by test.

      Currently the classrule enforces timeout for the whole test suite -- i.e. if a SmallTest Category then all the tests in the TestSuite must complete inside 60seconds, the timeout we set on SmallTest Category test suite -- but is meant to be a repository for general, runtime, hbase test facility.
      Show
      Along with @category -- small, medium, large -- all hbase tests must now carry a ClassRule as follows: + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestInterfaceAudienceAnnotations.class); where the class changes by test. Currently the classrule enforces timeout for the whole test suite -- i.e. if a SmallTest Category then all the tests in the TestSuite must complete inside 60seconds, the timeout we set on SmallTest Category test suite -- but is meant to be a repository for general, runtime, hbase test facility.

    Description

      So that our test can timeout as expected without making the surefire plugin kill other tests.

      Attachments

        1. HBASE-19873-branch-2-v2.patch
          2.23 MB
          Duo Zhang

        Issue Links

          Activity

            zhangduo Duo Zhang added a comment -

            A very huge patch. Let's try it.

            For now the CategoryBasedTimeoutClassRuleChecker does not work. Do not know why yet but I think the patch is aleady big enough. We can fix the RunListener in another issue.

            zhangduo Duo Zhang added a comment - A very huge patch. Let's try it. For now the CategoryBasedTimeoutClassRuleChecker does not work. Do not know why yet but I think the patch is aleady big enough. We can fix the RunListener in another issue.
            zhangduo Duo Zhang added a comment -

            stack appy FYI.

            zhangduo Duo Zhang added a comment - stack appy FYI.
            zhangduo Duo Zhang added a comment -
            zhangduo Duo Zhang added a comment - Review board link: https://reviews.apache.org/r/65371/
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 2m 4s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1137 new or modified test files.
                  master Compile Tests
            0 mvndep 0m 13s Maven dependency ordering for branch
            +1 mvninstall 4m 35s master passed
            +1 compile 4m 25s master passed
            +1 checkstyle 11m 39s master passed
            +1 shadedjars 16m 41s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 10m 20s master passed
                  Patch Compile Tests
            0 mvndep 0m 15s Maven dependency ordering for patch
            +1 mvninstall 5m 43s the patch passed
            +1 compile 5m 18s the patch passed
            +1 javac 5m 18s the patch passed
            -1 checkstyle 0m 37s hbase-common: The patch generated 14 new + 131 unchanged - 1 fixed = 145 total (was 132)
            +1 checkstyle 0m 17s The patch hbase-metrics-api passed checkstyle
            -1 checkstyle 0m 16s hbase-hadoop-compat: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
            +1 checkstyle 0m 16s The patch hbase-metrics passed checkstyle
            +1 checkstyle 0m 18s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37)
            -1 checkstyle 0m 47s hbase-client: The patch generated 21 new + 144 unchanged - 34 fixed = 165 total (was 178)
            -1 checkstyle 0m 24s hbase-zookeeper: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
            +1 checkstyle 0m 19s The patch hbase-replication passed checkstyle
            +1 checkstyle 0m 22s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51)
            -1 checkstyle 0m 24s hbase-procedure: The patch generated 4 new + 45 unchanged - 45 fixed = 49 total (was 90)
            -1 checkstyle 2m 19s hbase-server: The patch generated 198 new + 3113 unchanged - 414 fixed = 3311 total (was 3527)
            -1 checkstyle 0m 35s hbase-mapreduce: The patch generated 5 new + 388 unchanged - 51 fixed = 393 total (was 439)
            -1 checkstyle 0m 43s hbase-thrift: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
            -1 checkstyle 0m 23s hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
            +1 checkstyle 0m 18s The patch hbase-shell passed checkstyle
            -1 checkstyle 0m 25s hbase-endpoint: The patch generated 8 new + 63 unchanged - 20 fixed = 71 total (was 83)
            -1 checkstyle 0m 26s hbase-backup: The patch generated 3 new + 62 unchanged - 1 fixed = 65 total (was 63)
            -1 checkstyle 0m 34s hbase-it: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
            -1 checkstyle 0m 25s hbase-examples: The patch generated 1 new + 7 unchanged - 5 fixed = 8 total (was 12)
            -1 checkstyle 0m 31s hbase-rest: The patch generated 1 new + 185 unchanged - 10 fixed = 186 total (was 195)
            +1 checkstyle 0m 20s The patch hbase-spark passed checkstyle
            +1 checkstyle 0m 20s The patch hbase-client-project passed checkstyle
            +1 checkstyle 0m 19s The patch hbase-shaded-client-project passed checkstyle
            -1 checkstyle 4m 19s root: The patch generated 263 new + 4198 unchanged - 610 fixed = 4461 total (was 4808)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 11s The patch has no ill-formed XML file.
            +1 shadedjars 6m 12s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 25m 30s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 7m 29s the patch passed
                  Other Tests
            -1 unit 8m 52s root in the patch failed.
            +1 asflicense 2m 49s The patch does not generate ASF License warnings.
            116m 5s



            Reason Tests
            Failed junit tests hadoop.hbase.procedure2.store.TestProcedureStoreTracker



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19873
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908022/HBASE-19873.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux deb18af40408 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / f1502a3aca
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-common.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-hadoop-compat.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-client.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-zookeeper.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-procedure.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-thrift.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-endpoint.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-backup.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-it.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-examples.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-rest.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/patch-unit-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11213/testReport/
            modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11213/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 2m 4s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1137 new or modified test files.       master Compile Tests 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 4m 35s master passed +1 compile 4m 25s master passed +1 checkstyle 11m 39s master passed +1 shadedjars 16m 41s branch has no errors when building our shaded downstream artifacts. +1 javadoc 10m 20s master passed       Patch Compile Tests 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 5m 43s the patch passed +1 compile 5m 18s the patch passed +1 javac 5m 18s the patch passed -1 checkstyle 0m 37s hbase-common: The patch generated 14 new + 131 unchanged - 1 fixed = 145 total (was 132) +1 checkstyle 0m 17s The patch hbase-metrics-api passed checkstyle -1 checkstyle 0m 16s hbase-hadoop-compat: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 checkstyle 0m 16s The patch hbase-metrics passed checkstyle +1 checkstyle 0m 18s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37) -1 checkstyle 0m 47s hbase-client: The patch generated 21 new + 144 unchanged - 34 fixed = 165 total (was 178) -1 checkstyle 0m 24s hbase-zookeeper: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) +1 checkstyle 0m 19s The patch hbase-replication passed checkstyle +1 checkstyle 0m 22s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51) -1 checkstyle 0m 24s hbase-procedure: The patch generated 4 new + 45 unchanged - 45 fixed = 49 total (was 90) -1 checkstyle 2m 19s hbase-server: The patch generated 198 new + 3113 unchanged - 414 fixed = 3311 total (was 3527) -1 checkstyle 0m 35s hbase-mapreduce: The patch generated 5 new + 388 unchanged - 51 fixed = 393 total (was 439) -1 checkstyle 0m 43s hbase-thrift: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) -1 checkstyle 0m 23s hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 checkstyle 0m 18s The patch hbase-shell passed checkstyle -1 checkstyle 0m 25s hbase-endpoint: The patch generated 8 new + 63 unchanged - 20 fixed = 71 total (was 83) -1 checkstyle 0m 26s hbase-backup: The patch generated 3 new + 62 unchanged - 1 fixed = 65 total (was 63) -1 checkstyle 0m 34s hbase-it: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 checkstyle 0m 25s hbase-examples: The patch generated 1 new + 7 unchanged - 5 fixed = 8 total (was 12) -1 checkstyle 0m 31s hbase-rest: The patch generated 1 new + 185 unchanged - 10 fixed = 186 total (was 195) +1 checkstyle 0m 20s The patch hbase-spark passed checkstyle +1 checkstyle 0m 20s The patch hbase-client-project passed checkstyle +1 checkstyle 0m 19s The patch hbase-shaded-client-project passed checkstyle -1 checkstyle 4m 19s root: The patch generated 263 new + 4198 unchanged - 610 fixed = 4461 total (was 4808) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 11s The patch has no ill-formed XML file. +1 shadedjars 6m 12s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 25m 30s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 7m 29s the patch passed       Other Tests -1 unit 8m 52s root in the patch failed. +1 asflicense 2m 49s The patch does not generate ASF License warnings. 116m 5s Reason Tests Failed junit tests hadoop.hbase.procedure2.store.TestProcedureStoreTracker Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19873 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908022/HBASE-19873.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux deb18af40408 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / f1502a3aca maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-common.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-hadoop-compat.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-client.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-zookeeper.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-procedure.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-thrift.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-endpoint.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-backup.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-it.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-examples.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-hbase-rest.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/11213/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11213/testReport/ modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11213/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            chia7712 Chia-Ping Tsai added a comment -

            +1 to this great and beautiful patch. 

             

            chia7712 Chia-Ping Tsai added a comment - +1 to this great and beautiful patch.   
            stack Michael Stack added a comment -

            Minor comment. Should CategoryBasedTimeout be called HBaseClassRule instead and in each test we'd have

            @ClassRule public static final HBaseClassRule CLASSRULE

            ... rather than....

            @ClassRule public static final CategoryBasedTimeout TIMEOUT ?

            The fact that we have a class in every unit test is an opportunity for doing more than just timeout checking (looking for stuck threads though in the base junit Timeout class, is sort of off the timeout topic already).

            (On other hand, CategoryBasedTimeout "connects" with the Category annotation we have on each test... )

            Otherwise, +1. Can fix the broke rule checking in follow-on. I skimmed the massive patch. If issue, can address in follow-on.

            Please wait before committing to branch-2. I need to check w/ folks trying to integrate branch-2... Or, perhaps, we just need to backport to branch-2 the change in CategoryBasedTimeout.... And not the edit to every test? Thanks.

            stack Michael Stack added a comment - Minor comment. Should CategoryBasedTimeout be called HBaseClassRule instead and in each test we'd have @ClassRule public static final HBaseClassRule CLASSRULE ... rather than.... @ClassRule public static final CategoryBasedTimeout TIMEOUT ? The fact that we have a class in every unit test is an opportunity for doing more than just timeout checking (looking for stuck threads though in the base junit Timeout class, is sort of off the timeout topic already). (On other hand, CategoryBasedTimeout "connects" with the Category annotation we have on each test... ) Otherwise, +1. Can fix the broke rule checking in follow-on. I skimmed the massive patch. If issue, can address in follow-on. Please wait before committing to branch-2. I need to check w/ folks trying to integrate branch-2... Or, perhaps, we just need to backport to branch-2 the change in CategoryBasedTimeout.... And not the edit to every test? Thanks.
            zhangduo Duo Zhang added a comment -

            stack That would be good. There is a RuleChain which we can make use of to add more rules. Then we do not need add other fields to every UTs any more.

            Let me do it in this patch. Do not need to create another 2M patch...

            And for branch-2, I think it is OK? There is no big changes on the real stuffs, only the header, imports, and a new at the beginning of a test. So I do not think it will introduce irresolvable conflicts with others work?

            Thanks.

            zhangduo Duo Zhang added a comment - stack That would be good. There is a RuleChain which we can make use of to add more rules. Then we do not need add other fields to every UTs any more. Let me do it in this patch. Do not need to create another 2M patch... And for branch-2, I think it is OK? There is no big changes on the real stuffs, only the header, imports, and a new at the beginning of a test. So I do not think it will introduce irresolvable conflicts with others work? Thanks.
            zhangduo Duo Zhang added a comment -

            Change the name to HBaseClassTestRule. Remove redundant imports. Promote TestProcedureStoreTracker to MediumTests as testLoad will run for about one minute.

            zhangduo Duo Zhang added a comment - Change the name to HBaseClassTestRule. Remove redundant imports. Promote TestProcedureStoreTracker to MediumTests as testLoad will run for about one minute.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 12s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 1s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1138 new or modified test files.
                  master Compile Tests
            0 mvndep 0m 22s Maven dependency ordering for branch
            +1 mvninstall 4m 14s master passed
            +1 compile 4m 0s master passed
            +1 checkstyle 11m 53s master passed
            +1 shadedjars 16m 30s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 7m 26s master passed
                  Patch Compile Tests
            0 mvndep 0m 11s Maven dependency ordering for patch
            -1 mvninstall 3m 57s root in the patch failed.
            -1 compile 3m 27s root in the patch failed.
            -1 javac 3m 27s root in the patch failed.
            -1 checkstyle 0m 27s hbase-common: The patch generated 6 new + 131 unchanged - 1 fixed = 137 total (was 132)
            +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle
            -1 checkstyle 0m 12s hbase-hadoop-compat: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
            +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle
            -1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 11 new + 18 unchanged - 19 fixed = 29 total (was 37)
            -1 checkstyle 0m 33s hbase-client: The patch generated 29 new + 144 unchanged - 34 fixed = 173 total (was 178)
            -1 checkstyle 0m 14s hbase-zookeeper: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
            -1 checkstyle 0m 12s hbase-replication: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
            +1 checkstyle 0m 14s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51)
            -1 checkstyle 0m 17s hbase-procedure: The patch generated 4 new + 45 unchanged - 45 fixed = 49 total (was 90)
            -1 checkstyle 2m 4s hbase-server: The patch generated 400 new + 3114 unchanged - 413 fixed = 3514 total (was 3527)
            -1 checkstyle 0m 24s hbase-mapreduce: The patch generated 18 new + 389 unchanged - 50 fixed = 407 total (was 439)
            -1 checkstyle 0m 31s hbase-thrift: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
            -1 checkstyle 0m 13s hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
            +1 checkstyle 0m 12s The patch hbase-shell passed checkstyle
            -1 checkstyle 0m 16s hbase-endpoint: The patch generated 13 new + 63 unchanged - 20 fixed = 76 total (was 83)
            -1 checkstyle 0m 16s hbase-backup: The patch generated 3 new + 62 unchanged - 1 fixed = 65 total (was 63)
            +1 checkstyle 0m 22s The patch hbase-it passed checkstyle
            -1 checkstyle 0m 16s hbase-examples: The patch generated 2 new + 7 unchanged - 5 fixed = 9 total (was 12)
            -1 checkstyle 0m 20s hbase-rest: The patch generated 5 new + 187 unchanged - 8 fixed = 192 total (was 195)
            +1 checkstyle 0m 13s The patch hbase-spark passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-client-project passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-shaded-client-project passed checkstyle
            -1 checkstyle 3m 32s root: The patch generated 509 new + 4202 unchanged - 606 fixed = 4711 total (was 4808)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 6s The patch has no ill-formed XML file.
            +1 shadedjars 4m 47s patch has no errors when building our shaded downstream artifacts.
            -1 hadoopcheck 8m 25s The patch causes 24 errors with Hadoop v2.6.5.
            -1 hadoopcheck 12m 7s The patch causes 24 errors with Hadoop v2.7.4.
            -1 hadoopcheck 16m 9s The patch causes 24 errors with Hadoop v3.0.0.
            +1 javadoc 7m 24s the patch passed
                  Other Tests
            -1 unit 3m 16s root in the patch failed.
            +1 asflicense 2m 53s The patch does not generate ASF License warnings.
            87m 12s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19873
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908036/HBASE-19873-v1.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux 244e07c5f797 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / f1502a3aca
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-mvninstall-root.txt
            compile https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-compile-root.txt
            javac https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-compile-root.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-common.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-hadoop-compat.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-hadoop2-compat.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-client.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-zookeeper.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-replication.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-procedure.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-thrift.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-endpoint.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-backup.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-examples.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-rest.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-unit-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11215/testReport/
            modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11215/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 1s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1138 new or modified test files.       master Compile Tests 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 4m 14s master passed +1 compile 4m 0s master passed +1 checkstyle 11m 53s master passed +1 shadedjars 16m 30s branch has no errors when building our shaded downstream artifacts. +1 javadoc 7m 26s master passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch -1 mvninstall 3m 57s root in the patch failed. -1 compile 3m 27s root in the patch failed. -1 javac 3m 27s root in the patch failed. -1 checkstyle 0m 27s hbase-common: The patch generated 6 new + 131 unchanged - 1 fixed = 137 total (was 132) +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle -1 checkstyle 0m 12s hbase-hadoop-compat: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle -1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 11 new + 18 unchanged - 19 fixed = 29 total (was 37) -1 checkstyle 0m 33s hbase-client: The patch generated 29 new + 144 unchanged - 34 fixed = 173 total (was 178) -1 checkstyle 0m 14s hbase-zookeeper: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) -1 checkstyle 0m 12s hbase-replication: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 checkstyle 0m 14s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51) -1 checkstyle 0m 17s hbase-procedure: The patch generated 4 new + 45 unchanged - 45 fixed = 49 total (was 90) -1 checkstyle 2m 4s hbase-server: The patch generated 400 new + 3114 unchanged - 413 fixed = 3514 total (was 3527) -1 checkstyle 0m 24s hbase-mapreduce: The patch generated 18 new + 389 unchanged - 50 fixed = 407 total (was 439) -1 checkstyle 0m 31s hbase-thrift: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) -1 checkstyle 0m 13s hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 checkstyle 0m 12s The patch hbase-shell passed checkstyle -1 checkstyle 0m 16s hbase-endpoint: The patch generated 13 new + 63 unchanged - 20 fixed = 76 total (was 83) -1 checkstyle 0m 16s hbase-backup: The patch generated 3 new + 62 unchanged - 1 fixed = 65 total (was 63) +1 checkstyle 0m 22s The patch hbase-it passed checkstyle -1 checkstyle 0m 16s hbase-examples: The patch generated 2 new + 7 unchanged - 5 fixed = 9 total (was 12) -1 checkstyle 0m 20s hbase-rest: The patch generated 5 new + 187 unchanged - 8 fixed = 192 total (was 195) +1 checkstyle 0m 13s The patch hbase-spark passed checkstyle +1 checkstyle 0m 12s The patch hbase-client-project passed checkstyle +1 checkstyle 0m 12s The patch hbase-shaded-client-project passed checkstyle -1 checkstyle 3m 32s root: The patch generated 509 new + 4202 unchanged - 606 fixed = 4711 total (was 4808) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 6s The patch has no ill-formed XML file. +1 shadedjars 4m 47s patch has no errors when building our shaded downstream artifacts. -1 hadoopcheck 8m 25s The patch causes 24 errors with Hadoop v2.6.5. -1 hadoopcheck 12m 7s The patch causes 24 errors with Hadoop v2.7.4. -1 hadoopcheck 16m 9s The patch causes 24 errors with Hadoop v3.0.0. +1 javadoc 7m 24s the patch passed       Other Tests -1 unit 3m 16s root in the patch failed. +1 asflicense 2m 53s The patch does not generate ASF License warnings. 87m 12s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19873 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908036/HBASE-19873-v1.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux 244e07c5f797 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / f1502a3aca maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-common.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-hadoop-compat.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-hadoop2-compat.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-client.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-zookeeper.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-replication.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-procedure.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-thrift.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-endpoint.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-backup.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-examples.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-hbase-rest.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/11215/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11215/testReport/ modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11215/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            appy Apekshit Sharma added a comment - - edited

            I was thinking about this approach more during skiing, and got another idea. Let me try that quickly too.
            It's basically this- We can use RunListener to add timeout rule to every test class via reflection before it gets started. The only thing to verify is, will junit pick up this dynamic runtime addition of rules to test class.

            If it works, we won't have to add the Timeout rule to each and every test class. That'll be a big win. Trying...


            Btw, when researching more about that, i found this:

            The statement passed to the TestRule will never throw an exception, and throwing an exception from the TestRule will result in undefined behavior. This means that some TestRules, such as ErrorCollector, ExpectedException, and Timeout, have undefined behavior when used as ClassRules.

            Ref:http://junit.org/junit4/javadoc/4.12/org/junit/ClassRule.html

            appy Apekshit Sharma added a comment - - edited I was thinking about this approach more during skiing, and got another idea. Let me try that quickly too. It's basically this- We can use RunListener to add timeout rule to every test class via reflection before it gets started. The only thing to verify is, will junit pick up this dynamic runtime addition of rules to test class. If it works, we won't have to add the Timeout rule to each and every test class. That'll be a big win. Trying... Btw, when researching more about that, i found this: The statement passed to the TestRule will never throw an exception, and throwing an exception from the TestRule will result in undefined behavior. This means that some TestRules, such as ErrorCollector, ExpectedException, and Timeout, have undefined behavior when used as ClassRules. Ref: http://junit.org/junit4/javadoc/4.12/org/junit/ClassRule.html

            But i agree with chia, good stuff and great patch!

            appy Apekshit Sharma added a comment - But i agree with chia, good stuff and great patch!
            zhangduo Duo Zhang added a comment -

            I was also thinking about doing this by some surefire magic but failed.

            On the RunListener, how do you get the statement object and replace it through the Description object passed in? If you means that you want to change the test class and add a field at runtime, this is a runtime byte code rewriting, not a simple reflection. You need javasist or something else to do this. And I’m afraid that it will not work since the class has already been loaded before.

            I was also thinking a way which is similar, instrumentation. But I can not find a maven plugin which can do instrumentation. All search results are about test coverage...

            Thanks.

            zhangduo Duo Zhang added a comment - I was also thinking about doing this by some surefire magic but failed. On the RunListener, how do you get the statement object and replace it through the Description object passed in? If you means that you want to change the test class and add a field at runtime, this is a runtime byte code rewriting, not a simple reflection. You need javasist or something else to do this. And I’m afraid that it will not work since the class has already been loaded before. I was also thinking a way which is similar, instrumentation. But I can not find a maven plugin which can do instrumentation. All search results are about test coverage... Thanks.

            Ah, you already looked in that direction...nice!
            Sad that there's no way, not even a hard one, to do it once for all.
            +1 on your great patch.

            appy Apekshit Sharma added a comment - Ah, you already looked in that direction...nice! Sad that there's no way, not even a hard one, to do it once for all. +1 on your great patch.
            zhangduo Duo Zhang added a comment -

            Anyway, I tried to add a RunListener in the surefire config but failed. You can see the pom.xml in the patch, it does not work...
            It will be great if you can find a way to make it work. At least we need your rule checker to confirm that all UTs have a ClassRule.

            Thanks.

            zhangduo Duo Zhang added a comment - Anyway, I tried to add a RunListener in the surefire config but failed. You can see the pom.xml in the patch, it does not work... It will be great if you can find a way to make it work. At least we need your rule checker to confirm that all UTs have a ClassRule. Thanks.

            But yeah, get a good QA run, because i suspect that it's a major thing to change scope of timeout and will likely push a lot of existing tests over new timeout rule's boundary i.e. many timeout failures.
            If it becomes painful to get good run, i'd suggest to first make just the core change - RunListener and CategoryBasedTimeout - and then addendum/separate jira for adding rule to tests.

            appy Apekshit Sharma added a comment - But yeah, get a good QA run, because i suspect that it's a major thing to change scope of timeout and will likely push a lot of existing tests over new timeout rule's boundary i.e. many timeout failures. If it becomes painful to get good run, i'd suggest to first make just the core change - RunListener and CategoryBasedTimeout - and then addendum/separate jira for adding rule to tests.
            zhangduo Duo Zhang added a comment -

            OK, I found out why the listener does not work. In hbase-common/pom.xml we define a surefire plugin and specify a linstener, which overwrite the one in the parent pom.xml. Let me move the listener to the parent pom to see if any problems.

            zhangduo Duo Zhang added a comment - OK, I found out why the listener does not work. In hbase-common/pom.xml we define a surefire plugin and specify a linstener, which overwrite the one in the parent pom.xml. Let me move the listener to the parent pom to see if any problems.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 21s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 1s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1138 new or modified test files.
                  master Compile Tests
            0 mvndep 0m 36s Maven dependency ordering for branch
            +1 mvninstall 7m 51s master passed
            +1 compile 6m 3s master passed
            +1 checkstyle 11m 49s master passed
            +1 shadedjars 16m 25s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 7m 48s master passed
                  Patch Compile Tests
            0 mvndep 0m 12s Maven dependency ordering for patch
            +1 mvninstall 4m 19s the patch passed
            +1 compile 4m 5s the patch passed
            +1 javac 4m 5s the patch passed
            -1 checkstyle 0m 28s hbase-common: The patch generated 1 new + 131 unchanged - 1 fixed = 132 total (was 132)
            +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-hadoop-compat passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle
            +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37)
            -1 checkstyle 0m 31s hbase-client: The patch generated 2 new + 143 unchanged - 35 fixed = 145 total (was 178)
            +1 checkstyle 0m 14s The patch hbase-zookeeper passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-replication passed checkstyle
            +1 checkstyle 0m 15s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51)
            +1 checkstyle 0m 17s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90)
            -1 checkstyle 1m 51s hbase-server: The patch generated 17 new + 3110 unchanged - 417 fixed = 3127 total (was 3527)
            +1 checkstyle 0m 24s hbase-mapreduce: The patch generated 0 new + 387 unchanged - 52 fixed = 387 total (was 439)
            +1 checkstyle 0m 31s The patch hbase-thrift passed checkstyle
            +1 checkstyle 0m 14s The patch hbase-rsgroup passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-shell passed checkstyle
            +1 checkstyle 0m 16s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83)
            +1 checkstyle 0m 16s hbase-backup: The patch generated 0 new + 62 unchanged - 1 fixed = 62 total (was 63)
            +1 checkstyle 0m 24s The patch hbase-it passed checkstyle
            +1 checkstyle 0m 16s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12)
            +1 checkstyle 0m 20s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195)
            +1 checkstyle 0m 13s The patch hbase-spark passed checkstyle
            +1 checkstyle 0m 13s The patch hbase-client-project passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-shaded-client-project passed checkstyle
            -1 checkstyle 3m 18s root: The patch generated 20 new + 4195 unchanged - 613 fixed = 4215 total (was 4808)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 6s The patch has no ill-formed XML file.
            +1 shadedjars 4m 46s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 18m 19s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 8m 0s the patch passed
                  Other Tests
            -1 unit 3m 19s root in the patch failed.
            +1 asflicense 2m 57s The patch does not generate ASF License warnings.
            96m 56s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19873
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908047/HBASE-19873-v2.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux bd19697d50f4 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / f1502a3aca
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-hbase-common.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-hbase-client.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/patch-unit-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11216/testReport/
            modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11216/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1138 new or modified test files.       master Compile Tests 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 7m 51s master passed +1 compile 6m 3s master passed +1 checkstyle 11m 49s master passed +1 shadedjars 16m 25s branch has no errors when building our shaded downstream artifacts. +1 javadoc 7m 48s master passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 4m 19s the patch passed +1 compile 4m 5s the patch passed +1 javac 4m 5s the patch passed -1 checkstyle 0m 28s hbase-common: The patch generated 1 new + 131 unchanged - 1 fixed = 132 total (was 132) +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle +1 checkstyle 0m 12s The patch hbase-hadoop-compat passed checkstyle +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37) -1 checkstyle 0m 31s hbase-client: The patch generated 2 new + 143 unchanged - 35 fixed = 145 total (was 178) +1 checkstyle 0m 14s The patch hbase-zookeeper passed checkstyle +1 checkstyle 0m 12s The patch hbase-replication passed checkstyle +1 checkstyle 0m 15s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51) +1 checkstyle 0m 17s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90) -1 checkstyle 1m 51s hbase-server: The patch generated 17 new + 3110 unchanged - 417 fixed = 3127 total (was 3527) +1 checkstyle 0m 24s hbase-mapreduce: The patch generated 0 new + 387 unchanged - 52 fixed = 387 total (was 439) +1 checkstyle 0m 31s The patch hbase-thrift passed checkstyle +1 checkstyle 0m 14s The patch hbase-rsgroup passed checkstyle +1 checkstyle 0m 12s The patch hbase-shell passed checkstyle +1 checkstyle 0m 16s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83) +1 checkstyle 0m 16s hbase-backup: The patch generated 0 new + 62 unchanged - 1 fixed = 62 total (was 63) +1 checkstyle 0m 24s The patch hbase-it passed checkstyle +1 checkstyle 0m 16s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12) +1 checkstyle 0m 20s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195) +1 checkstyle 0m 13s The patch hbase-spark passed checkstyle +1 checkstyle 0m 13s The patch hbase-client-project passed checkstyle +1 checkstyle 0m 12s The patch hbase-shaded-client-project passed checkstyle -1 checkstyle 3m 18s root: The patch generated 20 new + 4195 unchanged - 613 fixed = 4215 total (was 4808) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 6s The patch has no ill-formed XML file. +1 shadedjars 4m 46s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 18m 19s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 8m 0s the patch passed       Other Tests -1 unit 3m 19s root in the patch failed. +1 asflicense 2m 57s The patch does not generate ASF License warnings. 96m 56s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19873 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908047/HBASE-19873-v2.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux bd19697d50f4 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / f1502a3aca maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-hbase-common.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-hbase-client.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/11216/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11216/testReport/ modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11216/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            zhangduo Duo Zhang added a comment -

            On my test machine the small tests are all passed with the newest patch, and for the second part there are lots of errors and timeouts.

            Will check it tomorrow.

            zhangduo Duo Zhang added a comment - On my test machine the small tests are all passed with the newest patch, and for the second part there are lots of errors and timeouts. Will check it tomorrow.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 14s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1138 new or modified test files.
                  master Compile Tests
            0 mvndep 0m 11s Maven dependency ordering for branch
            +1 mvninstall 4m 16s master passed
            +1 compile 4m 3s master passed
            +1 checkstyle 11m 55s master passed
            +1 shadedjars 16m 29s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 7m 32s master passed
                  Patch Compile Tests
            0 mvndep 0m 11s Maven dependency ordering for patch
            +1 mvninstall 4m 22s the patch passed
            +1 compile 4m 6s the patch passed
            +1 javac 4m 6s the patch passed
            +1 checkstyle 0m 27s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132)
            +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle
            +1 checkstyle 0m 11s The patch hbase-hadoop-compat passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle
            +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37)
            +1 checkstyle 0m 32s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178)
            +1 checkstyle 0m 13s The patch hbase-zookeeper passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-replication passed checkstyle
            +1 checkstyle 0m 13s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51)
            +1 checkstyle 0m 16s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90)
            -1 checkstyle 1m 46s hbase-server: The patch generated 1 new + 3095 unchanged - 432 fixed = 3096 total (was 3527)
            +1 checkstyle 0m 25s hbase-mapreduce: The patch generated 0 new + 387 unchanged - 52 fixed = 387 total (was 439)
            +1 checkstyle 0m 31s The patch hbase-thrift passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-rsgroup passed checkstyle
            +1 checkstyle 0m 13s The patch hbase-shell passed checkstyle
            +1 checkstyle 0m 15s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83)
            +1 checkstyle 0m 17s hbase-backup: The patch generated 0 new + 62 unchanged - 1 fixed = 62 total (was 63)
            +1 checkstyle 0m 21s The patch hbase-it passed checkstyle
            +1 checkstyle 0m 15s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12)
            +1 checkstyle 0m 19s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195)
            +1 checkstyle 0m 13s The patch hbase-spark passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-client-project passed checkstyle
            +1 checkstyle 0m 13s The patch hbase-shaded-client-project passed checkstyle
            -1 checkstyle 3m 3s root: The patch generated 1 new + 4180 unchanged - 628 fixed = 4181 total (was 4808)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 7s The patch has no ill-formed XML file.
            +1 shadedjars 4m 40s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 18m 39s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 8m 25s the patch passed
                  Other Tests
            -1 unit 117m 34s root in the patch failed.
            +1 asflicense 5m 8s The patch does not generate ASF License warnings.
            207m 15s



            Reason Tests
            Failed junit tests hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction
              hadoop.hbase.TestAcidGuaranteesWithEagerPolicy
              hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
              hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd
              hadoop.hbase.TestAcidGuaranteesWithAdaptivePolicy



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
            JIRA Issue HBASE-19873
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908052/HBASE-19873-v3.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux 7a5520c9d815 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision master / f1502a3aca
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11218/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11218/artifact/patchprocess/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/11218/artifact/patchprocess/patch-unit-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11218/testReport/
            modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11218/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1138 new or modified test files.       master Compile Tests 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 4m 16s master passed +1 compile 4m 3s master passed +1 checkstyle 11m 55s master passed +1 shadedjars 16m 29s branch has no errors when building our shaded downstream artifacts. +1 javadoc 7m 32s master passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 4m 22s the patch passed +1 compile 4m 6s the patch passed +1 javac 4m 6s the patch passed +1 checkstyle 0m 27s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132) +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle +1 checkstyle 0m 11s The patch hbase-hadoop-compat passed checkstyle +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37) +1 checkstyle 0m 32s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178) +1 checkstyle 0m 13s The patch hbase-zookeeper passed checkstyle +1 checkstyle 0m 12s The patch hbase-replication passed checkstyle +1 checkstyle 0m 13s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51) +1 checkstyle 0m 16s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90) -1 checkstyle 1m 46s hbase-server: The patch generated 1 new + 3095 unchanged - 432 fixed = 3096 total (was 3527) +1 checkstyle 0m 25s hbase-mapreduce: The patch generated 0 new + 387 unchanged - 52 fixed = 387 total (was 439) +1 checkstyle 0m 31s The patch hbase-thrift passed checkstyle +1 checkstyle 0m 12s The patch hbase-rsgroup passed checkstyle +1 checkstyle 0m 13s The patch hbase-shell passed checkstyle +1 checkstyle 0m 15s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83) +1 checkstyle 0m 17s hbase-backup: The patch generated 0 new + 62 unchanged - 1 fixed = 62 total (was 63) +1 checkstyle 0m 21s The patch hbase-it passed checkstyle +1 checkstyle 0m 15s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12) +1 checkstyle 0m 19s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195) +1 checkstyle 0m 13s The patch hbase-spark passed checkstyle +1 checkstyle 0m 12s The patch hbase-client-project passed checkstyle +1 checkstyle 0m 13s The patch hbase-shaded-client-project passed checkstyle -1 checkstyle 3m 3s root: The patch generated 1 new + 4180 unchanged - 628 fixed = 4181 total (was 4808) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 7s The patch has no ill-formed XML file. +1 shadedjars 4m 40s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 18m 39s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 8m 25s the patch passed       Other Tests -1 unit 117m 34s root in the patch failed. +1 asflicense 5m 8s The patch does not generate ASF License warnings. 207m 15s Reason Tests Failed junit tests hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction   hadoop.hbase.TestAcidGuaranteesWithEagerPolicy   hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint   hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd   hadoop.hbase.TestAcidGuaranteesWithAdaptivePolicy Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-19873 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908052/HBASE-19873-v3.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux 7a5520c9d815 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / f1502a3aca maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11218/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11218/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/11218/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11218/testReport/ modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11218/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            zhangduo Duo Zhang added a comment -

            The failed UTs are all because of timeout or interrupt(by timeout?). And the checkstyle issue is not introduced by this patch and I'm not sure how to clean it safely so leave it there.

            Let me commit to master and open follow-on issues to address the timeouts. stack What's your opinion on committing this to branch-2?

            Thanks.

            zhangduo Duo Zhang added a comment - The failed UTs are all because of timeout or interrupt(by timeout?). And the checkstyle issue is not introduced by this patch and I'm not sure how to clean it safely so leave it there. Let me commit to master and open follow-on issues to address the timeouts. stack What's your opinion on committing this to branch-2? Thanks.
            zhangduo Duo Zhang added a comment -

            Pushed to master. Thanks all for reviewing. Let me prepare a patch for branch-2.

            zhangduo Duo Zhang added a comment - Pushed to master. Thanks all for reviewing. Let me prepare a patch for branch-2.
            zhangduo Duo Zhang added a comment -

            Patch for branch-2. I know that there are some missing entries, at least we've removed some tests in HBASE-19397 but they still exist on branch-2. Just want to confirm that if our RunListener works.

            Let's try.

            Thanks.

            zhangduo Duo Zhang added a comment - Patch for branch-2. I know that there are some missing entries, at least we've removed some tests in HBASE-19397 but they still exist on branch-2. Just want to confirm that if our RunListener works. Let's try. Thanks.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 15s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1104 new or modified test files.
                  branch-2 Compile Tests
            0 mvndep 0m 16s Maven dependency ordering for branch
            +1 mvninstall 3m 28s branch-2 passed
            +1 compile 3m 3s branch-2 passed
            +1 checkstyle 11m 3s branch-2 passed
            +1 shadedjars 14m 56s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 6m 25s branch-2 passed
                  Patch Compile Tests
            0 mvndep 0m 9s Maven dependency ordering for patch
            +1 mvninstall 3m 16s the patch passed
            +1 compile 3m 3s the patch passed
            +1 javac 3m 3s the patch passed
            +1 checkstyle 0m 27s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132)
            +1 checkstyle 0m 11s The patch hbase-metrics-api passed checkstyle
            +1 checkstyle 0m 12s hbase-hadoop-compat: The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12)
            +1 checkstyle 0m 11s The patch hbase-metrics passed checkstyle
            +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37)
            +1 checkstyle 0m 32s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178)
            +1 checkstyle 0m 13s The patch hbase-zookeeper passed checkstyle
            +1 checkstyle 0m 14s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51)
            +1 checkstyle 0m 16s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90)
            -1 checkstyle 1m 55s hbase-server: The patch generated 1 new + 3122 unchanged - 440 fixed = 3123 total (was 3562)
            -1 checkstyle 0m 25s hbase-mapreduce: The patch generated 1 new + 450 unchanged - 52 fixed = 451 total (was 502)
            +1 checkstyle 0m 31s hbase-thrift: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43)
            +1 checkstyle 0m 13s The patch hbase-rsgroup passed checkstyle
            +1 checkstyle 0m 11s The patch hbase-shell passed checkstyle
            +1 checkstyle 0m 15s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83)
            +1 checkstyle 0m 23s The patch hbase-it passed checkstyle
            +1 checkstyle 0m 14s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12)
            +1 checkstyle 0m 20s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195)
            +1 checkstyle 0m 11s The patch hbase-client-project passed checkstyle
            +1 checkstyle 0m 12s The patch hbase-shaded-client-project passed checkstyle
            -1 checkstyle 3m 28s root: The patch generated 2 new + 4250 unchanged - 648 fixed = 4252 total (was 4898)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 7s The patch has no ill-formed XML file.
            +1 shadedjars 4m 2s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 14m 27s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 6m 39s the patch passed
                  Other Tests
            -1 unit 111m 20s root in the patch failed.
            +1 asflicense 5m 31s The patch does not generate ASF License warnings.
            188m 26s



            Reason Tests
            Failed junit tests hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction
              hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd
              hadoop.hbase.TestAcidGuaranteesWithBasicPolicy
              hadoop.hbase.regionserver.TestHRegion
              hadoop.hbase.TestAcidGuaranteesWithAdaptivePolicy



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
            JIRA Issue HBASE-19873
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908076/HBASE-19873-branch-2.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux 79e012ecec6d 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision branch-2 / 380169eaf2
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/patch-unit-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11223/testReport/
            modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11223/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1104 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 3m 28s branch-2 passed +1 compile 3m 3s branch-2 passed +1 checkstyle 11m 3s branch-2 passed +1 shadedjars 14m 56s branch has no errors when building our shaded downstream artifacts. +1 javadoc 6m 25s branch-2 passed       Patch Compile Tests 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 3m 16s the patch passed +1 compile 3m 3s the patch passed +1 javac 3m 3s the patch passed +1 checkstyle 0m 27s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132) +1 checkstyle 0m 11s The patch hbase-metrics-api passed checkstyle +1 checkstyle 0m 12s hbase-hadoop-compat: The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12) +1 checkstyle 0m 11s The patch hbase-metrics passed checkstyle +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37) +1 checkstyle 0m 32s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178) +1 checkstyle 0m 13s The patch hbase-zookeeper passed checkstyle +1 checkstyle 0m 14s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51) +1 checkstyle 0m 16s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90) -1 checkstyle 1m 55s hbase-server: The patch generated 1 new + 3122 unchanged - 440 fixed = 3123 total (was 3562) -1 checkstyle 0m 25s hbase-mapreduce: The patch generated 1 new + 450 unchanged - 52 fixed = 451 total (was 502) +1 checkstyle 0m 31s hbase-thrift: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43) +1 checkstyle 0m 13s The patch hbase-rsgroup passed checkstyle +1 checkstyle 0m 11s The patch hbase-shell passed checkstyle +1 checkstyle 0m 15s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83) +1 checkstyle 0m 23s The patch hbase-it passed checkstyle +1 checkstyle 0m 14s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12) +1 checkstyle 0m 20s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195) +1 checkstyle 0m 11s The patch hbase-client-project passed checkstyle +1 checkstyle 0m 12s The patch hbase-shaded-client-project passed checkstyle -1 checkstyle 3m 28s root: The patch generated 2 new + 4250 unchanged - 648 fixed = 4252 total (was 4898) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 7s The patch has no ill-formed XML file. +1 shadedjars 4m 2s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 14m 27s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 6m 39s the patch passed       Other Tests -1 unit 111m 20s root in the patch failed. +1 asflicense 5m 31s The patch does not generate ASF License warnings. 188m 26s Reason Tests Failed junit tests hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction   hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd   hadoop.hbase.TestAcidGuaranteesWithBasicPolicy   hadoop.hbase.regionserver.TestHRegion   hadoop.hbase.TestAcidGuaranteesWithAdaptivePolicy Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-19873 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908076/HBASE-19873-branch-2.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux 79e012ecec6d 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 380169eaf2 maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/11223/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11223/testReport/ modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11223/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            zhangduo Duo Zhang added a comment -

            Seems not work...

            Let me try locally...

            zhangduo Duo Zhang added a comment - Seems not work... Let me try locally...
            zhangduo Duo Zhang added a comment -

            Tried locally with 'mvn clean test', it works.

            [INFO] Running org.apache.hadoop.hbase.TestCellBuilder
            [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.004 s <<< FAILURE! - in org.apache.hadoop.hbase.TestCellBuilder
            [ERROR] org.apache.hadoop.hbase.TestCellBuilder  Time elapsed: 0.003 s  <<< FAILURE!
            java.lang.AssertionError: No HBaseClassTestRule ClassRule for org.apache.hadoop.hbase.TestCellBuilder
            

            Let me address the known timeout problems and try again...

            zhangduo Duo Zhang added a comment - Tried locally with 'mvn clean test', it works. [INFO] Running org.apache.hadoop.hbase.TestCellBuilder [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.004 s <<< FAILURE! - in org.apache.hadoop.hbase.TestCellBuilder [ERROR] org.apache.hadoop.hbase.TestCellBuilder Time elapsed: 0.003 s <<< FAILURE! java.lang.AssertionError: No HBaseClassTestRule ClassRule for org.apache.hadoop.hbase.TestCellBuilder Let me address the known timeout problems and try again...
            zhangduo Duo Zhang added a comment -

            Try again...

            zhangduo Duo Zhang added a comment - Try again...
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 16s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1104 new or modified test files.
                  branch-2 Compile Tests
            0 mvndep 0m 15s Maven dependency ordering for branch
            +1 mvninstall 3m 31s branch-2 passed
            +1 compile 3m 10s branch-2 passed
            +1 checkstyle 11m 34s branch-2 passed
            +1 shadedjars 16m 4s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 8m 6s branch-2 passed
                  Patch Compile Tests
            0 mvndep 0m 11s Maven dependency ordering for patch
            +1 mvninstall 4m 10s the patch passed
            +1 compile 3m 27s the patch passed
            +1 javac 3m 27s the patch passed
            +1 checkstyle 0m 30s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132)
            +1 checkstyle 0m 14s The patch hbase-metrics-api passed checkstyle
            +1 checkstyle 0m 16s hbase-hadoop-compat: The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12)
            +1 checkstyle 0m 13s The patch hbase-metrics passed checkstyle
            +1 checkstyle 0m 17s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37)
            +1 checkstyle 0m 38s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178)
            +1 checkstyle 0m 18s The patch hbase-zookeeper passed checkstyle
            +1 checkstyle 0m 18s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51)
            +1 checkstyle 0m 22s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90)
            -1 checkstyle 2m 4s hbase-server: The patch generated 1 new + 3121 unchanged - 439 fixed = 3122 total (was 3560)
            -1 checkstyle 0m 31s hbase-mapreduce: The patch generated 1 new + 450 unchanged - 52 fixed = 451 total (was 502)
            +1 checkstyle 0m 36s hbase-thrift: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43)
            +1 checkstyle 0m 15s The patch hbase-rsgroup passed checkstyle
            +1 checkstyle 0m 13s The patch hbase-shell passed checkstyle
            +1 checkstyle 0m 17s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83)
            +1 checkstyle 0m 25s The patch hbase-it passed checkstyle
            +1 checkstyle 0m 19s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12)
            +1 checkstyle 0m 24s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195)
            +1 checkstyle 0m 16s The patch hbase-client-project passed checkstyle
            +1 checkstyle 0m 15s The patch hbase-shaded-client-project passed checkstyle
            -1 checkstyle 3m 41s root: The patch generated 2 new + 4249 unchanged - 647 fixed = 4251 total (was 4896)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 9s The patch has no ill-formed XML file.
            +1 shadedjars 4m 43s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 16m 55s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 8m 2s the patch passed
                  Other Tests
            +1 unit 149m 55s root in the patch passed.
            +1 asflicense 6m 53s The patch does not generate ASF License warnings.
            239m 20s



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
            JIRA Issue HBASE-19873
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908124/HBASE-19873-branch-2-v1.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux 2c9d18734b77 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision branch-2 / 5b0d7dc45b
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/diff-checkstyle-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11231/testReport/
            modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11231/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1104 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 3m 31s branch-2 passed +1 compile 3m 10s branch-2 passed +1 checkstyle 11m 34s branch-2 passed +1 shadedjars 16m 4s branch has no errors when building our shaded downstream artifacts. +1 javadoc 8m 6s branch-2 passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 4m 10s the patch passed +1 compile 3m 27s the patch passed +1 javac 3m 27s the patch passed +1 checkstyle 0m 30s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132) +1 checkstyle 0m 14s The patch hbase-metrics-api passed checkstyle +1 checkstyle 0m 16s hbase-hadoop-compat: The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12) +1 checkstyle 0m 13s The patch hbase-metrics passed checkstyle +1 checkstyle 0m 17s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37) +1 checkstyle 0m 38s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178) +1 checkstyle 0m 18s The patch hbase-zookeeper passed checkstyle +1 checkstyle 0m 18s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51) +1 checkstyle 0m 22s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90) -1 checkstyle 2m 4s hbase-server: The patch generated 1 new + 3121 unchanged - 439 fixed = 3122 total (was 3560) -1 checkstyle 0m 31s hbase-mapreduce: The patch generated 1 new + 450 unchanged - 52 fixed = 451 total (was 502) +1 checkstyle 0m 36s hbase-thrift: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43) +1 checkstyle 0m 15s The patch hbase-rsgroup passed checkstyle +1 checkstyle 0m 13s The patch hbase-shell passed checkstyle +1 checkstyle 0m 17s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83) +1 checkstyle 0m 25s The patch hbase-it passed checkstyle +1 checkstyle 0m 19s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12) +1 checkstyle 0m 24s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195) +1 checkstyle 0m 16s The patch hbase-client-project passed checkstyle +1 checkstyle 0m 15s The patch hbase-shaded-client-project passed checkstyle -1 checkstyle 3m 41s root: The patch generated 2 new + 4249 unchanged - 647 fixed = 4251 total (was 4896) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 9s The patch has no ill-formed XML file. +1 shadedjars 4m 43s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 16m 55s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 8m 2s the patch passed       Other Tests +1 unit 149m 55s root in the patch passed. +1 asflicense 6m 53s The patch does not generate ASF License warnings. 239m 20s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-19873 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908124/HBASE-19873-branch-2-v1.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux 2c9d18734b77 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 5b0d7dc45b maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11231/testReport/ modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11231/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            zhangduo Duo Zhang added a comment -

            Oh, the junit test is passed. Any concerns? stack. Thanks.

            zhangduo Duo Zhang added a comment - Oh, the junit test is passed. Any concerns? stack . Thanks.
            zhangduo Duo Zhang added a comment -

            The newest nightly build does not crash. We have run all the UTs in hbase-server, although there are lots of failures...

            https://builds.apache.org/job/HBase%20Nightly/job/master/211/artifact/output-jdk8-hadoop2/patch-unit-root.txt

            zhangduo Duo Zhang added a comment - The newest nightly build does not crash. We have run all the UTs in hbase-server, although there are lots of failures... https://builds.apache.org/job/HBase%20Nightly/job/master/211/artifact/output-jdk8-hadoop2/patch-unit-root.txt
            zhangduo Duo Zhang added a comment -

            Oh, it is a bit strange. If I remove the ClassRule from the test and try it locally, it will fail. I'm pretty sure that there are some tests in branch-2 does not have the annotation. Need to find out why they do not fail.

            zhangduo Duo Zhang added a comment - Oh, it is a bit strange. If I remove the ClassRule from the test and try it locally, it will fail. I'm pretty sure that there are some tests in branch-2 does not have the annotation. Need to find out why they do not fail.
            zhangduo Duo Zhang added a comment -

            There are 5 tests do not have the class rule but they succeeded in the pre commit job...

            Missing rule: ./hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedHFileOutputFormat2.java
            Missing rule: ./hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedWALPlayer2.java
            Missing rule: ./hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedImportExport2.java
            Missing rule: ./hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationZKNodeCleaner.java
            Missing rule: ./hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateZKImpl.java
            

            The pre commit junit log

            https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/patch-unit-root.txt

            Really strange...

            zhangduo Duo Zhang added a comment - There are 5 tests do not have the class rule but they succeeded in the pre commit job... Missing rule: ./hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedHFileOutputFormat2.java Missing rule: ./hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedWALPlayer2.java Missing rule: ./hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedImportExport2.java Missing rule: ./hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationZKNodeCleaner.java Missing rule: ./hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateZKImpl.java The pre commit junit log https://builds.apache.org/job/PreCommit-HBASE-Build/11231/artifact/patchprocess/patch-unit-root.txt Really strange...
            stack Michael Stack added a comment -

            +1 for branch-2.

            If you want to pass me the work stabilizing branch-2 post-commit, just say. I can work on it. Thanks Apache9

             

            stack Michael Stack added a comment - +1 for branch-2. If you want to pass me the work stabilizing branch-2 post-commit, just say. I can work on it. Thanks Apache9  
            zhangduo Duo Zhang added a comment -

            Anyway, add the class rule to the 5 tests. Filed HBASE-19887 for the checker.

            zhangduo Duo Zhang added a comment - Anyway, add the class rule to the 5 tests. Filed HBASE-19887 for the checker.
            stack Michael Stack added a comment -

            [ERROR] Tests run: 3629, Failures: 0, Errors: 16, Skipped: 39, Flakes: 2

             

            Nice. I don't recall ever seeing the test count this high. I'll work on the failing tests.

            stack Michael Stack added a comment - [ERROR] Tests run: 3629, Failures: 0, Errors: 16, Skipped: 39, Flakes: 2   Nice. I don't recall ever seeing the test count this high. I'll work on the failing tests.
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4491 (See https://builds.apache.org/job/HBase-Trunk_matrix/4491/)
            HBASE-19873 addendum remove unused class file (zhangduo: rev 5c8ba7526dc133621f32b61edabfac9b40c895a3)

            • (delete) ReorderImports.class
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4491 (See https://builds.apache.org/job/HBase-Trunk_matrix/4491/ ) HBASE-19873 addendum remove unused class file (zhangduo: rev 5c8ba7526dc133621f32b61edabfac9b40c895a3) (delete) ReorderImports.class
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 14s Docker mode activated.
                  Prechecks
            0 findbugs 0m 0s Findbugs executables are not available.
            +1 hbaseanti 0m 1s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1108 new or modified test files.
                  branch-2 Compile Tests
            0 mvndep 0m 17s Maven dependency ordering for branch
            +1 mvninstall 3m 29s branch-2 passed
            +1 compile 3m 4s branch-2 passed
            +1 checkstyle 11m 38s branch-2 passed
            +1 shadedjars 15m 37s branch has no errors when building our shaded downstream artifacts.
            +1 javadoc 6m 38s branch-2 passed
                  Patch Compile Tests
            0 mvndep 0m 11s Maven dependency ordering for patch
            +1 mvninstall 3m 18s the patch passed
            +1 compile 3m 4s the patch passed
            +1 javac 3m 4s the patch passed
            +1 checkstyle 0m 27s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132)
            +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle
            +1 checkstyle 0m 13s hbase-hadoop-compat: The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12)
            +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle
            +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37)
            +1 checkstyle 0m 33s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178)
            +1 checkstyle 0m 14s The patch hbase-zookeeper passed checkstyle
            +1 checkstyle 0m 15s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51)
            +1 checkstyle 0m 17s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90)
            -1 checkstyle 2m 3s hbase-server: The patch generated 1 new + 3121 unchanged - 439 fixed = 3122 total (was 3560)
            +1 checkstyle 0m 28s hbase-mapreduce: The patch generated 0 new + 517 unchanged - 54 fixed = 517 total (was 571)
            +1 checkstyle 0m 31s hbase-thrift: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43)
            +1 checkstyle 0m 13s The patch hbase-rsgroup passed checkstyle
            +1 checkstyle 0m 13s The patch hbase-shell passed checkstyle
            +1 checkstyle 0m 15s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83)
            +1 checkstyle 0m 23s The patch hbase-it passed checkstyle
            +1 checkstyle 0m 16s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12)
            +1 checkstyle 0m 20s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195)
            +1 checkstyle 0m 12s The patch hbase-client-project passed checkstyle
            +1 checkstyle 0m 13s The patch hbase-shaded-client-project passed checkstyle
            -1 checkstyle 3m 33s root: The patch generated 3 new + 4314 unchanged - 651 fixed = 4317 total (was 4965)
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 7s The patch has no ill-formed XML file.
            +1 shadedjars 4m 0s patch has no errors when building our shaded downstream artifacts.
            +1 hadoopcheck 14m 29s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
            +1 javadoc 6m 45s the patch passed
                  Other Tests
            -1 unit 121m 24s root in the patch failed.
            +1 asflicense 6m 7s The patch does not generate ASF License warnings.
            201m 7s



            Reason Tests
            Failed junit tests hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks
              hadoop.hbase.TestFullLogReconstruction



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
            JIRA Issue HBASE-19873
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908167/HBASE-19873-branch-2-v2.patch
            Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml
            uname Linux dcfd89ad7a91 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
            git revision branch-2 / 1efa050ebf
            maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z)
            Default Java 1.8.0_151
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11237/artifact/patchprocess/diff-checkstyle-hbase-server.txt
            checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11237/artifact/patchprocess/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HBASE-Build/11237/artifact/patchprocess/patch-unit-root.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11237/testReport/
            modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: .
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11237/console
            Powered by Apache Yetus 0.6.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 1s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1108 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 3m 29s branch-2 passed +1 compile 3m 4s branch-2 passed +1 checkstyle 11m 38s branch-2 passed +1 shadedjars 15m 37s branch has no errors when building our shaded downstream artifacts. +1 javadoc 6m 38s branch-2 passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 3m 18s the patch passed +1 compile 3m 4s the patch passed +1 javac 3m 4s the patch passed +1 checkstyle 0m 27s hbase-common: The patch generated 0 new + 131 unchanged - 1 fixed = 131 total (was 132) +1 checkstyle 0m 12s The patch hbase-metrics-api passed checkstyle +1 checkstyle 0m 13s hbase-hadoop-compat: The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12) +1 checkstyle 0m 12s The patch hbase-metrics passed checkstyle +1 checkstyle 0m 13s hbase-hadoop2-compat: The patch generated 0 new + 18 unchanged - 19 fixed = 18 total (was 37) +1 checkstyle 0m 33s hbase-client: The patch generated 0 new + 143 unchanged - 35 fixed = 143 total (was 178) +1 checkstyle 0m 14s The patch hbase-zookeeper passed checkstyle +1 checkstyle 0m 15s hbase-http: The patch generated 0 new + 43 unchanged - 8 fixed = 43 total (was 51) +1 checkstyle 0m 17s hbase-procedure: The patch generated 0 new + 45 unchanged - 45 fixed = 45 total (was 90) -1 checkstyle 2m 3s hbase-server: The patch generated 1 new + 3121 unchanged - 439 fixed = 3122 total (was 3560) +1 checkstyle 0m 28s hbase-mapreduce: The patch generated 0 new + 517 unchanged - 54 fixed = 517 total (was 571) +1 checkstyle 0m 31s hbase-thrift: The patch generated 0 new + 42 unchanged - 1 fixed = 42 total (was 43) +1 checkstyle 0m 13s The patch hbase-rsgroup passed checkstyle +1 checkstyle 0m 13s The patch hbase-shell passed checkstyle +1 checkstyle 0m 15s hbase-endpoint: The patch generated 0 new + 63 unchanged - 20 fixed = 63 total (was 83) +1 checkstyle 0m 23s The patch hbase-it passed checkstyle +1 checkstyle 0m 16s hbase-examples: The patch generated 0 new + 7 unchanged - 5 fixed = 7 total (was 12) +1 checkstyle 0m 20s hbase-rest: The patch generated 0 new + 185 unchanged - 10 fixed = 185 total (was 195) +1 checkstyle 0m 12s The patch hbase-client-project passed checkstyle +1 checkstyle 0m 13s The patch hbase-shaded-client-project passed checkstyle -1 checkstyle 3m 33s root: The patch generated 3 new + 4314 unchanged - 651 fixed = 4317 total (was 4965) +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 7s The patch has no ill-formed XML file. +1 shadedjars 4m 0s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 14m 29s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 javadoc 6m 45s the patch passed       Other Tests -1 unit 121m 24s root in the patch failed. +1 asflicense 6m 7s The patch does not generate ASF License warnings. 201m 7s Reason Tests Failed junit tests hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks   hadoop.hbase.TestFullLogReconstruction Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-19873 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12908167/HBASE-19873-branch-2-v2.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml uname Linux dcfd89ad7a91 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 1efa050ebf maven version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) Default Java 1.8.0_151 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11237/artifact/patchprocess/diff-checkstyle-hbase-server.txt checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/11237/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/11237/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/11237/testReport/ modules C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-rest hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/11237/console Powered by Apache Yetus 0.6.0 http://yetus.apache.org This message was automatically generated.
            stack Michael Stack added a comment -

            Test failures pass locally for me. Fixed checkstyle and pushed (since Apache9 probably sleeping and better to get this big patch in and then do fixup). I started a nightly run. I'm on the test results.

            stack Michael Stack added a comment - Test failures pass locally for me. Fixed checkstyle and pushed (since Apache9 probably sleeping and better to get this big patch in and then do fixup). I started a nightly run. I'm on the test results.
            stack Michael Stack added a comment -

            Resolving. Pushed to master and branch-2. Will follow-up in new issues. Sweet work Apache9

            stack Michael Stack added a comment - Resolving. Pushed to master and branch-2. Will follow-up in new issues. Sweet work Apache9
            zhangduo Duo Zhang added a comment -

            Thanks stack.

            zhangduo Duo Zhang added a comment - Thanks stack .
            hudson Hudson added a comment -

            Results for branch branch-2
            build #465 on builds.a.o: -1 overall


            details (if available):

            +1 general checks
            – For more information see general report

            -1 jdk8 hadoop2 checks
            – For more information see jdk8 (hadoop2) report

            -1 jdk8 hadoop3 checks
            – For more information see jdk8 (hadoop3) report

            +1 source release artifact
            – See build output for details.

            hudson Hudson added a comment - Results for branch branch-2 build #465 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details.

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: