Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19147 All branch-2 unit tests pass
  3. HBASE-19911

Convert some tests from small to medium because they are timing out: TestNettyRpcServer, TestClientClusterStatus, TestCheckTestClasses

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-beta-2, 2.0.0
    • None
    • None
    • Hide
      Changed a few tests so they are medium sized rather than small size.

      Also, upped the time we wait on small tests to 60seconds from 30seconds. Small tests are tests that run in 15seconds or less. What we changed was the timeout watcher. It is now more lax, more tolerant of dodgy infrastructure that might be running tests slowly.
      Show
      Changed a few tests so they are medium sized rather than small size. Also, upped the time we wait on small tests to 60seconds from 30seconds. Small tests are tests that run in 15seconds or less. What we changed was the timeout watcher. It is now more lax, more tolerant of dodgy infrastructure that might be running tests slowly.

    Description

      Found some more timeouts of small tests.

      TestNettyRpcServer

      https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/11307/testReport/junit/org.apache.hadoop.hbase.ipc/TestNettyRpcServer/org_apache_hadoop_hbase_ipc_TestNettyRpcServer/

      On local machine takes 14 seconds to run 1 test. In the above failure..., the test needs another second or so to complete.... It has been running 30 seconds.

      Starts a minihbasecluster, creates a table, then shuts down. Shouldn't even take 3 seconds but thats another story.

      TestClientClusterStatus is a small test that starts 5 regionservers and 3 masters. Then does some stopping of servers, etc.

      .. in same test run...

      https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/11307/testReport/junit/org.apache.hadoop.hbase/TestClientClusterStatus/org_apache_hadoop_hbase_TestClientClusterStatus/

      ... it timed out after 30 seconds. Its almost done w/ shutdown but not quite.

      Attachments

        Issue Links

          Activity

            stack Michael Stack added a comment -

            .001 is what I pushed to master and branch-2. Leaving open until for sure this is fixed.

            stack Michael Stack added a comment - .001 is what I pushed to master and branch-2. Leaving open until for sure this is fixed.
            stack Michael Stack added a comment -

            Addendum converts over TestCheckTestClasses to be medium test too.. It timed out at 30 seconds but doesn't log anything. Guessing similar issue.

            stack Michael Stack added a comment - Addendum converts over TestCheckTestClasses to be medium test too.. It timed out at 30 seconds but doesn't log anything. Guessing similar issue.
            chia7712 Chia-Ping Tsai added a comment -

            +1

            chia7712 Chia-Ping Tsai added a comment - +1
            chia7712 Chia-Ping Tsai added a comment -

            TestClientClusterMetrics and TestFavoredNodeAssignmentHelper timeout also. TestClientClusterMetrics is the new version of TestClientClusterStatus so it should be promoted to be medium test too. My local machine takes 20 seconds to run TestFavoredNodeAssignmentHelper. It won't harm if we promote it to be medium test also I think.

            see https://builds.apache.org/job/PreCommit-HBASE-Build/11316/artifact/patchprocess/patch-unit-hbase-server.txt

            chia7712 Chia-Ping Tsai added a comment - TestClientClusterMetrics and TestFavoredNodeAssignmentHelper timeout also. TestClientClusterMetrics is the new version of TestClientClusterStatus so it should be promoted to be medium test too. My local machine takes 20 seconds to run TestFavoredNodeAssignmentHelper. It won't harm if we promote it to be medium test also I think. see  https://builds.apache.org/job/PreCommit-HBASE-Build/11316/artifact/patchprocess/patch-unit-hbase-server.txt
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4506 (See https://builds.apache.org/job/HBase-Trunk_matrix/4506/)
            HBASE-19911 Convert some tests from small to medium because they are (stack: rev b9cb1187b50d0ee1bdfb0e2e417d2eae6982305d)

            • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcServer.java
            • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java
              HBASE-19911 Convert some tests from small to medium because they are (stack: rev 9272f40a5c8afeeaa9569688c0fabfcd9264ee5e)
            • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4506 (See https://builds.apache.org/job/HBase-Trunk_matrix/4506/ ) HBASE-19911 Convert some tests from small to medium because they are (stack: rev b9cb1187b50d0ee1bdfb0e2e417d2eae6982305d) (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcServer.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java HBASE-19911 Convert some tests from small to medium because they are (stack: rev 9272f40a5c8afeeaa9569688c0fabfcd9264ee5e) (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
            stack Michael Stack added a comment -

            Thank you chia7712 I'm going to do the Apache9 suggestion of upping test timeout for small from 30 seconds to 60 seconds.

            HBASE-19911.addendum2.up_small_timeout_from_30_to_60_seconds.patch is the second addendum. Does this:

            more HBASE-19911.addendum2.up_small_timeout_from_30_to_60_seconds.patch
            From ced502801faa24c4e8791a396cbc99ad6290779c Mon Sep 17 00:00:00 2001
            From: Michael Stack <stack@apache.org>
            Date: Thu, 1 Feb 2018 08:24:54 -0800
            Subject: [PATCH] HBASE-19911 Convert some tests from small to medium because
            they are timing out: TestNettyRpcServer, TestClientClusterStatus; ADDENDUM2
            Up timeout for smalltests from 30 seconds to 60 seconds – a pause on jenkins
            can mess up smalltests


            .../src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java | 4 +++-
            1 file changed, 3 insertions, 1 deletion

            diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java
            index 74bd70e999..734ce3f241 100644
            — a/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java
            +++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java
            @@ -63,7 +63,9 @@ public final class HBaseClassTestRule implements TestRule {
            for (Class<?> c : categories[0].value()) {
            if (c == SmallTests.class)

            { // See SmallTests. Supposed to run 15 seconds. - return 30; + // Lots of these timeout on Jenkins... a stall of ten or twenty seconds mess up what looks + // fine when run local. + return 60; }

            else if (c == MediumTests.class) {
            // See MediumTests. Supposed to run 50 seconds.
            return 180;

            FYI, this is SECOND amendment. The first changed TestCheckTestClasses so it is medium sized too.

            stack Michael Stack added a comment - Thank you chia7712 I'm going to do the Apache9 suggestion of upping test timeout for small from 30 seconds to 60 seconds. HBASE-19911 .addendum2.up_small_timeout_from_30_to_60_seconds.patch is the second addendum. Does this: more HBASE-19911 .addendum2.up_small_timeout_from_30_to_60_seconds.patch From ced502801faa24c4e8791a396cbc99ad6290779c Mon Sep 17 00:00:00 2001 From: Michael Stack <stack@apache.org> Date: Thu, 1 Feb 2018 08:24:54 -0800 Subject: [PATCH] HBASE-19911 Convert some tests from small to medium because they are timing out: TestNettyRpcServer, TestClientClusterStatus; ADDENDUM2 Up timeout for smalltests from 30 seconds to 60 seconds – a pause on jenkins can mess up smalltests — .../src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java | 4 +++- 1 file changed, 3 insertions , 1 deletion diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java index 74bd70e999..734ce3f241 100644 — a/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java +++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java @@ -63,7 +63,9 @@ public final class HBaseClassTestRule implements TestRule { for (Class<?> c : categories [0] .value()) { if (c == SmallTests.class) { // See SmallTests. Supposed to run 15 seconds. - return 30; + // Lots of these timeout on Jenkins... a stall of ten or twenty seconds mess up what looks + // fine when run local. + return 60; } else if (c == MediumTests.class) { // See MediumTests. Supposed to run 50 seconds. return 180; – FYI, this is SECOND amendment. The first changed TestCheckTestClasses so it is medium sized too.
            hudson Hudson added a comment -

            FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4509 (See https://builds.apache.org/job/HBase-Trunk_matrix/4509/)
            HBASE-19911 Convert some tests from small to medium because they are (stack: rev 52cb9aaf6e98e89b4891ad50ac6192f54229c021)

            • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java
            hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4509 (See https://builds.apache.org/job/HBase-Trunk_matrix/4509/ ) HBASE-19911 Convert some tests from small to medium because they are (stack: rev 52cb9aaf6e98e89b4891ad50ac6192f54229c021) (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java

            People

              stack Michael Stack
              stack Michael Stack
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: