Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
And both TestVisibilityLabelsOnNewVersionBehaviorTable and its parent class run about 2 minutes, which is not safe to declared as MediumTests.
Attachments
Attachments
- HBASE-19914-v2.patch
- 174 kB
- Duo Zhang
- HBASE-19914-v1.patch
- 173 kB
- Duo Zhang
- HBASE-19914.patch
- 168 kB
- Duo Zhang
- HBASE-19914.patch
- 168 kB
- Michael Stack
Activity
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 9s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 59s | master passed |
+1 | compile | 1m 16s | master passed |
+1 | checkstyle | 1m 42s | master passed |
+1 | shadedjars | 6m 54s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 1m 9s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 16s | Maven dependency ordering for patch |
+1 | mvninstall | 5m 27s | the patch passed |
+1 | compile | 1m 27s | the patch passed |
+1 | javac | 1m 27s | the patch passed |
-1 | checkstyle | 1m 13s | hbase-server: The patch generated 36 new + 1 unchanged - 13 fixed = 37 total (was 14) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 5m 15s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 21m 26s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 1m 2s | the patch passed |
Other Tests | |||
+1 | unit | 3m 18s | hbase-client in the patch passed. |
-1 | unit | 108m 16s | hbase-server in the patch failed. |
+1 | asflicense | 0m 41s | The patch does not generate ASF License warnings. |
158m 56s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.TestZooKeeper |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908821/HBASE-19914.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 96adf667f920 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 9272f40a5c |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/11332/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11332/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11332/testReport/ |
Max. process+thread count | 5483 (vs. ulimit of 20000) |
modules | C: hbase-client hbase-server U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11332/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
Retry while Apache9 is sleeping. TestZooKeeper patch was just committed.
On patch, what is setNewVersionBehavior ?
Did you want to make TestVisibilityLabelsOnNewVersionBehaviorTable a LargeTest? Still Medium.
Otherwise +1.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 9s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 1s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 11s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 18s | master passed |
+1 | compile | 1m 3s | master passed |
+1 | checkstyle | 1m 32s | master passed |
+1 | shadedjars | 6m 20s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 49s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 43s | the patch passed |
+1 | compile | 1m 6s | the patch passed |
+1 | javac | 1m 6s | the patch passed |
-1 | checkstyle | 1m 5s | hbase-server: The patch generated 36 new + 1 unchanged - 13 fixed = 37 total (was 14) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 47s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 19m 18s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 49s | the patch passed |
Other Tests | |||
+1 | unit | 2m 59s | hbase-client in the patch passed. |
+1 | unit | 114m 3s | hbase-server in the patch passed. |
+1 | asflicense | 0m 57s | The patch does not generate ASF License warnings. |
159m 1s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908866/HBASE-19914.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 4f92bba20f62 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 38c8144a06 |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/11338/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11338/testReport/ |
Max. process+thread count | 5010 (vs. ulimit of 10000) |
modules | C: hbase-client hbase-server U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11338/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
It is the new mvcc sensitive version behavior introduced in HBASE-15968.
And since there are only 4 methods in the new TestVisibilityLabelsOnNewVersionBehaviorTable I think it is OK to declared it as MediumTests. Will check later why we only run 4 methods.
Thanks.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 10s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 22s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 30s | master passed |
+1 | compile | 1m 3s | master passed |
+1 | checkstyle | 1m 33s | master passed |
+1 | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 46s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 18s | the patch passed |
+1 | compile | 1m 2s | the patch passed |
+1 | javac | 1m 2s | the patch passed |
-1 | checkstyle | 1m 3s | hbase-server: The patch generated 2 new + 1 unchanged - 13 fixed = 3 total (was 14) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 40s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 18m 25s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 47s | the patch passed |
Other Tests | |||
+1 | unit | 2m 55s | hbase-client in the patch passed. |
-1 | unit | 102m 11s | hbase-server in the patch failed. |
+1 | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
145m 32s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.TestFullLogReconstruction |
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908910/HBASE-19914-v1.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 32f75c167861 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / a11258599e |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/11349/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11349/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11349/testReport/ |
Max. process+thread count | 5245 (vs. ulimit of 10000) |
modules | C: hbase-client hbase-server U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11349/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 8s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 21s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 27s | master passed |
+1 | compile | 1m 4s | master passed |
+1 | checkstyle | 1m 31s | master passed |
+1 | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 47s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 26s | the patch passed |
+1 | compile | 1m 2s | the patch passed |
+1 | javac | 1m 2s | the patch passed |
+1 | checkstyle | 0m 29s | The patch hbase-client passed checkstyle |
+1 | checkstyle | 1m 4s | hbase-server: The patch generated 0 new + 2 unchanged - 13 fixed = 2 total (was 15) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 18m 15s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 46s | the patch passed |
Other Tests | |||
+1 | unit | 2m 52s | hbase-client in the patch passed. |
+1 | unit | 101m 23s | hbase-server in the patch passed. |
+1 | asflicense | 0m 34s | The patch does not generate ASF License warnings. |
144m 28s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12909119/HBASE-19914-v2.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 6f5923c80f40 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / bfd74686c7 |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11378/testReport/ |
Max. process+thread count | 5159 (vs. ulimit of 10000) |
modules | C: hbase-client hbase-server U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11378/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
Go for it. Not following what is going on here but on skim patch is grand. Thanks.
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4524 (See https://builds.apache.org/job/HBase-Trunk_matrix/4524/)
HBASE-19914 Refactor TestVisibilityLabelsOnNewVersionBehaviorTable (zhangduo: rev 2e1ec3d3d8dc4ef771463decb814e7c118523bf9)
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java
- (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsOnNewVersionBehaviorTable.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
- (add) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsWithDeletesTestBase.java
Actually there are only 4 methods in TestVisibilityLabelsWithDeletes which call the createTable method in TestVisibilityLabelsOnNewVersionBehaviorTable so I only leave these 4 methods in the newly introduced VisibilityLabelsWithDeletesTestBase class.
Will check later why only 4 methods, in another issue...
Thanks.