Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20074

[FindBugs] Same code on both branches in CompactingMemStore#initMemStoreCompactor

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-beta-2, 2.0.0
    • findbugs
    • None
    • Reviewed

    Description

      galish Our findbugs checking was disabled for a few weeks and we just turned it on again. It found a good one. Mind fixing it please? Meantime I've undone the if class to get a factor dependent on index type. Thanks.

      Code Warning
      DB org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration) uses the same code for two branches
      Bug type DB_DUPLICATE_BRANCHES (click for details)
      In class org.apache.hadoop.hbase.regionserver.CompactingMemStore
      In method org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
      At CompactingMemStore.java:[line 140]
      At CompactingMemStore.java:[line 143]

      Attachments

        1. HBASE-20074-V01.patch
          2 kB
          Gali Sheffi

        Issue Links

          is related to

          Sub-task - The sub-task of the issue HBASE-20069 fix existing findbugs errors in hbase-server

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            People

              galish Gali Sheffi
              stack Michael Stack
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: