Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20400

Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Duplicate
    • 3.0.0-alpha-1, 1.5.0, 2.0.0-beta-1, 1.4.4, 2.0.0
    • None
    • master, Performance
    • None

    Description

      When backporting HBASE-18309 in HBASE-20352, the deleteFiles calls

      CleanerContext.java#getResult with a waitIfNotFinished timeout to wait for notification (notify) from the fs.delete file thread. there might be two situation need to tune the MAX_WAIT in CleanerContext or make a configuration property for waitIfNotFinished when LogClearner call getResult.

      1. fs.delete never complete (strange but possible), then we need to wait for a max of 60 seconds. here, 60 seconds might be too long
      2. getResult is waiting in the period of 500 milliseconds, but the fs.delete has completed and setFromClear is set but yet notify(). one might want to tune this 500 milliseconds to 200 or less .

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              taklwu Tak-Lon (Stephen) Wu
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: