Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20597

Use a lock to serialize access to a shared reference to ZooKeeperWatcher in HBaseReplicationEndpoint

Details

    • Reviewed

    Description

      The code that closes down a ZKW that fails to initialize when attempting to connect to the remote cluster is not MT safe and can in theory leak ZooKeeperWatcher instances. The allocation of a new ZKW and store to the reference is not atomic. Might have concurrent allocations with only one winning store, leading to leaked ZKW instances.

      Attachments

        1. HBASE-20597-branch-1.patch
          4 kB
          Andrew Kyle Purtell
        2. HBASE-20597.patch
          4 kB
          Andrew Kyle Purtell
        3. HBASE-20597.addendum.0.patch
          3 kB
          Sean Busbey
        4. HBASE-20597-branch-1.addendum-v2.0.patch
          3 kB
          Andrew Kyle Purtell

        Activity

          hudson Hudson added a comment -

          Results for branch branch-1.4
          build #339 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – Something went wrong running this stage, please check relevant console output.

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.4 build #339 on builds.a.o : -1 overall details (if available): -1 general checks – Something went wrong running this stage, please check relevant console output . -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1
          build #333 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1 build #333 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-2.0
          build #364 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-2.0 build #364 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1.3
          build #345 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.3 build #345 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch master
          build #349 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          -1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch master build #349 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report -1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-2
          build #799 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          -1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-2 build #799 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report -1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1.2
          build #349 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.2 build #349 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1115 (See https://builds.apache.org/job/HBase-1.2-IT/1115/)
          Revert "HBASE-20597 Use a lock to serialize access to a shared reference (apurtell: rev 419ee99e0239e680b4cfeb5c4650a54a3a662452)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
            HBASE-20597 Serialize access to a shared reference to ZooKeeperWatcher (apurtell: rev 6594f2656bc23b33370106c94648ec1abb1f62e7)
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1115 (See https://builds.apache.org/job/HBase-1.2-IT/1115/ ) Revert " HBASE-20597 Use a lock to serialize access to a shared reference (apurtell: rev 419ee99e0239e680b4cfeb5c4650a54a3a662452) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java HBASE-20597 Serialize access to a shared reference to ZooKeeperWatcher (apurtell: rev 6594f2656bc23b33370106c94648ec1abb1f62e7) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.3-IT #414 (See https://builds.apache.org/job/HBase-1.3-IT/414/)
          Revert "HBASE-20597 Use a lock to serialize access to a shared reference (apurtell: rev 8e79429f4c09ea9bb3c9638e83bb4ad9999dfe85)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
            HBASE-20597 Serialize access to a shared reference to ZooKeeperWatcher (apurtell: rev 405a30404bde4e6256f20542008a25e33b6b732e)
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.3-IT #414 (See https://builds.apache.org/job/HBase-1.3-IT/414/ ) Revert " HBASE-20597 Use a lock to serialize access to a shared reference (apurtell: rev 8e79429f4c09ea9bb3c9638e83bb4ad9999dfe85) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java HBASE-20597 Serialize access to a shared reference to ZooKeeperWatcher (apurtell: rev 405a30404bde4e6256f20542008a25e33b6b732e) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java

          Ah, we raced. Ok I will commit. Thanks busbey

          apurtell Andrew Kyle Purtell added a comment - Ah, we raced. Ok I will commit. Thanks busbey

          Ok, I can't detect any issues with the change with local tests. Let me know what you think of the addendum (really: revision #2 )

          apurtell Andrew Kyle Purtell added a comment - Ok, I can't detect any issues with the change with local tests. Let me know what you think of the addendum (really: revision #2 )
          busbey Sean Busbey added a comment -

          if tests pass locally for you apurtell I'm +1 on your addendum.

          busbey Sean Busbey added a comment - if tests pass locally for you apurtell I'm +1 on your addendum.
          busbey Sean Busbey added a comment -

          bookeeper jobs were stomping on system resources last week, though I don't know if that's specifically what caused process killing here.

          busbey Sean Busbey added a comment - bookeeper jobs were stomping on system resources last week, though I don't know if that's specifically what caused process killing here.

          A number of processes were killed while running the precommit, this is not related to this patch.

          apurtell Andrew Kyle Purtell added a comment - A number of processes were killed while running the precommit, this is not related to this patch.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          0 findbugs 0m 0s Findbugs executables are not available.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-1 Compile Tests
          +1 mvninstall 1m 51s branch-1 passed
          +1 compile 0m 35s branch-1 passed with JDK v1.8.0_172
          +1 compile 0m 38s branch-1 passed with JDK v1.7.0_181
          +1 checkstyle 1m 16s branch-1 passed
          +1 shadedjars 2m 36s branch has no errors when building our shaded downstream artifacts.
          +1 javadoc 0m 28s branch-1 passed with JDK v1.8.0_172
          +1 javadoc 0m 35s branch-1 passed with JDK v1.7.0_181
                Patch Compile Tests
          +1 mvninstall 1m 34s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_172
          +1 javac 0m 35s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.7.0_181
          +1 javac 0m 37s the patch passed
          -1 checkstyle 1m 15s hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 2m 33s patch has no errors when building our shaded downstream artifacts.
          -1 hadoopcheck 0m 52s The patch causes 44 errors with Hadoop v2.4.1.
          -1 hadoopcheck 1m 46s The patch causes 44 errors with Hadoop v2.5.2.
          +1 javadoc 0m 27s the patch passed with JDK v1.8.0_172
          +1 javadoc 0m 34s the patch passed with JDK v1.7.0_181
                Other Tests
          -1 unit 96m 49s hbase-server in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          118m 16s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029
          JIRA Issue HBASE-20597
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12925180/HBASE-20597-branch-1.addendum-v2.0.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux 47174c0b0197 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision branch-1 / 289d588
          maven version: Apache Maven 3.0.5
          Default Java 1.7.0_181
          Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_172 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_181
          checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/diff-checkstyle-hbase-server.txt
          hadoopcheck https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/patch-javac-2.4.1.txt
          hadoopcheck https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/patch-javac-2.5.2.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/12966/testReport/
          Max. process+thread count 3481 (vs. ulimit of 10000)
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/12966/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-1 Compile Tests +1 mvninstall 1m 51s branch-1 passed +1 compile 0m 35s branch-1 passed with JDK v1.8.0_172 +1 compile 0m 38s branch-1 passed with JDK v1.7.0_181 +1 checkstyle 1m 16s branch-1 passed +1 shadedjars 2m 36s branch has no errors when building our shaded downstream artifacts. +1 javadoc 0m 28s branch-1 passed with JDK v1.8.0_172 +1 javadoc 0m 35s branch-1 passed with JDK v1.7.0_181       Patch Compile Tests +1 mvninstall 1m 34s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_172 +1 javac 0m 35s the patch passed +1 compile 0m 37s the patch passed with JDK v1.7.0_181 +1 javac 0m 37s the patch passed -1 checkstyle 1m 15s hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 2m 33s patch has no errors when building our shaded downstream artifacts. -1 hadoopcheck 0m 52s The patch causes 44 errors with Hadoop v2.4.1. -1 hadoopcheck 1m 46s The patch causes 44 errors with Hadoop v2.5.2. +1 javadoc 0m 27s the patch passed with JDK v1.8.0_172 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_181       Other Tests -1 unit 96m 49s hbase-server in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 118m 16s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 JIRA Issue HBASE-20597 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12925180/HBASE-20597-branch-1.addendum-v2.0.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 47174c0b0197 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-1 / 289d588 maven version: Apache Maven 3.0.5 Default Java 1.7.0_181 Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_172 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_181 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/diff-checkstyle-hbase-server.txt hadoopcheck https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/patch-javac-2.4.1.txt hadoopcheck https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/patch-javac-2.5.2.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/12966/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/12966/testReport/ Max. process+thread count 3481 (vs. ulimit of 10000) modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/12966/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.
          apurtell Andrew Kyle Purtell added a comment - - edited

          FWIW mvn clean install -DskipITs -Dtest=*Replication* passes everything after HBASE-20597-branch-1.addendum-v2.0.patch is applied.

          Test environment:

          Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T11:49:05-08:00)
          Maven home: /usr/local/Cellar/maven/3.5.3/libexec
          Java version: 1.8.0_162, vendor: Oracle Corporation
          Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre
          Default locale: en_US, platform encoding: UTF-8
          OS name: "mac os x", version: "10.13.4", arch: "x86_64", family: "mac"
          
          apurtell Andrew Kyle Purtell added a comment - - edited FWIW mvn clean install -DskipITs -Dtest=*Replication* passes everything after HBASE-20597 -branch-1.addendum-v2.0.patch is applied. Test environment: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T11:49:05-08:00) Maven home: /usr/local/Cellar/maven/3.5.3/libexec Java version: 1.8.0_162, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.13.4", arch: "x86_64", family: "mac"

          Attached as HBASE-20597-branch-1.addendum-v2.0.patch. Reverts the earlier change. Just adds 'synchronized' to endpoint methods that publish, use, or modify the 'zkw' instance not already synchronized. Running replication unit tests now.

          apurtell Andrew Kyle Purtell added a comment - Attached as HBASE-20597 -branch-1.addendum-v2.0.patch. Reverts the earlier change. Just adds 'synchronized' to endpoint methods that publish, use, or modify the 'zkw' instance not already synchronized. Running replication unit tests now.

          Let me make a quick patch that does what I suggested in my last comment above. Back in a sec...

          apurtell Andrew Kyle Purtell added a comment - Let me make a quick patch that does what I suggested in my last comment above. Back in a sec...
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                master Compile Tests
          +1 mvninstall 5m 19s master passed
          +1 compile 1m 52s master passed
          +1 checkstyle 1m 15s master passed
          +1 shadedjars 5m 1s branch has no errors when building our shaded downstream artifacts.
          0 findbugs 2m 19s hbase-server in master has 2 extant Findbugs warnings.
          +1 javadoc 0m 33s master passed
                Patch Compile Tests
          +1 mvninstall 4m 53s the patch passed
          +1 compile 1m 47s the patch passed
          +1 javac 1m 47s the patch passed
          -1 checkstyle 1m 11s hbase-server: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 56s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 16m 48s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
          +1 findbugs 2m 24s hbase-server generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 javadoc 0m 34s the patch passed
                Other Tests
          -1 unit 134m 59s hbase-server in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          184m 58s



          Reason Tests
          Failed junit tests hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
            hadoop.hbase.replication.TestReplicationDroppedTables
            hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
            hadoop.hbase.replication.TestReplicationDisableInactivePeer
            hadoop.hbase.replication.TestReplicationSmallTests
            hadoop.hbase.replication.TestReplicationWithTags
            hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL
            hadoop.hbase.replication.TestReplicationSyncUpTool
            hadoop.hbase.replication.TestReplicationEndpoint
            hadoop.hbase.replication.TestNamespaceReplication
            hadoop.hbase.replication.TestReplicationKillMasterRS
            hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
            hadoop.hbase.replication.TestReplicationEmptyWALRecovery
            hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL
            hadoop.hbase.replication.TestReplicationKillSlaveRS
            hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f
          JIRA Issue HBASE-20597
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12925148/HBASE-20597.addendum.0.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux 18382d8667e6 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / 477f9fdb32
          maven version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z)
          Default Java 1.8.0_171
          findbugs v3.1.0-RC3
          checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/12962/artifact/patchprocess/diff-checkstyle-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/12962/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/12962/testReport/
          Max. process+thread count 6541 (vs. ulimit of 10000)
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/12962/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests +1 mvninstall 5m 19s master passed +1 compile 1m 52s master passed +1 checkstyle 1m 15s master passed +1 shadedjars 5m 1s branch has no errors when building our shaded downstream artifacts. 0 findbugs 2m 19s hbase-server in master has 2 extant Findbugs warnings. +1 javadoc 0m 33s master passed       Patch Compile Tests +1 mvninstall 4m 53s the patch passed +1 compile 1m 47s the patch passed +1 javac 1m 47s the patch passed -1 checkstyle 1m 11s hbase-server: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2) +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 56s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 16m 48s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. +1 findbugs 2m 24s hbase-server generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 javadoc 0m 34s the patch passed       Other Tests -1 unit 134m 59s hbase-server in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 184m 58s Reason Tests Failed junit tests hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL   hadoop.hbase.replication.TestReplicationDroppedTables   hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL   hadoop.hbase.replication.TestReplicationDisableInactivePeer   hadoop.hbase.replication.TestReplicationSmallTests   hadoop.hbase.replication.TestReplicationWithTags   hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL   hadoop.hbase.replication.TestReplicationSyncUpTool   hadoop.hbase.replication.TestReplicationEndpoint   hadoop.hbase.replication.TestNamespaceReplication   hadoop.hbase.replication.TestReplicationKillMasterRS   hadoop.hbase.replication.TestReplicationChangingPeerRegionservers   hadoop.hbase.replication.TestReplicationEmptyWALRecovery   hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL   hadoop.hbase.replication.TestReplicationKillSlaveRS   hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f JIRA Issue HBASE-20597 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12925148/HBASE-20597.addendum.0.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 18382d8667e6 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 477f9fdb32 maven version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) Default Java 1.8.0_171 findbugs v3.1.0-RC3 checkstyle https://builds.apache.org/job/PreCommit-HBASE-Build/12962/artifact/patchprocess/diff-checkstyle-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/12962/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/12962/testReport/ Max. process+thread count 6541 (vs. ulimit of 10000) modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/12962/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.

          No test failures here at all.

          It would be fine to, instead of using a lock object, to synchronize on the endpoint instance by making the relevant methods all 'synchronized'. I thought using a lock named similarly to what it was protecting was clearer about intent but didn't mean to introduce the findbugs complaint in doing so. Either way achieves the same end.

          apurtell Andrew Kyle Purtell added a comment - No test failures here at all. It would be fine to, instead of using a lock object, to synchronize on the endpoint instance by making the relevant methods all 'synchronized'. I thought using a lock named similarly to what it was protecting was clearer about intent but didn't mean to introduce the findbugs complaint in doing so. Either way achieves the same end.
          busbey Sean Busbey added a comment -

          in case the java/maven versions matter for the errors I'm getting before/after this addendum:

          Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T00:58:13-07:00)
          Maven home: /usr/share/apache-maven-3.5.2
          Java version: 1.8.0_171, vendor: Oracle Corporation
          Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.171-8.b10.el7_5.x86_64/jre
          Default locale: en_US, platform encoding: UTF-8
          OS name: "linux", version: "3.10.0-693.21.1.el7.x86_64", arch: "amd64", family: "unix"
          
          busbey Sean Busbey added a comment - in case the java/maven versions matter for the errors I'm getting before/after this addendum: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T00:58:13-07:00) Maven home: /usr/share/apache-maven-3.5.2 Java version: 1.8.0_171, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.171-8.b10.el7_5.x86_64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux" , version: "3.10.0-693.21.1.el7.x86_64" , arch: "amd64" , family: "unix"
          busbey Sean Busbey added a comment - - edited

          here's a potential addendum that ensures safe retrieval / update via an AtomicReference and removes the synchronized from setRegionServers.

          Some of the other locking in the HBaseReplicationEndpoint still looks confusing to me (e.g. getPeerUUID), but it doesn't look unsafe so I left it alone.

          this patch clears findbugs locally ( mvn test-compile findbugs:check -DskipTests=true ). I'm getting some test failures when I use mvn -Psite-install-step install && mvn test -Dtest=*Replication*. Looking to chase them down, but I also get failures when I don't have this addendum in place so I'm not sure yet what's environment, flaky, or a problem with my approach.

          busbey Sean Busbey added a comment - - edited here's a potential addendum that ensures safe retrieval / update via an AtomicReference and removes the synchronized from setRegionServers . Some of the other locking in the HBaseReplicationEndpoint still looks confusing to me (e.g. getPeerUUID), but it doesn't look unsafe so I left it alone. this patch clears findbugs locally ( mvn test-compile findbugs:check -DskipTests=true ). I'm getting some test failures when I use mvn -Psite-install-step install && mvn test -Dtest=*Replication* . Looking to chase them down, but I also get failures when I don't have this addendum in place so I'm not sure yet what's environment, flaky, or a problem with my approach.
          busbey Sean Busbey added a comment -

          reopening. the findbugs complaint was due to this patch.

              */
          -  // Synchronize peer cluster connection attempts to avoid races and rate
          -  // limit connections when multiple replication sources try to connect to
          -  // the peer cluster. If the peer cluster is down we can get out of control
          -  // over time.
          -  public synchronized List<ServerName> getRegionServers() {
          +  public List<ServerName> getRegionServers() {
               try {
          
          

          This removal of synchronized from the getRegionServers method means that the regionServers variable no longer has a read guard when it is returned, but still has a write guard in setRegionServers.

          busbey Sean Busbey added a comment - reopening. the findbugs complaint was due to this patch. */ - // Synchronize peer cluster connection attempts to avoid races and rate - // limit connections when multiple replication sources try to connect to - // the peer cluster. If the peer cluster is down we can get out of control - // over time. - public synchronized List<ServerName> getRegionServers() { + public List<ServerName> getRegionServers() { try { This removal of synchronized from the getRegionServers method means that the regionServers variable no longer has a read guard when it is returned, but still has a write guard in setRegionServers .
          hudson Hudson added a comment -

          Results for branch branch-1.3
          build #340 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.3 build #340 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1.2
          build #343 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.2 build #343 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1.4
          build #333 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.4 build #333 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch master
          build #343 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          -1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch master build #343 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report -1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1
          build #327 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1 build #327 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-2
          build #775 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          -1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-2 build #775 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report -1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-2.0
          build #340 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-2.0 build #340 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1113 (See https://builds.apache.org/job/HBase-1.2-IT/1113/)
          HBASE-20597 Use a lock to serialize access to a shared reference to (apurtell: rev 8040c0ca7696dfa776ee8449750279aa91c3fbd4)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1113 (See https://builds.apache.org/job/HBase-1.2-IT/1113/ ) HBASE-20597 Use a lock to serialize access to a shared reference to (apurtell: rev 8040c0ca7696dfa776ee8449750279aa91c3fbd4) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.3-IT #410 (See https://builds.apache.org/job/HBase-1.3-IT/410/)
          HBASE-20597 Use a lock to serialize access to a shared reference to (apurtell: rev b50e149804afeeb91bc561d2e2ae1ca6fe33c7d3)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.3-IT #410 (See https://builds.apache.org/job/HBase-1.3-IT/410/ ) HBASE-20597 Use a lock to serialize access to a shared reference to (apurtell: rev b50e149804afeeb91bc561d2e2ae1ca6fe33c7d3) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java

          To https://git-wip-us.apache.org/repos/asf/hbase.git
          498f3bf953..1b70763b9e branch-1 -> branch-1
          66941d70bb..8040c0ca76 branch-1.2 -> branch-1.2
          94001b35a7..b50e149804 branch-1.3 -> branch-1.3
          cd6397be6b..7182df3bd3 branch-1.4 -> branch-1.4
          12d75724d7..60dcef289b branch-2 -> branch-2
          86a9b80ff4..6ecb444208 branch-2.0 -> branch-2.0
          3a805074a2..9fbce1668b master -> master

          apurtell Andrew Kyle Purtell added a comment - To https://git-wip-us.apache.org/repos/asf/hbase.git 498f3bf953..1b70763b9e branch-1 -> branch-1 66941d70bb..8040c0ca76 branch-1.2 -> branch-1.2 94001b35a7..b50e149804 branch-1.3 -> branch-1.3 cd6397be6b..7182df3bd3 branch-1.4 -> branch-1.4 12d75724d7..60dcef289b branch-2 -> branch-2 86a9b80ff4..6ecb444208 branch-2.0 -> branch-2.0 3a805074a2..9fbce1668b master -> master
          larsh Lars Hofhansl added a comment -

          +1

          larsh Lars Hofhansl added a comment - +1

          The findbugs warning is not due to this patch.

          The TestSimpleRpcScheduler failure is not related. (Cannot possibly be)

          apurtell Andrew Kyle Purtell added a comment - The findbugs warning is not due to this patch. The TestSimpleRpcScheduler failure is not related. (Cannot possibly be)
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
                Prechecks
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                master Compile Tests
          +1 mvninstall 4m 21s master passed
          +1 compile 1m 31s master passed
          +1 checkstyle 1m 0s master passed
          +1 shadedjars 4m 21s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 1m 44s master passed
          +1 javadoc 0m 27s master passed
                Patch Compile Tests
          +1 mvninstall 4m 13s the patch passed
          +1 compile 1m 40s the patch passed
          -1 javac 1m 40s hbase-server generated 5 new + 183 unchanged - 5 fixed = 188 total (was 188)
          +1 checkstyle 1m 1s hbase-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 18s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 13m 16s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0.
          -1 findbugs 1m 56s hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 0m 28s the patch passed
                Other Tests
          -1 unit 36m 44s hbase-server in the patch failed.
          +1 asflicense 0m 13s The patch does not generate ASF License warnings.
          77m 54s



          Reason Tests
          FindBugs module:hbase-server
            Inconsistent synchronization of org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.regionServers; locked 50% of time Unsynchronized access at HBaseReplicationEndpoint.java:50% of time Unsynchronized access at HBaseReplicationEndpoint.java:[line 200]
            org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.getRegionServers() is unsynchronized, org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.setRegionServers(List) is synchronized At HBaseReplicationEndpoint.java:synchronized At HBaseReplicationEndpoint.java:[lines 191-200]
          Failed junit tests hadoop.hbase.ipc.TestSimpleRpcScheduler



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f
          JIRA Issue HBASE-20597
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12923971/HBASE-20597.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux dafe1436c783 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / dab0e90c54
          maven version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z)
          Default Java 1.8.0_171
          findbugs v3.1.0-RC3
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/12866/artifact/patchprocess/diff-compile-javac-hbase-server.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/12866/artifact/patchprocess/new-findbugs-hbase-server.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/12866/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/12866/testReport/
          Max. process+thread count 703 (vs. ulimit of 10000)
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/12866/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests +1 mvninstall 4m 21s master passed +1 compile 1m 31s master passed +1 checkstyle 1m 0s master passed +1 shadedjars 4m 21s branch has no errors when building our shaded downstream artifacts. +1 findbugs 1m 44s master passed +1 javadoc 0m 27s master passed       Patch Compile Tests +1 mvninstall 4m 13s the patch passed +1 compile 1m 40s the patch passed -1 javac 1m 40s hbase-server generated 5 new + 183 unchanged - 5 fixed = 188 total (was 188) +1 checkstyle 1m 1s hbase-server: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 18s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 13m 16s Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. -1 findbugs 1m 56s hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 28s the patch passed       Other Tests -1 unit 36m 44s hbase-server in the patch failed. +1 asflicense 0m 13s The patch does not generate ASF License warnings. 77m 54s Reason Tests FindBugs module:hbase-server   Inconsistent synchronization of org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.regionServers; locked 50% of time Unsynchronized access at HBaseReplicationEndpoint.java:50% of time Unsynchronized access at HBaseReplicationEndpoint.java: [line 200]   org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.getRegionServers() is unsynchronized, org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.setRegionServers(List) is synchronized At HBaseReplicationEndpoint.java:synchronized At HBaseReplicationEndpoint.java: [lines 191-200] Failed junit tests hadoop.hbase.ipc.TestSimpleRpcScheduler Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f JIRA Issue HBASE-20597 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12923971/HBASE-20597.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux dafe1436c783 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / dab0e90c54 maven version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) Default Java 1.8.0_171 findbugs v3.1.0-RC3 javac https://builds.apache.org/job/PreCommit-HBASE-Build/12866/artifact/patchprocess/diff-compile-javac-hbase-server.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/12866/artifact/patchprocess/new-findbugs-hbase-server.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/12866/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/12866/testReport/ Max. process+thread count 703 (vs. ulimit of 10000) modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/12866/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.

          I ran mvn test -Dtest=*Replication* before posting the patches and everything passed.

          apurtell Andrew Kyle Purtell added a comment - I ran mvn test -Dtest=*Replication* before posting the patches and everything passed.

          Based on a comment found in this code looks like findbugs has been warning about this.

          apurtell Andrew Kyle Purtell added a comment - Based on a comment found in this code looks like findbugs has been warning about this.
          apurtell Andrew Kyle Purtell added a comment - - edited

          Not sure if this is only a theoretical problem but might as well fix it. If the connection problem is persistent, like loss of shared trust between the clusters, we may accumulate unclosed ZKW instances over time, with a ZK send thread and event thread each, and eventually have enough leaked threads to cause OOME (cannot allocate native thread)?

          apurtell Andrew Kyle Purtell added a comment - - edited Not sure if this is only a theoretical problem but might as well fix it. If the connection problem is persistent, like loss of shared trust between the clusters, we may accumulate unclosed ZKW instances over time, with a ZK send thread and event thread each, and eventually have enough leaked threads to cause OOME (cannot allocate native thread)?

          People

            apurtell Andrew Kyle Purtell
            apurtell Andrew Kyle Purtell
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: