Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-2068

MetricsRate is missing "registry" parameter

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.20.2
    • 0.20.3, 0.90.0
    • None
    • None
    • Reviewed
    • Converts MasterStatistics "cluster_requests" attribute to a MetricsRate value (computed as requests / sec). Also adds a "requests" attribute to RegionServerStatistics MBean, also as a MetricsRate value.

    Description

      I am trying to get the graphing going using Edward Capriolo's great JMX to Cacti guide. I checked and I am missing the request rate in the JMX MBean:

      # sh 0_20/regionserver/RegionServerStatistics.sh service:jmx:rmi:///jndi/rmi://foobar:10102/jmxrmi controlRole mypass hadoop:name=RegionServerStatistics,service=RegionServer
storefiles:493 blockCacheFree:139771296 storefileIndexSizeMB:102 memstoreSizeMB:0 stores:658 blockCacheCount:8400 
regions:83 blockCacheHitRatio:0 blockCacheSize:717478944 atomicIncrementTimeNumOps:0 atomicIncrementTimeAvgTime:0 
atomicIncrementTimeMinTime:-1 atomicIncrementTimeMaxTime:0

      I checked the code and the difference between requests and the other attributes is that MetricsRate does not register itself in the MetricsRegistry used by the dynamic MBean like for example the MetricsLongValue does.

      Attachments

        1. HBASE-2068.patch
          5 kB
          Lars George
        2. HBASE-2068-0.20.patch
          5 kB
          Lars George
        3. HBASE-2068-2_0.20.patch
          11 kB
          Gary Helmling
        4. HBASE-2068-2.patch
          11 kB
          Gary Helmling

        Activity

          People

            larsgeorge Lars George
            larsgeorge Lars George
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: