Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
3.0.0-alpha-1
-
None
-
Reviewed
Description
There is quite some boilerplate code for configuring a secure HDFS cluster for tests. The code is repeated in a number of test files within HBase code base. Convert the boilerplate code into a helper method to avoid duplication and lower maintenance effort.
SecureTestCluster#setHdfsSecuredConfiguration
TestSecureExport#setUpClusterKdc
TestThriftSpnegoHttpServer#addSecurityConfigurations
TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration
Attachments
Attachments
- HBASE-20950.master.003.patch
- 21 kB
- Wei-Chiu Chuang
- HBASE-20950.master.002.patch
- 21 kB
- Wei-Chiu Chuang
- HBASE-20950.master.001.patch
- 21 kB
- Wei-Chiu Chuang
Issue Links
- relates to
-
HBASE-23760 (2.1) Helper method to configure secure DFS cluster for tests
- Resolved
Activity
Thanks for the review, yuzhihong@gmail.com. This particular change is actually unrelated to the main issue found in this jira, but while testing I found the CLUSTER object could throw NPE if the test fails unexpectedly. I can restore this change for sure.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 19s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 25s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 37s | master passed |
+1 | compile | 2m 55s | master passed |
+1 | checkstyle | 1m 46s | master passed |
+1 | shadedjars | 4m 21s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 38s | master passed |
+1 | javadoc | 1m 4s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 17s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 38s | the patch passed |
+1 | compile | 2m 53s | the patch passed |
+1 | javac | 2m 53s | the patch passed |
-1 | checkstyle | 1m 3s | hbase-server: The patch generated 3 new + 5 unchanged - 1 fixed = 8 total (was 6) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 22s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 9m 50s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 4m 13s | the patch passed |
+1 | javadoc | 1m 3s | the patch passed |
Other Tests | |||
+1 | unit | 159m 56s | hbase-server in the patch passed. |
-1 | unit | 3m 5s | hbase-thrift in the patch failed. |
+1 | unit | 4m 25s | hbase-endpoint in the patch passed. |
+1 | asflicense | 1m 10s | The patch does not generate ASF License warnings. |
217m 43s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.thrift.TestThriftSpnegoHttpServer |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12933443/HBASE-20950.master.001.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux e21a938c7658 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14 08:53:28 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / cf481d3b51 |
maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
Default Java | 1.8.0_171 |
findbugs | v3.1.0-RC3 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/13835/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/13835/artifact/patchprocess/patch-unit-hbase-thrift.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/13835/testReport/ |
Max. process+thread count | 4558 (vs. ulimit of 10000) |
modules | C: hbase-server hbase-thrift hbase-endpoint U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13835/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 23s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 59s | master passed |
+1 | compile | 3m 1s | master passed |
+1 | checkstyle | 1m 58s | master passed |
+1 | shadedjars | 4m 40s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 4m 2s | master passed |
+1 | javadoc | 1m 11s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 5m 4s | the patch passed |
+1 | compile | 2m 57s | the patch passed |
+1 | javac | 2m 57s | the patch passed |
-1 | checkstyle | 1m 14s | hbase-server: The patch generated 3 new + 5 unchanged - 1 fixed = 8 total (was 6) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 43s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 10m 41s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 4m 35s | the patch passed |
+1 | javadoc | 1m 6s | the patch passed |
Other Tests | |||
+1 | unit | 124m 45s | hbase-server in the patch passed. |
-1 | unit | 2m 20s | hbase-thrift in the patch failed. |
+1 | unit | 2m 54s | hbase-endpoint in the patch passed. |
+1 | asflicense | 1m 2s | The patch does not generate ASF License warnings. |
183m 42s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.thrift.TestThriftSpnegoHttpServer |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12933451/HBASE-20950.master.002.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 53b74c794f95 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / cf481d3b51 |
maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
Default Java | 1.8.0_171 |
findbugs | v3.1.0-RC3 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/13836/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/13836/artifact/patchprocess/patch-unit-hbase-thrift.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/13836/testReport/ |
Max. process+thread count | 4957 (vs. ulimit of 10000) |
modules | C: hbase-server hbase-thrift hbase-endpoint U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13836/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
Attach rev003 to fix the test failure and correct the checkstyle warning.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 10s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 15s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 51s | master passed |
+1 | compile | 2m 53s | master passed |
+1 | checkstyle | 1m 53s | master passed |
+1 | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 54s | master passed |
+1 | javadoc | 1m 3s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 43s | the patch passed |
+1 | compile | 2m 52s | the patch passed |
+1 | javac | 2m 52s | the patch passed |
+1 | checkstyle | 1m 10s | hbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) |
+1 | checkstyle | 0m 29s | The patch hbase-thrift passed checkstyle |
+1 | checkstyle | 0m 12s | The patch hbase-endpoint passed checkstyle |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 35s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 9m 59s | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. |
+1 | findbugs | 4m 4s | the patch passed |
+1 | javadoc | 1m 2s | the patch passed |
Other Tests | |||
+1 | unit | 124m 15s | hbase-server in the patch passed. |
+1 | unit | 2m 43s | hbase-thrift in the patch passed. |
+1 | unit | 3m 18s | hbase-endpoint in the patch passed. |
+1 | asflicense | 1m 8s | The patch does not generate ASF License warnings. |
181m 10s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12933792/HBASE-20950.master.003.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux a6e5d644ffea 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / a8e184dc77 |
maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
Default Java | 1.8.0_171 |
findbugs | v3.1.0-RC3 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/13866/testReport/ |
Max. process+thread count | 4522 (vs. ulimit of 10000) |
modules | C: hbase-server hbase-thrift hbase-endpoint U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13866/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
Results for branch branch-2
build #1051 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
+1 client integration test
Results for branch master
build #415 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
+1 client integration test
Results for branch branch-2.1
build #1788 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
+1 client integration test
Looks good overall.
I am a bit curious - why moving the join call outside the if ?