Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21088

HStoreFile should be closed in HStore#hasReferences

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

            reloadedStoreFiles = loadStoreFiles();
            return StoreUtils.hasReferences(reloadedStoreFiles);
      

      The intention of obtaining the HStoreFile's is to check for references.
      The loaded HStoreFile's should be closed prior to return to prevent leak.

      I noticed the increase in open files when running test suite. After checking recently modified code, I came to this particular method.

      Attachments

        1. 21088.v4.txt
          1.0 kB
          Ted Yu
        2. 21088.v3.txt
          0.9 kB
          Ted Yu
        3. 21088.v2.txt
          1 kB
          Ted Yu
        4. 21088.v2.txt
          1 kB
          Ted Yu
        5. 21088.v1.txt
          1 kB
          Ted Yu

        Activity

          People

            yuzhihong@gmail.com Ted Yu
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: