Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.1.0
    • hbck2
    • None

    Description

      Create hbck2 tool in hbase-operator-tools (https://github.com/apache/hbase-operator-tools.git) repo. This is not intended to be complete tool but initial changes with usage, ability to connect to server, logging, and using newly added HbckService etc. Code changes to address specific use cases can be added later and tool will evolve.

      Attachments

        1. hbase-21169.master.001.patch
          14 kB
          Umesh Agashe

        Issue Links

          Activity

            stack Michael Stack added a comment -

            I took this since I've been at it for the last day or so uagashe. Let me start up a doc for discussion of what the tool looks like. Will attach here.

            stack Michael Stack added a comment - I took this since I've been at it for the last day or so uagashe . Let me start up a doc for discussion of what the tool looks like. Will attach here.
            stack Michael Stack added a comment -

            Link to HBCK2 Design. Commentary please.

            stack Michael Stack added a comment - Link to HBCK2 Design. Commentary please.
            uagashe Umesh Agashe added a comment -

            stack, I was working on it and thought I assigned it to myself to indicate the same. Lets talk about it.

            uagashe Umesh Agashe added a comment - stack , I was working on it and thought I assigned it to myself to indicate the same. Lets talk about it.
            uagashe Umesh Agashe added a comment -

            "working' is vague in the comment above. To be clear, I have some code changes. I am not working on doc. Thanks for the doc link stack!

            uagashe Umesh Agashe added a comment - "working' is vague in the comment above. To be clear, I have some code changes. I am not working on doc. Thanks for the doc link stack !
            zhangduo Duo Zhang added a comment -

            So lots of the recover code will still be in the hbase repo? And HBCK2 is just a tool which asks HMaster to execute the recovery code? Maybe we need to introduce a new HBaseInterfaceAudience called HBCK to indicate that this tool is used by HBCK2?

            zhangduo Duo Zhang added a comment - So lots of the recover code will still be in the hbase repo? And HBCK2 is just a tool which asks HMaster to execute the recovery code? Maybe we need to introduce a new HBaseInterfaceAudience called HBCK to indicate that this tool is used by HBCK2?
            stack Michael Stack added a comment -

            So lots of the recover code will still be in the hbase repo?

            Yes. A basic tenet is that Master does the repairs.

            And HBCK2 is just a tool which asks HMaster to execute the recovery code?

            Yeah. Hopefully we can figure a few generic tools that can be combined variously to fix the sort of issues we could run into: finish-the-procedure, assigns, unassigns...

            Maybe we need to introduce a new HBaseInterfaceAudience called HBCK to indicate that this tool is used by HBCK2?

            Makes sense. Adding. Filed HBASE-21209

            stack Michael Stack added a comment - So lots of the recover code will still be in the hbase repo? Yes. A basic tenet is that Master does the repairs. And HBCK2 is just a tool which asks HMaster to execute the recovery code? Yeah. Hopefully we can figure a few generic tools that can be combined variously to fix the sort of issues we could run into: finish-the-procedure, assigns, unassigns... Maybe we need to introduce a new HBaseInterfaceAudience called HBCK to indicate that this tool is used by HBCK2? Makes sense. Adding. Filed HBASE-21209
            uagashe Umesh Agashe added a comment -

            Maybe we need to introduce a new HBaseInterfaceAudience called HBCK to indicate that this tool is used by HBCK2?

            Patch for HBASE-20941 already adds this. Its used as:

            @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.HBCK)
            
            uagashe Umesh Agashe added a comment - Maybe we need to introduce a new HBaseInterfaceAudience called HBCK to indicate that this tool is used by HBCK2? Patch for HBASE-20941 already adds this. Its used as: @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.HBCK)
            stack Michael Stack added a comment -

            Thanks uagashe Let me resolve.

            stack Michael Stack added a comment - Thanks uagashe Let me resolve.
            stack Michael Stack added a comment -

            I think its fair to say this has been well-started so resovling. I moved the 'design' from here up to the parent project. Its ongoing and it may get more eyeballs in the umbrella issue.

            stack Michael Stack added a comment - I think its fair to say this has been well-started so resovling. I moved the 'design' from here up to the parent project. Its ongoing and it may get more eyeballs in the umbrella issue.
            busbey Sean Busbey added a comment -

            is the design in a state where we could start tracking it in dev-support/design-docs in the main repo?

            busbey Sean Busbey added a comment - is the design in a state where we could start tracking it in dev-support/design-docs in the main repo?
            stack Michael Stack added a comment -

            is the design in a state where we could start tracking it in dev-support/design-docs

            Not yet. I think I'd put it over in hbase-operator-tools though rather than here in same relative location.

            stack Michael Stack added a comment - is the design in a state where we could start tracking it in dev-support/design-docs Not yet. I think I'd put it over in hbase-operator-tools though rather than here in same relative location.
            busbey Sean Busbey added a comment -

            in hbase-operator-tools could it instead be built into the website/docs for that particular repo?

            busbey Sean Busbey added a comment - in hbase-operator-tools could it instead be built into the website/docs for that particular repo?
            stack Michael Stack added a comment -

            busbey makes sense. Let me finish it up....

            stack Michael Stack added a comment - busbey makes sense. Let me finish it up....

            People

              stack Michael Stack
              uagashe Umesh Agashe
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: