Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21203

TestZKMainServer#testCommandLineWorks won't pass with default 4lw whitelist

Details

    Description

      Recent versions of ZooKeeper whitelist the so-called 4-letter word admin commands, and 'stat' is not in the default whitelist, so TestZKMainServer#testCommandLineWorks cannot get off the ground.. Set system property zookeeper.4lw.commands.whitelist=* in MiniZooKeeperCluster#setupTestEnv as we do not need to whitelist 4-letter commands for unit tests.

      Attachments

        1. HBASE-21203.patch
          1 kB
          Andrew Kyle Purtell

        Activity

          liuml07 Mingliang Liu added a comment -

          +1 (non-binding)

          liuml07 Mingliang Liu added a comment - +1 (non-binding)
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -0 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                master Compile Tests
          +1 mvninstall 5m 14s master passed
          +1 compile 0m 19s master passed
          +1 checkstyle 0m 12s master passed
          +1 shadedjars 3m 57s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 0m 30s master passed
          +1 javadoc 0m 11s master passed
                Patch Compile Tests
          +1 mvninstall 4m 40s the patch passed
          +1 compile 0m 19s the patch passed
          +1 javac 0m 19s the patch passed
          +1 checkstyle 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 0s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 10m 56s Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
          +1 findbugs 0m 34s the patch passed
          +1 javadoc 0m 11s the patch passed
                Other Tests
          +1 unit 0m 42s hbase-zookeeper in the patch passed.
          +1 asflicense 0m 9s The patch does not generate ASF License warnings.
          32m 47s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b
          JIRA Issue HBASE-21203
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12940084/HBASE-21203.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux 17a24d5df77c 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 07:31:43 UTC 2018 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 1cf920db43
          maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
          Default Java 1.8.0_181
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/14435/testReport/
          Max. process+thread count 324 (vs. ulimit of 10000)
          modules C: hbase-zookeeper U: hbase-zookeeper
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/14435/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -0 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests +1 mvninstall 5m 14s master passed +1 compile 0m 19s master passed +1 checkstyle 0m 12s master passed +1 shadedjars 3m 57s branch has no errors when building our shaded downstream artifacts. +1 findbugs 0m 30s master passed +1 javadoc 0m 11s master passed       Patch Compile Tests +1 mvninstall 4m 40s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 0s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 10m 56s Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 11s the patch passed       Other Tests +1 unit 0m 42s hbase-zookeeper in the patch passed. +1 asflicense 0m 9s The patch does not generate ASF License warnings. 32m 47s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b JIRA Issue HBASE-21203 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12940084/HBASE-21203.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 17a24d5df77c 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 07:31:43 UTC 2018 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 1cf920db43 maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) Default Java 1.8.0_181 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/14435/testReport/ Max. process+thread count 324 (vs. ulimit of 10000) modules C: hbase-zookeeper U: hbase-zookeeper Console output https://builds.apache.org/job/PreCommit-HBASE-Build/14435/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.

          If there are no concerns about this I'm going to commit this trivial test only fix.

          apurtell Andrew Kyle Purtell added a comment - If there are no concerns about this I'm going to commit this trivial test only fix.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.3-IT #481 (See https://builds.apache.org/job/HBase-1.3-IT/481/)
          HBASE-21203 TestZKMainServer#testCommandLineWorks won't pass with (apurtell: rev 508b1451d472947e7c59ad944ce2c69719f9ddbc)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.3-IT #481 (See https://builds.apache.org/job/HBase-1.3-IT/481/ ) HBASE-21203 TestZKMainServer#testCommandLineWorks won't pass with (apurtell: rev 508b1451d472947e7c59ad944ce2c69719f9ddbc) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1166 (See https://builds.apache.org/job/HBase-1.2-IT/1166/)
          HBASE-21203 TestZKMainServer#testCommandLineWorks won't pass with (apurtell: rev 8273dfad575be319457f0f55d60967c915807524)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1166 (See https://builds.apache.org/job/HBase-1.2-IT/1166/ ) HBASE-21203 TestZKMainServer#testCommandLineWorks won't pass with (apurtell: rev 8273dfad575be319457f0f55d60967c915807524) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          hudson Hudson added a comment -

          Results for branch branch-2.1
          build #360 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch branch-2.1 build #360 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test
          hudson Hudson added a comment -

          Results for branch branch-2.0
          build #847 on builds.a.o: +1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          +1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-2.0 build #847 on builds.a.o : +1 overall details (if available): +1 general checks – For more information see general report +1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-2
          build #1284 on builds.a.o: -1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch branch-2 build #1284 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test
          hudson Hudson added a comment -

          Results for branch branch-1.3
          build #476 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.3 build #476 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1.2
          build #483 on builds.a.o: +1 overall


          details (if available):

          +1 general checks
          – For more information see general report

          +1 jdk7 checks
          – For more information see jdk7 report

          +1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.2 build #483 on builds.a.o : +1 overall details (if available): +1 general checks – For more information see general report +1 jdk7 checks – For more information see jdk7 report +1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1
          build #471 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1 build #471 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch branch-1.4
          build #473 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk7 checks
          – For more information see jdk7 report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 source release artifact
          – See build output for details.

          hudson Hudson added a comment - Results for branch branch-1.4 build #473 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk7 checks – For more information see jdk7 report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 source release artifact – See build output for details.
          hudson Hudson added a comment -

          Results for branch master
          build #505 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          -1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch master build #505 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 source release artifact – See build output for details. +1 client integration test

          People

            apurtell Andrew Kyle Purtell
            apurtell Andrew Kyle Purtell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: