Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24657

JsonBean representation of metrics at /jmx endpoint now quotes all numbers

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.5.0, 1.6.0, 1.3.6, 1.4.11
    • 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.2.6
    • metrics
    • None
    • Reviewed

    Description

      HBASE-20571 had a fix to look for NaN or Infinity in numbers, and to quote those as strings. The order of the `if-else` block is different in branch-1 (https://github.com/apache/hbase/commit/2d493556f3c8ae87fb92422b525bf7c9345e6ccd) and branch-2 (https://github.com/apache/hbase/commit/39ea1efa885e2f27f41af59228e0a12c4ded08f8)

      HBASE-23015 changed the JsonBean.java code in a meaningful way, and the order of the changes were consistent between branch-1 (https://github.com/apache/hbase/commit/f77c14d18150f55ee892f8d24a5ee231c1ae7e20#diff-87e9e2722b9210eebfd8c820c5d72a46L319-L324) and branch-2 (https://github.com/apache/hbase/commit/761aef6d9d0b8a455842de4d5eac7d9486f00633#diff-2c8f5dd222141c69112c5c5b5f70cf55R319-R324) Unfortunately, they need to be reversed since the order is different between branch-1 and branch-2.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. HBASE-23015 Replace Jackson with relocated gson everywhere but hbase-rest

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed
          requires

          Bug - A problem which impairs or prevents the functions of the product. HBASE-20571 JMXJsonServlet generates invalid JSON if it has NaN in metrics

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #1999

          Web Link GitHub Pull Request #2004

          Activity

            People

              dmanning David Manning
              dmanning David Manning
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: