Followup jira to create single thread ScheduledExecutorService in AsyncConnImpl, and schedule all these periodic tasks

This is a followup Jira for comments in https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0. 

saintstack 18 hours ago Member

So, implements Stoppable rather than do what the likes of AuthUtil does where it does createDummyStoppable and then has an internal do-nothing Stoppable? Makes sense.

Perhaps add comment that it is a do-nothing stop required by ScheduledChore impls. s/isStopped/stopped/
 

huaxiangsun 18 hours ago Author Member

Will do.
 

ndimiduk 17 hours ago Member

Maybe in the future we can put a default empty implementation on the interface, and then implementers who don't need it can ignore it.
 

Apache9 17 hours ago Member

Maybe we could just use a ScheduledExecutorService at client side, the ChoreService is designed to be used at server side I believe. Anyway, not a blocker for now.