Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-26251

StochasticLoadBalancer metrics should update even if balancer doesn't run

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.5.0, 3.0.0-alpha-2
    • Balancer
    • None
    • Reviewed

    Description

      Currently we only update StochasticLoadBalancerMetrics at the very end of a balancer run, once a plan has been found. In fact, we update the metrics based on that plan even if we don't end up executing the plan, which seems incorrect. 

      Regardless of whether the balancer decides to run or not, cluster costs are changing all the time. Since we don't update these metrics any other time, operators miss out on important information about the balance of their cluster over time. 

      I briefly looked into it and it would be relatively trivial to add another call to updateStochasticCosts at the beginning of the balanceTable method, before we determine if the cluster is in need of balancing. This would be an improvement but would still miss cases where the balancer is disabled or unable to run due to regions in transition, etc.

      It would be good if we could make it so updateStochasticCosts get called periodically regardless of whether the balancer is enabled or can run.

      Attachments

        Activity

          People

            GeorryHuang Zhuoyue Huang
            bbeaudreault Bryan Beaudreault
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: