Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-26718

HFileArchiver can remove referenced StoreFiles from the archive

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      There is a comment in HFileArchiver#resolveAndArchiveFile:

      // if the file already exists in the archive, move that one to a timestamped backup. This is a
// really, really unlikely situtation, where we get the same name for the existing file, but
// is included just for that 1 in trillion chance.

      In reality, we did encounter this frequently enough to cause problems. More details will be included and linked in a separate issue.

      But regardless of how we get into this situation, we can consider a different approach to solving it. If we assume store files are immutable, and a store file with the same name and location already exists in the archive, then it can be safer to assume the file was already archived successfully, and react accordingly.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. HBASE-26722 Snapshot is corrupted due to interaction between move, warmupRegion, compaction, and HFileArchiver

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-26726 Allow disable of region warmup before graceful move

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          requires

          New Feature - A new feature of the product, which has yet to be developed. HBASE-5547 Don't delete HFiles when in "backup mode"

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #4274

          Activity

            People

              dmanning David Manning
              dmanning David Manning
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: