Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-27099

In the HFileBlock class, the log printing fspread/fsread cost time unit should be milliseconds

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.0-alpha-2, 2.3.7, 2.4.12, 2.5.1
    • 2.5.0, 2.4.13, 3.0.0-alpha-4
    • HFile
    • None
    • Reviewed

    Description

      In the HFileBlock class

       

      protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset, long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum, boolean updateMetrics, boolean intoHeap) throws IOException {
        ...
        long startTime = EnvironmentEdgeManager.currentTime();
        ...
        long duration = EnvironmentEdgeManager.currentTime() - startTime;
        if (updateMetrics) {
          HFile.updateReadLatency(duration, pread);
        }
        ...
        LOG.trace("Read {} in {} ns", hFileBlock, duration);
        ...
      }

      But Environment EdgeManager.currentTime returns milliseconds.

       

       

      Attachments

        Issue Links

          Activity

            People

              xiaozhang Xiao Zhang
              xiaozhang Xiao Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: