Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5288

Security source code dirs missing from 0.92.0 release tarballs.

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.92.0, 0.94.0
    • 0.92.1, 0.94.0
    • build
    • None

    Description

      The release tarballs have a compiled version of the hbase jars and the security tarball seems to have the compiled security bits. However, the source code and resources for security implementation are missing from the release tarballs in both distributions. They should be included in both.

      Attachments

        1. hbase-5288.patch
          0.5 kB
          Jonathan Hsieh

        Issue Links

          Activity

            jmhsieh Jonathan Hsieh added a comment -

            Tested:

            mvn package -Dskiptests
            tar xvfz target hbase-0.93.0-SNAPSHOT.tar.gz | grep security

            Saw security sources.

            jmhsieh Jonathan Hsieh added a comment - Tested: mvn package -Dskiptests tar xvfz target hbase-0.93.0-SNAPSHOT.tar.gz | grep security Saw security sources.
            jmhsieh Jonathan Hsieh added a comment -

            Hey Gary, I was working on some mvn related things and just did this patch along the way. Hope you don't mind.

            jmhsieh Jonathan Hsieh added a comment - Hey Gary, I was working on some mvn related things and just did this patch along the way. Hope you don't mind.
            ghelmling Gary Helmling added a comment -

            +1 on patch.

            Thanks, Jon! Sorry I've been a bad contributor lately.

            ghelmling Gary Helmling added a comment - +1 on patch. Thanks, Jon! Sorry I've been a bad contributor lately.
            jmhsieh Jonathan Hsieh added a comment -

            patch also applies on 0.92 and similar test includes sources.

            jmhsieh Jonathan Hsieh added a comment - patch also applies on 0.92 and similar test includes sources.
            jmhsieh Jonathan Hsieh added a comment -

            no worries.

            jmhsieh Jonathan Hsieh added a comment - no worries.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12513987/hbase-5288.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
            org.apache.hadoop.hbase.mapred.TestTableMapReduce
            org.apache.hadoop.hbase.mapreduce.TestImportTsv

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/930//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/930//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/930//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513987/hbase-5288.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/930//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/930//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/930//console This message is automatically generated.
            hudson Hudson added a comment -

            Integrated in HBase-0.92 #275 (See https://builds.apache.org/job/HBase-0.92/275/)
            HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs

            jmhsieh :
            Files :

            • /hbase/branches/0.92/CHANGES.txt
            • /hbase/branches/0.92/src/assembly/all.xml
            hudson Hudson added a comment - Integrated in HBase-0.92 #275 (See https://builds.apache.org/job/HBase-0.92/275/ ) HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/assembly/all.xml
            hudson Hudson added a comment -

            Integrated in HBase-TRUNK-security #103 (See https://builds.apache.org/job/HBase-TRUNK-security/103/)
            HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs

            jmhsieh :
            Files :

            • /hbase/trunk/src/assembly/all.xml
            hudson Hudson added a comment - Integrated in HBase-TRUNK-security #103 (See https://builds.apache.org/job/HBase-TRUNK-security/103/ ) HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs jmhsieh : Files : /hbase/trunk/src/assembly/all.xml
            hudson Hudson added a comment -

            Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/)
            HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs

            jmhsieh :
            Files :

            • /hbase/trunk/src/assembly/all.xml
            hudson Hudson added a comment - Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/ ) HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs jmhsieh : Files : /hbase/trunk/src/assembly/all.xml
            hudson Hudson added a comment -

            Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/)
            HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs (Revision 1242456)

            Result = FAILURE
            jmhsieh :
            Files :

            • /hbase/branches/0.92/CHANGES.txt
            • /hbase/branches/0.92/src/assembly/all.xml
            hudson Hudson added a comment - Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/ ) HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs (Revision 1242456) Result = FAILURE jmhsieh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/assembly/all.xml

            People

              jmhsieh Jonathan Hsieh
              jmhsieh Jonathan Hsieh
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: