Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-8544 Snapshot feature Phase 2 : Further enhancements for Ozone Snapshots
  3. HDDS-8529

[Snapshot] Refactor OmSnapshotManager constructor to reduce initialization done when snapshot feature is disabled

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • Snapshot
    • None

    Description

      This is a follow-up to HDDS-8166.

      Refactor OmSnapshotManager constructor to further reduce the initialization steps (e.g. SnapDiff DB initialization, its column family creation) that are done when snapshot feature is disabled.

      See the block comment right above OmSnapshotManager constructor for more details.

      Original block comment:

        /**
   * TODO: [SNAPSHOT] HDDS-8529: Refactor the constructor in a way that when
   *  ozoneManager.isFilesystemSnapshotEnabled() returns false,
   *  no snapshot-related background job or initialization would run,
   *  except for applying previously committed Ratis transactions in e.g.:
   *  1. {@link OMKeyPurgeRequest#validateAndUpdateCache}
   *  2. {@link OMDirectoriesPurgeRequestWithFSO#validateAndUpdateCache}
   */
  public OmSnapshotManager(OzoneManager ozoneManager) {

      Attachments

        Issue Links

          is a child of

          Sub-task - The sub-task of the issue HDDS-8166 [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              smeng Siyao Meng
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: