[HDFS-3723] All commands should support meaningful --help - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.0-alpha
Fix Version/s: 2.0.2-alpha
Component/s: scripts, tools
Labels:
None

Target Version/s:

2.0.2-alpha
Hadoop Flags:

Reviewed

Description

Some (sub)commands support -help or -h options for detailed help while others do not. Ideally, all commands should support meaningful help that works regardless of current state or configuration.

For example, hdfs zkfc --help (or -h or -help) is not very useful. Option checking should occur before state / configuration checking.

[esammer@hadoop-fed01 ~]# hdfs zkfc --help
Exception in thread "main" org.apache.hadoop.HadoopIllegalArgumentException: HA is not enabled for this namenode.
        at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.setConf(DFSZKFailoverController.java:122)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:66)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
        at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.main(DFSZKFailoverController.java:168)

This would go a long way toward better usability for ops staff.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

HDFS-3723.patch
31/Jul/12 23:13
22 kB
Jing Zhao
HDFS-3723.patch
03/Aug/12 19:00
24 kB
Jing Zhao
HDFS-3723.001.patch
13/Aug/12 21:42
34 kB
Jing Zhao
HDFS-3723.001.patch
14/Aug/12 01:05
35 kB
Jing Zhao
HDFS-3723.002.patch
14/Aug/12 08:49
39 kB
Jing Zhao
HDFS-3723.003.patch
14/Aug/12 17:51
41 kB
Jing Zhao
HDFS-3723.patch
15/Aug/12 00:30
35 kB
Suresh Srinivas

Issue Links

is related to

HDFS-11806 hdfs journalnode command should support meaningful --help

Patch Available

Activity

People

Assignee:: Jing Zhao

Reporter:: Eric Sammer

Votes:: 0 Vote for this issue

Watchers:: 10 Start watching this issue

Dates

Created:: 25/Jul/12 16:32

Updated:: 12/May/17 03:33

Resolved:: 15/Aug/12 00:06