Details
-
Bug
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
Description
Currently druid is still on org.jboss.netty here:
https://github.com/apache/druid/blob/master/core/src/main/java/org/apache/druid/java/util/http/client/response/HttpResponseHandler.java
This class is inherited here, so there is a compile-time dependency on netty3 through druid-handler module:
https://github.com/apache/hive/blob/master/druid-handler/src/java/org/apache/hadoop/hive/druid/security/RetryIfUnauthorizedResponseHandler.java
RetryIfUnauthorizedResponseHandler was copied from druid codebase in the scope of HIVE-17160 because:
https://github.com/apache/hive/blame/master/druid-handler/src/java/org/apache/hadoop/hive/druid/security/KerberosHttpClient.java#L40-L45
/** * This is a slightly modified version of kerberos module borrowed from druid project * Couple of reasons behind the copy/modification instead of mvn dependency. * 1/ Need to remove the authentication step since it not required * 2/ To avoid some un-needed transitive dependencies that can clash on the classpath like jetty-XX. */
I believe we cannot upgrade here only the copied classes, because the netty3 objects are on the public interface of ResponseHandler callbacks which is referenced by other druid classes like:
https://github.com/apache/druid/blob/master/core/src/main/java/org/apache/druid/java/util/http/client/NettyHttpClient.java#L249
response = handler.handleChunk(response, httpChunk, ++currentChunkNum);
Attachments
Issue Links
- relates to
-
HIVE-24524 LLAP ShuffleHandler: upgrade to Netty4 and remove Netty3 dependency from hive where it's possible
- Closed