Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-25917

Use default value for 'hive.default.nulls.last' when no config is available instead of false

    XMLWordPrintableJSON

Details

    Description

      In HiveParser.g#L866 we have the following code:

      protected boolean nullsLast() {
           if(hiveConf == null){
            return false;
           }
           return HiveConf.getBoolVar(hiveConf, HiveConf.ConfVars.HIVE_DEFAULT_NULLS_LAST);
         } 

      so when no hive config is available, we return "false", while we should return the property's default value:

      protected boolean nullsLast() {
           if(hiveConf == null){
            return HiveConf.ConfVars.HIVE_DEFAULT_NULLS_LAST.defaultBoolVal;
           }
           return HiveConf.getBoolVar(hiveConf, HiveConf.ConfVars.HIVE_DEFAULT_NULLS_LAST);
         } 

       

      Attachments

        Issue Links

          Activity

            People

              asolimando Alessandro Solimando
              asolimando Alessandro Solimando
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m