Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
Description
As discussed on https://lists.apache.org/thread/6rwrvsy1vn94hhs62x5tl125g3ft22kq
original mail:
What do you think about forcing coding style in Hive precommit? I remember, back in the old days, precommit printed some warnings in case some coding style (formatting, indentation, naming convention, etc.) problems were found in the patch, now it's simply not used, I guess since we're using GitHub PRs. For example: I remember I simply approved a PR a few months ago which LGTM, and later just realized it's full of 4-spaces indentation, which is wrong if we assume that code should be formatted according to the style definition here: https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml
from the thread, a a promising candidate might be spotless:
https://github.com/diffplug/spotless
https://github.com/diffplug/spotless/tree/main/plugin-maven#how-can-i-enforce-formatting-gradually-aka-ratchet
Attachments
Issue Links
- is related to
-
HIVE-28499 Intellij Idea2024 can't import iceberg&hive checkstyle files
- Open