Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4576

templeton.hive.properties does not allow values with commas

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.5.0
    • 0.13.1, 0.14.0
    • WebHCat
    • None

    Description

      templeton.hive.properties accepts a comma-separated list of key=value property pairs that will be passed to Hive.

      However, this makes it impossible to use any "value" that itself has a comma in it.

      For example:

      <property>
        <name>templeton.hive.properties</name>
        <value>hive.metastore.sasl.enabled=false,hive.metastore.uris=thrift://foo1.example.com:9083,foo2.example.com:9083</value>
      </property>
      templeton: starting [/usr/bin/hive, --service, cli, --hiveconf, hive.metastore.sasl.enabled=false, --hiveconf, hive.metastore.uris=thrift://foo1.example.com:9083, --hiveconf, foo2.example.com:9083 etc..

      because the value is parsed using standard org.apache.hadoop.conf.Configuration.getStrings() call which simply splits on commas from here:

      for (String prop : appConf.getStrings(AppConfig.HIVE_PROPS_NAME))

      This is problematic for any hive property that itself has multiple values, such as hive.metastore.uris above or hive.aux.jars.path.

      There should be some way to "escape" commas or a different delimiter should be used.

      Attachments

        1. HIVE-4576.0.13.patch
          8 kB
          Sushanth Sowmyan
        2. HIVE-4576.2.patch
          8 kB
          Eugene Koifman
        3. HIVE-4576.patch
          6 kB
          Eugene Koifman

        Activity

          People

            ekoifman Eugene Koifman
            vitaliy.fuks Vitaliy Fuks
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: