Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-5366

Refactor a few object inspector class to eliminate redundant information

    XMLWordPrintableJSON

Details

    Description

      AbstractPrimitiveObjectInspector class has two fields:

        protected PrimitiveTypeEntry typeEntry;
  protected BaseTypeParams typeParams;

      But PrimitiveTypeEntry already has member BaseTypeParams instance, which is identical to "typeParams" we see here. Thus, there is some redundant information stored at different places. Ideally, we should have a single point of truth.

      This refactoring is required by HIVE-3976 work. This is singled out to make the review easier.

      Attachments

        1. HIVE-5366.patch
          8 kB
          Xuefu Zhang

        Issue Links

          is depended upon by

          New Feature - A new feature of the product, which has yet to be developed. HIVE-3976 Support specifying scale and precision with Hive decimal type

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. HIVE-5372 Refactor TypeInfo and PrimitiveTypeEntry class hierachy to eliminate info repetition

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link https://reviews.apache.org/r/14343/

          Activity

            People

              xuefuz Xuefu Zhang
              xuefuz Xuefu Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: