Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-1510

Expect/continue not working for HttpRequest objects that are implemented with an HttpRequestWrapper

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Invalid
    • 4.3.3
    • None
    • HttpClient (classic)
    • None

    Description

      Certain sorts of requests (multipart post being one of them) use HttpRequestWrapper internally to wrap the original request. But the Expect/Continue processor has this check in it:

                  if (request instanceof HttpEntityEnclosingRequest) {
      

      That effectively disables expect/continue for all wrapped requests, since HttpRequestWrapper is not derived from HttpEntityEnclosingRequest.

      Suggestion: A better way to structure this would be to have a method in HttpRequest that the expect/continue processor would call, instead of doing an explicit instanceof class check.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              kwright@metacarta.com Karl Wright
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: