Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-1983

URIBuilder normalization change is significantly breaking

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Won't Fix
    • 4.5.7, 4.5.8
    • 4.5.9
    • None
    • None

    Description

      In 4.5.7, the behavior of URIBuilder changed in order to address HTTPCLIENT-1960. Since that version was released, I have seen a concerning number of users complain that this change has broken their code (see issue links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to allow users to opt in to the old behavior, but the new behavior is what they will get by default. This problem is difficult to work around for developers who cannot exercise exact control over the runtime version of HttpClient: the method they need might not be there, and if it is, it needs to be invoked reflectively, or in a way that tolerates a NoSuchMethodError.

      For the sake of compatibility, I propose that we change the default value of normalizeUri to false. This will be the default on the 4.5.x line only; the 5.0.x line, as well as any future 4.6.x line, will normalize by default (if an option is needed at all).

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. KNOX-1755 Revert upgrade httpclient to 4.5.7 due to HTTPCLIENT-1968

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. CXF-7955 Update HttpComponents client to 4.5.8 and core 4.4.11

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is caused by

          Bug - A problem which impairs or prevents the functions of the product. HTTPCLIENT-1960 URIBuilder incorrect handling of multiple leading slashes in path component

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. HTTPCLIENT-1968 Encoded forward slashes are not preserved when rewriting URI

          • Major - Major loss of function.
          • Resolved
          is related to

          Sub-task - The sub-task of the issue KNOX-1842 Upgrade httpclient to 4.5.10

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link GitHub Pull Request #145

          Web Link Incompatible with "org.apache.httpcomponents:httpclient:4.5.7"

          Web Link org.apache.httpcomponents:httpclient:4.5.7 breaks fetching S3 objects with consecutive slashes in the key

          Web Link Spring Boot gradle plugin 2.1.x breaks AWS labmda call

          Web Link Upgrading 'org.apache.httpcomponents:httpclient' to version 4.5.7 breaks lambda invocation

          Activity

            People

              Unassigned Unassigned
              rschmitt Ryan Schmitt
              Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m