Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-14638

Calcite engine. Support for INTERSECT operator

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      Currently, INTERSECT operator is not supported

      Attachments

        Issue Links

          Activity

            taras.ledkov, korlov, can you please have a look at the patch?

            alex_pl Aleksey Plekhanov added a comment - taras.ledkov , korlov , can you please have a look at the patch?
            tledkov-gridgain Taras Ledkov added a comment -

            alex_pl, the patch is OK with me.
            Minor comments:

            • Please file the ticket to implement sort set operations in future.
            • Why you don't use the AbstractPlannerTest#checkSplitAndSerialization at the new planner test? I agree that plan mapping & serialization is checked by integration test. But usually the planner tests covers more different plans than integration tests.
            tledkov-gridgain Taras Ledkov added a comment - alex_pl , the patch is OK with me. Minor comments: Please file the ticket to implement sort set operations in future. Why you don't use the AbstractPlannerTest#checkSplitAndSerialization at the new planner test? I agree that plan mapping & serialization is checked by integration test. But usually the planner tests covers more different plans than integration tests.

            tledkov-gridgain, thanks for your comments. I've created the ticket and added the new check to the assertPlan method. Please have a look again.

            alex_pl Aleksey Plekhanov added a comment - tledkov-gridgain , thanks for your comments. I've created the ticket and added the new check to the  assertPlan  method. Please have a look again.

            alex_pl, I've left a few comments. Please see the PR.

            korlov Konstantin Orlov added a comment - alex_pl , I've left a few comments. Please see the PR.

            korlov, I've fixed your comments, please have a look again.

            alex_pl Aleksey Plekhanov added a comment - korlov , I've fixed your comments, please have a look again.

            alex_pl, LGTM!

            korlov Konstantin Orlov added a comment - alex_pl , LGTM!

            korlov, tledkov-gridgain thanks for the review! Merged to sql-calcite branch.

            alex_pl Aleksey Plekhanov added a comment - korlov , tledkov-gridgain  thanks for the review! Merged to sql-calcite branch.

            People

              alex_pl Aleksey Plekhanov
              alex_pl Aleksey Plekhanov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4h 40m
                  4h 40m