Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-17469

cli profile commands unification

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-beta1
    • cli

    Description

      cli config profile now has two commands show and create, while setting a profile is done through a parameter, which is confusing.

      There should be a separate command to set the profile.

      In general I would suggest the commands there to look like:

      cli config show

      cli config set

      cli config get

      All repl cli commands should not accept --profile or -p parameters, all setting and getting of the params in a profile should go through its activation instead. I.e. cli config profile create newprofile ; cli config profile activate newprofile; cli config set ignite.cluster-url=http://localhost:10300

      We should retain --profile in non-repl mode.

      Profile manipulation should go like below:

      cli config profile show [<name>]

      cli config profile list

      cli config profile create <name> --copy-from

      cli config profile activate <name>

       

      Let’s please update IEP with the corresponding changes as well.

       

      Let's also make sure non-repl commands do have --profile option and auto-completion scripts are updated accordingly. Currently I don't see any suggestions on --profile there:

      tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$ ./ignite cluster config show --profile te
      st
      Unknown options: '--profile', 'test'
      Usage: ignite cluster config show [-h] [--cluster-url=<clusterUrl>]
                                        [--selector=<selector>]
      Shows cluster configuration.
            --cluster-url=<clusterUrl>
                     Url to ignite node.
        -h, --help   Show this help message and exit.
            --selector=<selector>
                     Configuration path selector.
      tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$
      

      Attachments

        Issue Links

          Activity

            People

              vpakhnushev Vadim Pakhnushev
              yuri_yudin Yury Yudin
              Semyon Danilov Semyon Danilov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h