Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-20272

Clean up of DistributionZoneManagerWatchListenerTest

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0
    • None

    Description

      Motivation

      Ticket https://issues.apache.org/jira/browse/IGNITE-18564 was closed because it is not actual anymore. But actually, the DistributionZoneManagerWatchListenerTest that was mentioned in this ticket is not actual. So we need to remove some tests in this class now and later remove this class when ticket https://issues.apache.org/jira/browse/IGNITE-19955 is implemented.

      DistributionZoneManagerWatchListenerTest has three tests:

      1. The testStaleWatchEvent is disabled. It fails on an invoke into a metastorage in which the logical topology and its version are updated. It fails because the condition of the invoke was incorrect after some changes in the code. But it is not necessary to use a condition there, I replaced it with ms.putAll, and the test passed successfully. This test can be removed because it repeats the testScaleUpDidNotChangeDataNodesWhenTriggerKeyWasConcurrentlyChanged test.
      2. testDataNodesUpdatedOnZoneManagerStart is the happy path of the restart, we already have such tests. Therefore, this test is not needed and can be removed.
      3. testStaleVaultRevisionOnZoneManagerStart This test simulates that on the zones manager restart, the data nodes for the zone will not be updated to the value corresponding to the logical topology from the vault, because zonesChangeTriggerKey > metaStorageManager.appliedRevision(). I have not found an analog of this test. I think that when the DZM restart is updated then we can update this test and move it to the more appropriate class.

      Definition of done

      1. testStaleWatchEvent and testDataNodesUpdatedOnZoneManagerStart are removed.
      2. testStaleVaultRevisionOnZoneManagerStart marked by IGNITE-19955.
      3. TODOs with IGNITE-18564 are removed.

      Attachments

        Issue Links

          Activity

            People

              Sergey Uttsel Sergey Uttsel
              Sergey Uttsel Sergey Uttsel
              Mirza Aliev Mirza Aliev
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m