Description
Motivation
Ticket https://issues.apache.org/jira/browse/IGNITE-18564 was closed because it is not actual anymore. But actually, the DistributionZoneManagerWatchListenerTest that was mentioned in this ticket is not actual. So we need to remove some tests in this class now and later remove this class when ticket https://issues.apache.org/jira/browse/IGNITE-19955 is implemented.
DistributionZoneManagerWatchListenerTest has three tests:
- The testStaleWatchEvent is disabled. It fails on an invoke into a metastorage in which the logical topology and its version are updated. It fails because the condition of the invoke was incorrect after some changes in the code. But it is not necessary to use a condition there, I replaced it with ms.putAll, and the test passed successfully. This test can be removed because it repeats the testScaleUpDidNotChangeDataNodesWhenTriggerKeyWasConcurrentlyChanged test.
- testDataNodesUpdatedOnZoneManagerStart is the happy path of the restart, we already have such tests. Therefore, this test is not needed and can be removed.
- testStaleVaultRevisionOnZoneManagerStart This test simulates that on the zones manager restart, the data nodes for the zone will not be updated to the value corresponding to the logical topology from the vault, because zonesChangeTriggerKey > metaStorageManager.appliedRevision(). I have not found an analog of this test. I think that when the DZM restart is updated then we can update this test and move it to the more appropriate class.
Definition of done
- testStaleWatchEvent and testDataNodesUpdatedOnZoneManagerStart are removed.
- testStaleVaultRevisionOnZoneManagerStart marked by
IGNITE-19955. - TODOs with
IGNITE-18564are removed.
Attachments
Issue Links
- is a child of
-
IGNITE-18564 Extend test coverage for WatchListener in DistributionZoneManager
- Resolved
- links to