Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-21106

Remove obsolete leases

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0
    • None

    Description

      Motivation

      Occurred that obsolete leases (expired leases for removed replication groups) aren't dropped themselves. Despite the fact that it's generally a leak and thus incorrect, some tests like ItSqlLogicTest may suffer from this.

      Definition of Done

      Obsolete leases are removed from the meta storage and thus no longer processed.

      Implementation Notes

      I believe that

      // Remove all expired leases that are no longer present in assignments.
      renewedLeases.entrySet().removeIf(e -> e.getValue().getExpirationTime().before(now)
        && !currentAssignmentsReplicationGroupIds.contains(e.getKey()));

      inĀ 

      org.apache.ignite.internal.placementdriver.LeaseUpdater.Updater#updateLeaseBatchInternal

      should do the trick.

      Attachments

        Issue Links

          Activity

            People

              alapin Alexander Lapin
              alapin Alexander Lapin
              Vladislav Pyatkov Vladislav Pyatkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m