Uploaded image for project: 'Commons Imaging'
  1. Commons Imaging
  2. IMAGING-199

All tEXt chunks are not returned from PngImageParser.getMetadata

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.0-alpha1
    • Format: PNG

    Description

      According to the PNG spec - Section 4.2.3 - Textual Information -

      "Any number of text chunks can appear, and more than one with the same keyword is permissible. "

      Unfortunately the PngImageParser.getMetadata method only supports a single tEXt chunk. The problem is in the following line:

      final List<PngChunk> chunks = readChunks(byteSource, new ChunkType[]

      { ChunkType.tEXt, ChunkType.zTXt, }

      , true);

      True is being passed for returnAfterFirst. I believe that false should be passed instead.

      I can submit a pull request if you agree.

      Attachments

        Activity

          People

            kinow Bruno P. Kinoshita
            remery Ric Emery
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: