Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
ghx-label-13
Description
Currently the ORC scanner allocates new memory for each string values (except for fixed size strings):
Besides the too many allocations and copying it's also bad for memory locality.
Since ORC-501 StringVectorBatch has a member named 'blob' that contains the strings in the batch: https://github.com/apache/orc/blob/branch-1.6/c%2B%2B/include/orc/Vector.hh#L126
'blob' has type DataBuffer which is movable, so Impala might be able to get ownership of it. Or, at least we could copy the whole blob array instead of copying the strings one-by-one.
ORC-501 is included in ORC version 1.6, but Impala currently only uses ORC 1.5.5.
ORC 1.6 also introduces a new string vector type, EncodedStringVectorBatch:
It uses dictionary encoding for storing the values. Impala could copy/move the dictionary as well.
Attachments
Issue Links
- is blocked by
-
ORC-600 StringDictionaryColumnReader does not update index buffer correctly
- Closed
- is depended upon by
-
IMPALA-9310 OrcStringColumnReader could move blob instead of copy
- Resolved