client-cpp session bug: can cause connection leak.

in file Session.h and Session.cpp

========================================

class Session

{    ...    std::shared_ptr <apache::thrift::transport::TSocket> transport; }

 

void Session::open(bool enableRPCCompression, int connectionTimeoutInMs)

{    ...    shared_ptr <TTransport> transport(new TFramedTransport(socket));  //here, wrongly create 1 new variable transport, and no code will call this local variable transport->close() to release connection }

 

void Session::close() {
   if (transport != NULL)

{  //here, use Session.transport       transport->close();    }

}