Uploaded image for project: 'Jackrabbit Content Repository'
  1. Jackrabbit Content Repository
  2. JCR-3303

ClusterNode's stopDelay should default to something other zero

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.4.1
    • 2.2.13, 2.4.2, 2.5
    • jackrabbit-core
    • None

    Description

      ClusterNode has a stopDelay that defaults to zero. This is problematic because it's used in joining syncThread. SyncThread is supposed to be a daemon thread which means it's not supposed to block JVM shutdown. However, by joining syncThread with a default stopDelay of zero, ClusterNode can potentially wait for syncThread to finish its job forever. This effectively makes syncThread a non-daemon thread and that can definitely make ClusterNode#stop block forever if syncThread never finishes.

      Instead of defaulting to zero, I think it'd be better if stopDelay defaulted to something more reasonable like 2 * syncDelay. There's no need to make ClusterNode block forever for sync in any case.

      Attachments

        1. JCR-3303.patch
          0.6 kB
          Mete Atamel

        Activity

          People

            Unassigned Unassigned
            meteatamel Mete Atamel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified