Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.8.0
    • None
    • None

    Description

      As per https://jackrabbit.apache.org/filevault/howto_release.html I tried

      sh check-release.sh filevault 3.7.4
      

      but that fails with:

      [INFO]    Unzipping jackrabbit-filevault-3.7.4-source-release.zip...
      Cleaning .gitignore from zip
      Cleaning .gitattributes from zip
      Cleaning .flattened-pom.xml from zip
      [INFO]    Comparing sources...
      [INFO]
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4: .asf.yaml
      Only in ./target/jackrabbit-filevault-3.7.4/zip/jackrabbit-filevault-3.7.4: DEPENDENCIES
      Only in ./target/jackrabbit-filevault-3.7.4/zip/jackrabbit-filevault-3.7.4: LICENSE
      Only in ./target/jackrabbit-filevault-3.7.4/zip/jackrabbit-filevault-3.7.4: NOTICE
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4: target-osgi-environment
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-core: max-target.bndrun
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-core: min-target.bndrun
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-rcp: max-target.bndrun
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-rcp: min-target.bndrun
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-sync: min-target.bndrun
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-validation: max-target.bndrun
      Only in ./target/jackrabbit-filevault-3.7.4/scm/jackrabbit-filevault-3.7.4/vault-validation: min-target.bndrun
      [ERROR]   NOT OK: Tagged sources are different from those in the archive
      

      Attachments

        1. JCRVLT-760-check-release-v1.patch
          2 kB
          Konrad Windszus

        Issue Links

          Activity

            reschke Julian Reschke added a comment -

            So we have:

            • three files only in the source ZIP: DEPENDENCIES, LICENSE, NOTICE
            • more files only in Git: *.bndrun, .asf.yaml

            Probably multiple reasons.

            reschke Julian Reschke added a comment - So we have: three files only in the source ZIP: DEPENDENCIES, LICENSE, NOTICE more files only in Git: *.bndrun, .asf.yaml Probably multiple reasons.
            kwin Konrad Windszus added a comment - - edited The default source-release.zip is leveraging the config from asf parent POM: https://github.com/apache/maven-apache-parent/blob/67b9c7ea70fbe847116831c0a4bbcb8862f444b5/pom.xml#L434-L460 which relies on the assembly descriptor from https://github.com/apache/maven-apache-resources/tree/apache-resource-bundles-1.5/source-release That explicitly excludes .asf.yaml ( https://github.com/apache/maven-apache-resources/blob/f609acfd574277be6382ce381f65cab2db895d8d/source-release/src/main/resources/assemblies/source-shared.xml#L61 ) adds DEPENDENCIES, LICENSE and NOTICE ( https://github.com/apache/maven-apache-resources/blob/apache-resource-bundles-1.5/source-release/src/main/resources/assemblies/source-shared.xml#L78 ) with the content from https://github.com/apache/maven-apache-resources/tree/apache-resource-bundles-1.5/jar/src/main/resources/META-INF incorrectly excludes min-target.bndrun , max-target.bndrun and target-osgi-environment due to https://github.com/apache/maven-apache-resources/blob/f609acfd574277be6382ce381f65cab2db895d8d/source-release/src/main/resources/assemblies/source-shared.xml#L30 . This regex also covers any filenames containing target . I created https://issues.apache.org/jira/browse/MASFRES-69 to track that. The last issue currently prevents that one can build FileVault from the source-release.zip.

            apache-source-release-assembly-descriptor 1.7 which fixes MASFRES-69 is under vote now: https://lists.apache.org/thread/w7ybx2k5thmzpkqgzpw6v50rf3zbv2g0

            kwin Konrad Windszus added a comment - apache-source-release-assembly-descriptor 1.7 which fixes MASFRES-69 is under vote now: https://lists.apache.org/thread/w7ybx2k5thmzpkqgzpw6v50rf3zbv2g0
            kwin Konrad Windszus added a comment - - edited

            The PR at https://github.com/apache/jackrabbit-filevault/pull/341 and the updated check-release.sh from JCRVLT-760-check-release-v1.patch should fix this issue. reschke Can you cross-check?

            kwin Konrad Windszus added a comment - - edited The PR at https://github.com/apache/jackrabbit-filevault/pull/341 and the updated check-release.sh from JCRVLT-760-check-release-v1.patch should fix this issue. reschke Can you cross-check?

            People

              kwin Konrad Windszus
              reschke Julian Reschke
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: