Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-17137

Ensure Admin APIs are properly tested

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0
    • admin
    • None

    Description

      A number of Admin client APIs don't have integration tests. While testing 3.8.0 RC0 we discovered the Admin.describeTopics() API hung. This should have been caught by tests.

      I suggest to create subtasks for each API that needs tests.

      Part 0

      https://github.com/apache/kafka/pull/16676 (done)

      createTopics + retryOnQuotaViolation
      deleteTopics + timeoutMs
      deleteTopics + retryOnQuotaViolation
      listTopics + timeoutMs
      listTopics + listInternal
      describeTopics + timeoutMs
      describeTopics + partitionSizeLimitPerResponse

      Part 1
      https://github.com/apache/kafka/pull/16648 (done)
      describeAcls + timeoutMs
      createAcls + timeoutMs
      deleteAcls + timeoutMs
      describeConfigs + timeoutMs
      alterConfigs + timeoutMs
      expireDelegationToken + expiryTimePeriodMs
      https://github.com/apache/kafka/pull/16687 (done)
      createPartitions + retryOnQuotaViolation

      Part 2
      https://github.com/apache/kafka/pull/16717 (done)

      listConsumerGroups + withTypes
      listConsumerGroupOffsets(groupId) + requireStable
      listConsumerGroupOffsets(groupSpecs) + requireStable
      listConsumerGroupOffsets(groupSpecs)
      removeMembersFromConsumerGroup + reason
      alterConsumerGroupOffsets
      alterClientQuotas + validateOnly

      Part 3
      https://github.com/apache/kafka/pull/16652 (done)
      describeUserScramCredentials
      describeProducers + brokerId
      describeTransactions + timeoutMs
      abortTransaction + timeoutMs
      listTransactions + filterStates
      listTransactions + filterProducerIds
      listTransactions + filterOnDuration

      Part 4
      https://github.com/apache/kafka/pull/16658 (done)

      fenceProducers + timeoutMs
      listClientMetricsResources
      listClientMetricsResources + timeoutMs
      clientInstanceId
      metrics

      part 5

      https://github.com/apache/kafka/pull/16905 (done)
      createDelegationToken + maxLifeTimeStamp + DELEGATION_TOKEN_EXPIRY_TIME_MS_CONFIG

      Attachments

        Issue Links

          Activity

            People

              chia7712 Chia-Ping Tsai
              mimaison Mickael Maison
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: